cancel
Showing results for 
Search instead for 
Did you mean: 
Reply
boyombo12
Frequent Visitor

Office Script issue

Dear Community. 

Kindly assist a friend. I have a flow that needs to populate an excel sheet. I have visited the office script documentation page, watched @DamoBird365 video on youtube and wrote the script but the last line is underlining "ObjLineItemOut" whenever i mouse over, it shows this error that says  "office script cannot infer the data type of this variable. please declare a type for the variable." which i dont understand. Here is the code. The "Lineitemarray" that got passed as an argument is from my flow and the screenshoot is shown. Kindly assistLineitemarray.png

 

 

 

function main(workbook: ExcelScript.Workbook,
  StaffName:string,
  Total:string,
  Currency:string,
  Lineitemarray:string="[{}]"
  )
  {
  // your code here
  let sheet = workbook.getFirstWorksheet();

  //update variable pay sheet
  sheet.getRange("C6").setValue(StaffName);
  sheet.getRange("N6").setValue(Currency + Total);

  let ObjLineItemOut = JSON.parse(Lineitemarray);

 

 

3 ACCEPTED SOLUTIONS

Accepted Solutions
DamoBird365
Microsoft
Microsoft

Hi @boyombo12 

 

I've spotted a few wee mistakes which should hopefully get you up and running - nearly there though - good effort 😉

 

First thing is the key-value milestone, defined as milestone in the interface but mileStone in array.  Note the capital S.  If you adjust the script, you've got both the interface and for loop to update.

 

Then the main error "Cannot read property 'month' of undefined".  This is caused by the for loop length.  The array key index starts from 0 and the length of your example is 2.  So it must be less than the length, not less than or equal as there will never be an index equal to length.  i=0 and 1 for length 2.

 

  for (let i = 0; i < lineItems.length; i++)

 

Finally, your columns are A to L (not M).  This causes an error after you resolve the above.

 

If this post helps, then please consider Accept it as the solution to help the other members find it more quickly.
Cheers,
Damien


P.S. take a look at my new blog here and like & subscribe to my YouTube Channel thanks 😉

View solution in original post

Hi @boyombo12 ,

Thanks for the tip! The flow now runs with those corrections, but the Script still reads "InventoryArray undefined". The flow also won't populate the excel sheet for the inventory arrayvar. (It populates the facultyName just fine) .Any ideas on why the flow might not be populating the excel template ? The output of the Compose action that calls the select output seems correct (see the image below- had to censor sensitive info), but the script won't transfer it to the excel cells that I defined in the script. Thank you very much!

bordo_1-1624635351413.png

 

 

 

 

 

 

 

View solution in original post

Hi, 

You are almost there. I noticed some errors again. In your formattedrow, I could see currentObject.Serial, currentObject.WarrantyStatus, currentObject.WarrantyEnd but in compose Output I saw it as "Serial Number", "Warranty Status" and Warranty End. You have to replicate whatever in your compose in the interface. Note: Typescript and Javascript wont accept space in variable name. In you compose connector, change  Serial Number to SerialNumber, Warranty Status to WarrantyStatus and Warranty End to WarrantyEnd. Make sure it is declared like that in your interface too. Also effect the change on the formattedrow. It should work after that.

View solution in original post

19 REPLIES 19
DamoBird365
Microsoft
Microsoft

Hi @boyombo12 

 

I was lucky enough to have the Excel team look at my script and I didn't initially get that error you mention, albeit i did in later release of Office Scripts.  You need to define the types for the items in the array.  If you take a look here https://github.com/DamoBird365/PowerAutomate/tree/main/ExcelInvoiceDemo you will be able to look at the excelscriptsv1 vs v2. 

 

Below is v2

 

function main(
  workbook: ExcelScript.Workbook,
  invoiceNumber: string,
  date: string,
  paymentMethod: string,
  chequeNo: string,
  jobNo: string,
  vatRate: number,
  customer: Customer,
  sales: Sales[],
) {
  // Get the first worksheet 
  const sheet = workbook.getFirstWorksheet();


  //Update Header of Sales Receipt 
  sheet.getRange("G2").setValue(invoiceNumber);
  sheet.getRange("G3").setValue(date);
  sheet.getRange("B9").setValue(paymentMethod);
  sheet.getRange("D9").setValue(chequeNo);
  sheet.getRange("E9").setValue(jobNo);
  sheet.getRange("G27").setValue(vatRate);


  //Update Customer Details
  const formattedCustomer = [[customer.name], [customer.companyName], [customer.street], [customer.city], [customer.phone]];
  sheet.getRange("C2:C6").setValues(formattedCustomer);


  //Update Sales Lines 
  const salesOffset = 12; //starting row for items on invoice 
  for (let i = 0; i < sales.length; i++) {
    const currentSales = sales[i];
    const formattedSales = [[currentSales.quantity, currentSales.itemNumber, currentSales.description, currentSales.unitPrice, currentSales.discount]];
    const saleCell = `B${salesOffset + i}:F${salesOffset + i}`;
    sheet.getRange(saleCell).setValues(formattedSales);
  }
}


interface Customer {
  name: string,
  companyName: string,
  street: string,
  city: string,
  phone: string,
}


interface Sales {
  quantity: number,
  itemNumber: string,
  description: string,
  unitPrice: number,
  discount: number,
}

 

Note that at the end of the script there is a definition for the Array variable as an interface.  If you provide this as part of the script file, it should then hopefully work as planned and PowerAutomate will enforce the types that you specify.

 

The following video covers your scenario https://www.youtube.com/watch?v=Q7GLQnvJJF0

 

You can jump to the key moment in the video here https://www.youtube.com/watch?v=Q7GLQnvJJF0&t=263

 

If this post helps, then please consider Accept it as the solution to help the other members find it more quickly.
Cheers,
Damien


P.S. take a look at my new blog here and like & subscribe to my YouTube Channel thanks 😉

Thanks for the response. I still have a challenge. i tried to reference my Lineitemarray as (lineitemarray: Lineitemarray[ ]) just like you did for your Sales array but it got underlined again. what connector did you use for you salaes array?? I would appreciate if you could share the flow screenshot.  I used the select connector for mine. Thanks 

DamoBird365
Microsoft
Microsoft

Hi @boyombo12 

 

Try this - I am not a Typescript expert btw 😉 but the parse expression expects a string, you can pass the array direct to the office script.

 

function main(workbook: ExcelScript.Workbook,
  StaffName: string,
  Total: string,
  Currency: string,
  Lineitemarray: Lineitemarray[]

) {
  // your code here
  let sheet = workbook.getFirstWorksheet();

  //update variable pay sheet
  sheet.getRange("C6").setValue(StaffName);
  sheet.getRange("N6").setValue(Currency + Total);

}

interface Lineitemarray {
  Month: string,
  InvNo: string,
  Client: string,
  Milestone: string,
  Role: string,
}

 

My flow looks like follows (and there is no reason you cannot use a Select):

 

DamoBird365_0-1623305132546.png

 

And after it runs, I get the following saved to Excel:

 

DamoBird365_1-1623305167800.png

 

If this post helps, then please consider Accept it as the solution to help the other members find it more quickly.
Cheers,
Damien


P.S. take a look at my new blog here and like & subscribe to my YouTube Channel thanks 😉

 

Yours is working because your compose has a static data as the array. Mine is dynamic from get items value. here is the error message and my flow. I saw your message since but was doin a research myself to get it solved but all proved abortive.  

typescript.pngselect connector.png

@boyombo12 
Have you defined an interface for your array?

 

It doesn’t matter about my array being static, check my video and n excel invoicing. In this video I call the data dynamically and run the script 4 times in an apply to each.

 

I believe your error relates to no array definition.

 

If this post helps, then please consider Accept it as the solution to help the other members find it more quickly.
Cheers,
Damien


P.S. take a look at my new blog here and like & subscribe to my YouTube Channel thanks 😉

I have gone through all your videos on this issue. i dont know what the problem is from my end. Here is my script and the flow. The script isnt showing any error but whenever i run my flow i get the error "We were unable to run the script. Please try again.
Runtime error: Line 19: Cannot read property 'month' of undefined"  I have been on this for days. Im getting tired. 

 

function main(workbook: ExcelScript.Workbook,
  StaffName: string,
  Total: string,
  Currency: string,
  lineItems: LineItemarray[]

) {
  // your code here
  let sheet = workbook.getFirstWorksheet();

  //update variable pay sheet
  sheet.getRange("C6").setValue(StaffName);
  sheet.getRange("M6").setValue(Currency + Total);

  const lineOffset = 8; //starting row for items on invoice 

  for (let i = 0; i <= lineItems.length; i++) {
    const currentLineitem = lineItems[i];
    const formattedLineItem = [[currentLineitem.month, currentLineitem.invoiceNumber, currentLineitem.clientName, currentLineitem.milestone, currentLineitem.role, currentLineitem.inflowReceived, currentLineitem.invoicedAmount, currentLineitem.vat, currentLineitem.netInflow, currentLineitem.variablePay, currentLineitem.wht, currentLineitem.netCreditedToAcct]];
    const lineCell = `A${lineOffset + i}:M${lineOffset + i}`;
    sheet.getRange(lineCell).setValues(formattedLineItem);
  }

}
interface LineItemarray {
  month: string,
  invoiceNumber: string,
  clientName: string,
  milestone: string,
  role: string,
  inflowReceived: string,
  invoicedAmount: string,
  vat: string,
  netInflow: string,
  variablePay: string,
  wht: string,
  netCreditedToAcct: string
}

 

Lineitem.pngerror.png

@boyombo12 

 

What does the history output of your lineitemarray select look like? 

Damien

The Output body of the select returned 

 

[
{
"month": "April",
"invoiceNumber": "ED/INV/2/0024",
"clientName": "clear code",
"mileStone": "Second",
"role": "Account Role",
"inflowReceived": ".4,600,000",
"invoicedAmount": "4,000,000.00",
"vat": "300,000.00",
"netInflow": "3,700,000.00",
"variablePay": "97,680.00",
"wht": "4,884.00",
"netCreditedToAcct": "92,796.00"
},
{
"month": "April",
"invoiceNumber": "DJL/INV/2/0024",
"clientName": "Eno",
"mileStone": "Second",
"role": "Account Role",
"inflowReceived": ".5,000,000",
"invoicedAmount": "4,000,000.00",
"vat": "300,000.00",
"netInflow": "3,700,000.00",
"variablePay": "97,680.00",
"wht": "4,884.00",
"netCreditedToAcct": "92,796.00"
}
]

DamoBird365
Microsoft
Microsoft

Hi @boyombo12 

 

I've spotted a few wee mistakes which should hopefully get you up and running - nearly there though - good effort 😉

 

First thing is the key-value milestone, defined as milestone in the interface but mileStone in array.  Note the capital S.  If you adjust the script, you've got both the interface and for loop to update.

 

Then the main error "Cannot read property 'month' of undefined".  This is caused by the for loop length.  The array key index starts from 0 and the length of your example is 2.  So it must be less than the length, not less than or equal as there will never be an index equal to length.  i=0 and 1 for length 2.

 

  for (let i = 0; i < lineItems.length; i++)

 

Finally, your columns are A to L (not M).  This causes an error after you resolve the above.

 

If this post helps, then please consider Accept it as the solution to help the other members find it more quickly.
Cheers,
Damien


P.S. take a look at my new blog here and like & subscribe to my YouTube Channel thanks 😉

I salute and appreciate you for your relentless effort to assist me. i almost gave up. When they say "Your head is there in Lagos Nigeria, it shows you are highly respected. Let me use this Medium to say Your head is there. 😁

Hi Damien!

 

Your videos are super helpful and I've watched them all to compose my own flow. It is slightly different than yours as my scenario was not the same. I am receiving a similar error with my flow, it reads as "We were unable to run the script. Please try again.
Runtime error: Line 20: Cannot read property 'length' of undefined". I've defined my array but I keep receiving this error. Would you be able to help me with this ? I would appreciate any insights.

 

Here is my script:

 

function main(
  
  workbook: ExcelScript.Workbook,
  facultyName: string,
  InventoryArray: arrayvar[]

  ){
  // Get the RerportTemplate worksheeet from thr workbook
  let worksheet = workbook.getWorksheet("ReportTemplate");

  worksheet.getRange("C10").setValue(facultyName);


  const startInventory = 17;

  for (let i= 0; i < InventoryArray.length; i++) {
    const currentObject = InventoryArray[i];

    const formattedrow = [[currentObject.title, currentObject.model, currentObject.manufacturer, currentObject.serial, currentObject.warrantystatus, currentObject.warrantyend,]];
    
    const rowRange = `B${startInventory + i}:G${startInventory + i}`;
    worksheet.getRange(rowRange).setValues(formattedrow);
  }

  return "List" + InventoryArray.length + "Records Loaded in Excel"
  
}
  
interface arrayvar {
  title: string,
  model: string,
  manufacturer: string,
  serial: string,
  warrantystatus: string,
  warrantyend: string,
}
 
 
 
And here is my flow:
 
bordo_1-1624596418474.png

 


 

Hello,

 I saw some few mistakes that needs to be corrected. the arravar on the flow has keys Title, Model, Manufacturer, e.t.c that all start with uppercase letters but the interface declared and  const formattedrow variable declared have all in lowercase. Kindly make sure the case is thesame on the flow, interface and const formattedrow . Once you correct that, it should work

Hi @boyombo12 ,

Thanks for the tip! The flow now runs with those corrections, but the Script still reads "InventoryArray undefined". The flow also won't populate the excel sheet for the inventory arrayvar. (It populates the facultyName just fine) .Any ideas on why the flow might not be populating the excel template ? The output of the Compose action that calls the select output seems correct (see the image below- had to censor sensitive info), but the script won't transfer it to the excel cells that I defined in the script. Thank you very much!

bordo_1-1624635351413.png

 

 

 

 

 

 

 

Hi, 

You are almost there. I noticed some errors again. In your formattedrow, I could see currentObject.Serial, currentObject.WarrantyStatus, currentObject.WarrantyEnd but in compose Output I saw it as "Serial Number", "Warranty Status" and Warranty End. You have to replicate whatever in your compose in the interface. Note: Typescript and Javascript wont accept space in variable name. In you compose connector, change  Serial Number to SerialNumber, Warranty Status to WarrantyStatus and Warranty End to WarrantyEnd. Make sure it is declared like that in your interface too. Also effect the change on the formattedrow. It should work after that.

bordo
Frequent Visitor

Hi @boyombo12 ,

 

That did the trick! Thank you so much for your help.

Happy that you are good to go. Kindly accept my comment as the solution to help other community members that could have such challenge in the nearest future.

takolota
Super User
Super User

So if anyone is getting really confused why there's an error on the top line where you're declaring the flow array variable like 
TestArray: testArray[]

And the interface at the bottom has your name like testArray greyed out, make sure you closed off the curly bracket } to the rest of the code before the interface. The interface is a separate segment of the code.
Took me a good 15 minutes to figure out what in the world was wrong. 😅

abhishja
Frequent Visitor

Hi,

why we are seeing this action currently can't be recorded for Repeated items labels and Buttons (ShowDrillIndicators) in office scrip. Please advise asap

 

Regards,

Abhishek

abhishja_0-1683974705630.png

 

Helpful resources

Announcements

Back to Basics: Tuesday Tip #2: All About Community Ranks

This weekly series is our way of helping the amazing members of our community--both new members and seasoned veterans--learn and grow in how to best engage in the community! Each Tuesday, we will feature new areas of content that will help you best understand the community--from ranking and badges to profile avatars, from Super Users to blogging in the community. Our hope is that this information will help each of our community members grow in their experience with Power Platform, with the community, and with each other!   Have you ever wondered how your fellow community members earn the different ranks available? What is the difference between an Advocate and a Helper, a Solution Sage and a Community Champion? In today's #TuesdayTip, we share the secrets and tips to help YOU keep your ranking growing--and why it's so important to our communities. What are community ranks? - Power Platform Community (microsoft.com)   Get the details in this Knowledge Base article that shows you what ranks are, how they are achieved, and what they mean to you as you engage with other community members on a regular basis. Once you start your journey in the community, ranking up, you'll find the benefits. So get busy with those kudos, solutions, and more! We can't wait to see how you rank!That's it for this week. Tune in for more Tuesday Tips next Tuesday and join the community as we continue to get "Back to Basics."

It's #MPPC23 Week! Check Out the Community Sessions and Events Happening in Vegas

After all the planning and preparing, the annual Microsoft Power Platform Conference is finally here! We are excited to see so many of our community in Las Vegas this week. To help make sure you don't miss any of the workshops, sessions, and events we have planned, make sure to check out this handy Community One-Sheet, and download the pdf today! Make sure to stop by the Community Lounge to meet @hugobernier, @EricArcher, @heaher_italent, and @AshleyFelts from our team!    

Join Us for the First-Ever Biz Apps Community User Group Meeting: Live from MPPC23

      Join us for the first-ever the Biz Apps Community User Group meeting live from the Power Platform Conference! This one hour user group meeting is all about discovering the value and benefits of User Groups! Discover how you can find a group in your local area or about specific topics where you can learn new skills and meet like-minded people as a user group member.   Hear from User Group leaders about why they do what they do and what resources they receive to help them succeed as community ambassadors. If you have never attended a User Group meeting before, this will be a great introduction! We hope you are inspired to find a group that meets your unique interests!   October 5th at 2:15 pm Pacific time   If you're attending #MPPC23 in Las Vegas, join us in person! Find out more here: https://powerplatformconf.com/#!/session/Biz%20Apps%20Community%20User%20Group%20Meeting%20-%20Live%20from%20MPPC/6172   Not at MPPC23? Attend vvirtually by registering here: https://aka.ms/MPPCusergroupmeeting2023    If you can't attend this meeting live, don't worry! We will record this meeting and share it with the Community at powerusers.microsoft.com 

Back to Basics: Tuesday Tip #1: All About YOUR Community Account

We are excited to kick off our new #TuesdayTIps series, "Back to Basics." This weekly series is our way of helping the amazing members of our community--both new members and seasoned veterans--learn and grow in how to best engage in the community! Each Tuesday, we will feature new areas of content that will help you best understand the community--from ranking and badges to profile avatars, from Super Users to blogging in the community. Our hope is that this information will help each of our community members grow in their experience with Power Platform, with the community, and with each other!     This Week's Tips: Account Support: Changing Passwords, Changing Email Addresses or Usernames, "Need Admin Approval," Etc.Wondering how to get support for your community account? Check out the details on these common questions and more. Just follow the link below for articles that explain it all.Community Account Support - Power Platform Community (microsoft.com)   All About GDPR: How It Affects Closing Your Community Account (And Why You Should Think Twice Before You Do)GDPR, the General Data Protection Regulation (GDPR), took effect May 25th 2018. A European privacy law, GDPR imposes new rules on companies and other organizations offering goods and services to people in the European Union (EU), or that collect and analyze data tied to EU residents. GDPR applies no matter where you are located, and it affects what happens when you decide to close your account. Read the details here:All About GDPR - Power Platform Community (microsoft.com)   Getting to Know You: Setting Up Your Community Profile, Customizing Your Profile, and More.Your community profile helps other members of the community get to know you as you begin to engage and interact. Your profile is a mirror of your activity in the community. Find out how to set it up, change your avatar, adjust your time zone, and more. Click on the link below to find out how:Community Profile, Time Zone, Picture (Avatar) & D... - Power Platform Community (microsoft.com)   That's it for this week. Tune in for more Tuesday Tips next Tuesday and join the community as we get "Back to Basics."

Announcing the MPPC's Got Power Talent Show at #MPPC23

Are you attending the Microsoft Power Platform Conference 2023 in Las Vegas? If so, we invite you to join us for the MPPC's Got Power Talent Show!      Our talent show is more than a show—it's a grand celebration of connection, inspiration, and shared journeys. Through stories, skills, and collective experiences, we come together to uplift, inspire, and revel in the magic of our community's diverse talents. This year, our talent event promises to be an unforgettable experience, echoing louder and brighter than anything you've seen before.    We're casting a wider net with three captivating categories:  Demo Technical Solutions: Show us your Power Platform innovations, be it apps, flows, chatbots, websites or dashboards... Storytelling: Share tales of your journey with Power Platform. Hidden Talents: Unveil your creative side—be it dancing, singing, rapping, poetry, or comedy. Let your talent shine!    Got That Special Spark? A Story That Demands to Be Heard? Your moment is now!  Sign up to Showcase Your Brilliance: https://aka.ms/MPPCGotPowerSignUp  Deadline for submissions: Thursday, Sept 28th    How It Works:  Submit this form to sign up: https://aka.ms/MPPCGotPowerSignUp  We'll contact you if you're selected. Get ready to be onstage!  The Spotlight is Yours: Each participant has 3-5 minutes to shine, with insightful commentary from our panel of judges. We’re not just giving you a stage; we’re handing you the platform to make your mark.     Be the Story We Tell: Your talents and narratives will not just entertain but inspire, serving as the bedrock for our community’s future stories and successes.    Celebration, Surprises, and Connections: As the curtain falls, the excitement continues! Await surprise awards and seize the chance to mingle with industry experts, Microsoft Power Platform leaders, and community luminaries. It's not just a show; it's an opportunity to forge connections and celebrate shared successes.    Event Details:  Date and Time: Wed Oct 4th, 6:30-9:00PM   Location: MPPC23 at the MGM Grand, Las Vegas, NV, USA  

September User Group Success Story: Reading Dynamics 365 & Power Platform User Group

The Reading Dynamics 365 and Power Platform User Group is a community-driven initiative that started in September 2022. It has quickly earned recognition for its enthusiastic leadership and resilience in the face of challenges. With a focus on promoting learning and networking among professionals in the Dynamics 365 and Power Platform ecosystem, the group has grown steadily and gained a reputation for its commitment to its members!   The group, which had its inaugural event in January 2023 at the Microsoft UK Headquarters in Reading, has since organized three successful gatherings, including a recent social lunch. They maintain a regular schedule of four events per year, each attended by an average of 20-25 enthusiastic participants who enjoy engaging talks and, of course, pizza.   The Reading User Group's presence is primarily spread through LinkedIn and Meetup, with the support of the wider community. This thriving community is managed by a dedicated team consisting of Fraser Dear, Tim Leung, and Andrew Bibby, who serves as the main point of contact for the UK Dynamics 365 and Power Platform User Groups.   Andrew Bibby, an active figure in the Dynamics 365 and Power Platform community, nominated this group due to his admiration for the Reading UK User Group's efforts. He emphasized their remarkable enthusiasm and success in running the group, noting that they navigated challenges such as finding venues with resilience and smiles on their faces. Despite being a relatively new group with 20-30 members, they have managed to achieve high attendance at their meetings.   The group's journey began when Fraser Dear moved to the Reading area and realized the absence of a user group catering to professionals in the Dynamics 365 and Power Platform space. He reached out to Andrew, who provided valuable guidance and support, allowing the Reading User Group to officially join the UK Dynamics 365 and Power Platform User Groups community.   One of the group's notable achievements was overcoming the challenge of finding a suitable venue. Initially, their "home" was the Microsoft UK HQ in Reading. However, due to office closures, they had to seek a new location with limited time. Fortunately, a connection with Stephanie Stacey from Microsoft led them to Reading College and its Institute of Technology. The college generously offered them event space and support, forging a mutually beneficial partnership where the group promotes the Institute and encourages its members to support the next generation of IT professionals.   With the dedication of its leadership team, the Reading Dynamics 365 and Power Platform User Group is poised to continue growing and thriving! Their story exemplifies the power of community-driven initiatives and the positive impact they can have on professional development and networking in the tech industry. As they move forward with their upcoming events and collaborations with Reading College, the group is likely to remain a valuable resource for professionals in the Reading area and beyond.  

Users online (3,642)