cancel
Showing results for 
Search instead for 
Did you mean: 
Reply
boyombo12
Frequent Visitor

Office Script issue

Dear Community. 

Kindly assist a friend. I have a flow that needs to populate an excel sheet. I have visited the office script documentation page, watched @DamoBird365 video on youtube and wrote the script but the last line is underlining "ObjLineItemOut" whenever i mouse over, it shows this error that says  "office script cannot infer the data type of this variable. please declare a type for the variable." which i dont understand. Here is the code. The "Lineitemarray" that got passed as an argument is from my flow and the screenshoot is shown. Kindly assistLineitemarray.png

 

 

 

function main(workbook: ExcelScript.Workbook,
  StaffName:string,
  Total:string,
  Currency:string,
  Lineitemarray:string="[{}]"
  )
  {
  // your code here
  let sheet = workbook.getFirstWorksheet();

  //update variable pay sheet
  sheet.getRange("C6").setValue(StaffName);
  sheet.getRange("N6").setValue(Currency + Total);

  let ObjLineItemOut = JSON.parse(Lineitemarray);

 

 

3 ACCEPTED SOLUTIONS

Accepted Solutions
DamoBird365
Employee
Employee

Hi @boyombo12 

 

I've spotted a few wee mistakes which should hopefully get you up and running - nearly there though - good effort 😉

 

First thing is the key-value milestone, defined as milestone in the interface but mileStone in array.  Note the capital S.  If you adjust the script, you've got both the interface and for loop to update.

 

Then the main error "Cannot read property 'month' of undefined".  This is caused by the for loop length.  The array key index starts from 0 and the length of your example is 2.  So it must be less than the length, not less than or equal as there will never be an index equal to length.  i=0 and 1 for length 2.

 

  for (let i = 0; i < lineItems.length; i++)

 

Finally, your columns are A to L (not M).  This causes an error after you resolve the above.

 

If this post helps, then please consider Accept it as the solution to help the other members find it more quickly.
Cheers,
Damien


P.S. take a look at my new blog here and like & subscribe to my YouTube Channel thanks 😉

View solution in original post

Hi @boyombo12 ,

Thanks for the tip! The flow now runs with those corrections, but the Script still reads "InventoryArray undefined". The flow also won't populate the excel sheet for the inventory arrayvar. (It populates the facultyName just fine) .Any ideas on why the flow might not be populating the excel template ? The output of the Compose action that calls the select output seems correct (see the image below- had to censor sensitive info), but the script won't transfer it to the excel cells that I defined in the script. Thank you very much!

bordo_1-1624635351413.png

 

 

 

 

 

 

 

View solution in original post

Hi, 

You are almost there. I noticed some errors again. In your formattedrow, I could see currentObject.Serial, currentObject.WarrantyStatus, currentObject.WarrantyEnd but in compose Output I saw it as "Serial Number", "Warranty Status" and Warranty End. You have to replicate whatever in your compose in the interface. Note: Typescript and Javascript wont accept space in variable name. In you compose connector, change  Serial Number to SerialNumber, Warranty Status to WarrantyStatus and Warranty End to WarrantyEnd. Make sure it is declared like that in your interface too. Also effect the change on the formattedrow. It should work after that.

View solution in original post

22 REPLIES 22
DamoBird365
Employee
Employee

Hi @boyombo12 

 

I was lucky enough to have the Excel team look at my script and I didn't initially get that error you mention, albeit i did in later release of Office Scripts.  You need to define the types for the items in the array.  If you take a look here https://github.com/DamoBird365/PowerAutomate/tree/main/ExcelInvoiceDemo you will be able to look at the excelscriptsv1 vs v2. 

 

Below is v2

 

function main(
  workbook: ExcelScript.Workbook,
  invoiceNumber: string,
  date: string,
  paymentMethod: string,
  chequeNo: string,
  jobNo: string,
  vatRate: number,
  customer: Customer,
  sales: Sales[],
) {
  // Get the first worksheet 
  const sheet = workbook.getFirstWorksheet();


  //Update Header of Sales Receipt 
  sheet.getRange("G2").setValue(invoiceNumber);
  sheet.getRange("G3").setValue(date);
  sheet.getRange("B9").setValue(paymentMethod);
  sheet.getRange("D9").setValue(chequeNo);
  sheet.getRange("E9").setValue(jobNo);
  sheet.getRange("G27").setValue(vatRate);


  //Update Customer Details
  const formattedCustomer = [[customer.name], [customer.companyName], [customer.street], [customer.city], [customer.phone]];
  sheet.getRange("C2:C6").setValues(formattedCustomer);


  //Update Sales Lines 
  const salesOffset = 12; //starting row for items on invoice 
  for (let i = 0; i < sales.length; i++) {
    const currentSales = sales[i];
    const formattedSales = [[currentSales.quantity, currentSales.itemNumber, currentSales.description, currentSales.unitPrice, currentSales.discount]];
    const saleCell = `B${salesOffset + i}:F${salesOffset + i}`;
    sheet.getRange(saleCell).setValues(formattedSales);
  }
}


interface Customer {
  name: string,
  companyName: string,
  street: string,
  city: string,
  phone: string,
}


interface Sales {
  quantity: number,
  itemNumber: string,
  description: string,
  unitPrice: number,
  discount: number,
}

 

Note that at the end of the script there is a definition for the Array variable as an interface.  If you provide this as part of the script file, it should then hopefully work as planned and PowerAutomate will enforce the types that you specify.

 

The following video covers your scenario https://www.youtube.com/watch?v=Q7GLQnvJJF0

 

You can jump to the key moment in the video here https://www.youtube.com/watch?v=Q7GLQnvJJF0&t=263

 

If this post helps, then please consider Accept it as the solution to help the other members find it more quickly.
Cheers,
Damien


P.S. take a look at my new blog here and like & subscribe to my YouTube Channel thanks 😉

Thanks for the response. I still have a challenge. i tried to reference my Lineitemarray as (lineitemarray: Lineitemarray[ ]) just like you did for your Sales array but it got underlined again. what connector did you use for you salaes array?? I would appreciate if you could share the flow screenshot.  I used the select connector for mine. Thanks 

DamoBird365
Employee
Employee

Hi @boyombo12 

 

Try this - I am not a Typescript expert btw 😉 but the parse expression expects a string, you can pass the array direct to the office script.

 

function main(workbook: ExcelScript.Workbook,
  StaffName: string,
  Total: string,
  Currency: string,
  Lineitemarray: Lineitemarray[]

) {
  // your code here
  let sheet = workbook.getFirstWorksheet();

  //update variable pay sheet
  sheet.getRange("C6").setValue(StaffName);
  sheet.getRange("N6").setValue(Currency + Total);

}

interface Lineitemarray {
  Month: string,
  InvNo: string,
  Client: string,
  Milestone: string,
  Role: string,
}

 

My flow looks like follows (and there is no reason you cannot use a Select):

 

DamoBird365_0-1623305132546.png

 

And after it runs, I get the following saved to Excel:

 

DamoBird365_1-1623305167800.png

 

If this post helps, then please consider Accept it as the solution to help the other members find it more quickly.
Cheers,
Damien


P.S. take a look at my new blog here and like & subscribe to my YouTube Channel thanks 😉

 

Yours is working because your compose has a static data as the array. Mine is dynamic from get items value. here is the error message and my flow. I saw your message since but was doin a research myself to get it solved but all proved abortive.  

typescript.pngselect connector.png

@boyombo12 
Have you defined an interface for your array?

 

It doesn’t matter about my array being static, check my video and n excel invoicing. In this video I call the data dynamically and run the script 4 times in an apply to each.

 

I believe your error relates to no array definition.

 

If this post helps, then please consider Accept it as the solution to help the other members find it more quickly.
Cheers,
Damien


P.S. take a look at my new blog here and like & subscribe to my YouTube Channel thanks 😉

I have gone through all your videos on this issue. i dont know what the problem is from my end. Here is my script and the flow. The script isnt showing any error but whenever i run my flow i get the error "We were unable to run the script. Please try again.
Runtime error: Line 19: Cannot read property 'month' of undefined"  I have been on this for days. Im getting tired. 

 

function main(workbook: ExcelScript.Workbook,
  StaffName: string,
  Total: string,
  Currency: string,
  lineItems: LineItemarray[]

) {
  // your code here
  let sheet = workbook.getFirstWorksheet();

  //update variable pay sheet
  sheet.getRange("C6").setValue(StaffName);
  sheet.getRange("M6").setValue(Currency + Total);

  const lineOffset = 8; //starting row for items on invoice 

  for (let i = 0; i <= lineItems.length; i++) {
    const currentLineitem = lineItems[i];
    const formattedLineItem = [[currentLineitem.month, currentLineitem.invoiceNumber, currentLineitem.clientName, currentLineitem.milestone, currentLineitem.role, currentLineitem.inflowReceived, currentLineitem.invoicedAmount, currentLineitem.vat, currentLineitem.netInflow, currentLineitem.variablePay, currentLineitem.wht, currentLineitem.netCreditedToAcct]];
    const lineCell = `A${lineOffset + i}:M${lineOffset + i}`;
    sheet.getRange(lineCell).setValues(formattedLineItem);
  }

}
interface LineItemarray {
  month: string,
  invoiceNumber: string,
  clientName: string,
  milestone: string,
  role: string,
  inflowReceived: string,
  invoicedAmount: string,
  vat: string,
  netInflow: string,
  variablePay: string,
  wht: string,
  netCreditedToAcct: string
}

 

Lineitem.pngerror.png

@boyombo12 

 

What does the history output of your lineitemarray select look like? 

Damien

The Output body of the select returned 

 

[
{
"month": "April",
"invoiceNumber": "ED/INV/2/0024",
"clientName": "clear code",
"mileStone": "Second",
"role": "Account Role",
"inflowReceived": ".4,600,000",
"invoicedAmount": "4,000,000.00",
"vat": "300,000.00",
"netInflow": "3,700,000.00",
"variablePay": "97,680.00",
"wht": "4,884.00",
"netCreditedToAcct": "92,796.00"
},
{
"month": "April",
"invoiceNumber": "DJL/INV/2/0024",
"clientName": "Eno",
"mileStone": "Second",
"role": "Account Role",
"inflowReceived": ".5,000,000",
"invoicedAmount": "4,000,000.00",
"vat": "300,000.00",
"netInflow": "3,700,000.00",
"variablePay": "97,680.00",
"wht": "4,884.00",
"netCreditedToAcct": "92,796.00"
}
]

DamoBird365
Employee
Employee

Hi @boyombo12 

 

I've spotted a few wee mistakes which should hopefully get you up and running - nearly there though - good effort 😉

 

First thing is the key-value milestone, defined as milestone in the interface but mileStone in array.  Note the capital S.  If you adjust the script, you've got both the interface and for loop to update.

 

Then the main error "Cannot read property 'month' of undefined".  This is caused by the for loop length.  The array key index starts from 0 and the length of your example is 2.  So it must be less than the length, not less than or equal as there will never be an index equal to length.  i=0 and 1 for length 2.

 

  for (let i = 0; i < lineItems.length; i++)

 

Finally, your columns are A to L (not M).  This causes an error after you resolve the above.

 

If this post helps, then please consider Accept it as the solution to help the other members find it more quickly.
Cheers,
Damien


P.S. take a look at my new blog here and like & subscribe to my YouTube Channel thanks 😉

I salute and appreciate you for your relentless effort to assist me. i almost gave up. When they say "Your head is there in Lagos Nigeria, it shows you are highly respected. Let me use this Medium to say Your head is there. 😁

Hi Damien!

 

Your videos are super helpful and I've watched them all to compose my own flow. It is slightly different than yours as my scenario was not the same. I am receiving a similar error with my flow, it reads as "We were unable to run the script. Please try again.
Runtime error: Line 20: Cannot read property 'length' of undefined". I've defined my array but I keep receiving this error. Would you be able to help me with this ? I would appreciate any insights.

 

Here is my script:

 

function main(
  
  workbook: ExcelScript.Workbook,
  facultyName: string,
  InventoryArray: arrayvar[]

  ){
  // Get the RerportTemplate worksheeet from thr workbook
  let worksheet = workbook.getWorksheet("ReportTemplate");

  worksheet.getRange("C10").setValue(facultyName);


  const startInventory = 17;

  for (let i= 0; i < InventoryArray.length; i++) {
    const currentObject = InventoryArray[i];

    const formattedrow = [[currentObject.title, currentObject.model, currentObject.manufacturer, currentObject.serial, currentObject.warrantystatus, currentObject.warrantyend,]];
    
    const rowRange = `B${startInventory + i}:G${startInventory + i}`;
    worksheet.getRange(rowRange).setValues(formattedrow);
  }

  return "List" + InventoryArray.length + "Records Loaded in Excel"
  
}
  
interface arrayvar {
  title: string,
  model: string,
  manufacturer: string,
  serial: string,
  warrantystatus: string,
  warrantyend: string,
}
 
 
 
And here is my flow:
 
bordo_1-1624596418474.png

 


 

Hello,

 I saw some few mistakes that needs to be corrected. the arravar on the flow has keys Title, Model, Manufacturer, e.t.c that all start with uppercase letters but the interface declared and  const formattedrow variable declared have all in lowercase. Kindly make sure the case is thesame on the flow, interface and const formattedrow . Once you correct that, it should work

Hi @boyombo12 ,

Thanks for the tip! The flow now runs with those corrections, but the Script still reads "InventoryArray undefined". The flow also won't populate the excel sheet for the inventory arrayvar. (It populates the facultyName just fine) .Any ideas on why the flow might not be populating the excel template ? The output of the Compose action that calls the select output seems correct (see the image below- had to censor sensitive info), but the script won't transfer it to the excel cells that I defined in the script. Thank you very much!

bordo_1-1624635351413.png

 

 

 

 

 

 

 

Hi, 

You are almost there. I noticed some errors again. In your formattedrow, I could see currentObject.Serial, currentObject.WarrantyStatus, currentObject.WarrantyEnd but in compose Output I saw it as "Serial Number", "Warranty Status" and Warranty End. You have to replicate whatever in your compose in the interface. Note: Typescript and Javascript wont accept space in variable name. In you compose connector, change  Serial Number to SerialNumber, Warranty Status to WarrantyStatus and Warranty End to WarrantyEnd. Make sure it is declared like that in your interface too. Also effect the change on the formattedrow. It should work after that.

bordo
Frequent Visitor

Hi @boyombo12 ,

 

That did the trick! Thank you so much for your help.

Happy that you are good to go. Kindly accept my comment as the solution to help other community members that could have such challenge in the nearest future.

takolota
Multi Super User
Multi Super User

So if anyone is getting really confused why there's an error on the top line where you're declaring the flow array variable like 
TestArray: testArray[]

And the interface at the bottom has your name like testArray greyed out, make sure you closed off the curly bracket } to the rest of the code before the interface. The interface is a separate segment of the code.
Took me a good 15 minutes to figure out what in the world was wrong. 😅

abhishja
Helper I
Helper I

Hi,

why we are seeing this action currently can't be recorded for Repeated items labels and Buttons (ShowDrillIndicators) in office scrip. Please advise asap

 

Regards,

Abhishek

abhishja_0-1683974705630.png

 

Helpful resources

Announcements

Check out the Copilot Studio Cookbook today!

We are excited to announce our new Copilot Cookbook Gallery in the Copilot Studio Community. We can't wait for you to share your expertise and your experience!    Join us for an amazing opportunity where you'll be one of the first to contribute to the Copilot Cookbook—your ultimate guide to mastering Microsoft Copilot. Whether you're seeking inspiration or grappling with a challenge while crafting apps, you probably already know that Copilot Cookbook is your reliable assistant, offering a wealth of tips and tricks at your fingertips--and we want you to add your expertise. What can you "cook" up?   Click this link to get started: https://aka.ms/CS_Copilot_Cookbook_Gallery   Don't miss out on this exclusive opportunity to be one of the first in the Community to share your app creation journey with Copilot. We'll be announcing a Cookbook Challenge very soon and want to make sure you one of the first "cooks" in the kitchen.   Don't miss your moment--start submitting in the Copilot Cookbook Gallery today!     Thank you,  Engagement Team

Announcing Power Apps Copilot Cookbook Gallery

We are excited to share that the all-new Copilot Cookbook Gallery for Power Apps is now available in the Power Apps Community, full of tips and tricks on how to best use Microsoft Copilot as you develop and create in Power Apps. The new Copilot Cookbook is your go-to resource when you need inspiration--or when you're stuck--and aren't sure how to best partner with Copilot while creating apps.   Whether you're looking for the best prompts or just want to know about responsible AI use, visit Copilot Cookbook for regular updates you can rely on--while also serving up some of your greatest tips and tricks for the Community. Check Out the new Copilot Cookbook for Power Apps today: Copilot Cookbook - Power Platform Community.  We can't wait to see what you "cook" up!    

Welcome to the Power Automate Community

You are now a part of a fast-growing vibrant group of peers and industry experts who are here to network, share knowledge, and even have a little fun.   Now that you are a member, you can enjoy the following resources:   Welcome to the Community   News & Announcements: The is your place to get all the latest news around community events and announcements. This is where we share with the community what is going on and how to participate.  Be sure to subscribe to this board and not miss an announcement.   Get Help with Power Automate Forums: If you're looking for support with any part of Power Automate, our forums are the place to go. From General Power Automate forums to Using Connectors, Building Flows and Using Flows.  You will find thousands of technical professionals, and Super Users with years of experience who are ready and eager to answer your questions. You now have the ability to post, reply and give "kudos" on the Power Automate community forums. Make sure you conduct a quick search before creating a new post because your question may have already been asked and answered. Galleries: The galleries are full of content and can assist you with information on creating a flow in our Webinars and Video Gallery, and the ability to share the flows you have created in the Power Automate Cookbook.  Stay connected with the Community Connections & How-To Videos from the Microsoft Community Team. Check out the awesome content being shared there today.   Power Automate Community Blog: Over the years, more than 700 Power Automate Community Blog articles have been written and published by our thriving community. Our community members have learned some excellent tips and have keen insights on the future of process automation. In the Power Automate Community Blog, you can read the latest Power Automate-related posts from our community blog authors around the world. Let us know if you'd like to become an author and contribute your own writing — everything Power Automate-related is welcome.   Community Support: Check out and learn more about Using the Community for tips & tricks. Let us know in the Community Feedback  board if you have any questions or comments about your community experience. Again, we are so excited to welcome you to the Microsoft Power Automate community family. Whether you are brand new to the world of process automation or you are a seasoned Power Automate veteran - our goal is to shape the community to be your 'go to' for support, networking, education, inspiration and encouragement as we enjoy this adventure together.     Power Automate Community Team

Hear what's next for the Power Up Program

Hear from Principal Program Manager, Dimpi Gandhi, to discover the latest enhancements to the Microsoft #PowerUpProgram, including a new accelerated video-based curriculum crafted with the expertise of Microsoft MVPs, Rory Neary and Charlie Phipps-Bennett. If you’d like to hear what’s coming next, click the link below to sign up today! https://aka.ms/PowerUp  

Tuesday Tip | How to Report Spam in Our Community

It's time for another TUESDAY TIPS, your weekly connection with the most insightful tips and tricks that empower both newcomers and veterans in the Power Platform Community! Every Tuesday, we bring you a curated selection of the finest advice, distilled from the resources and tools in the Community. Whether you’re a seasoned member or just getting started, Tuesday Tips are the perfect compass guiding you across the dynamic landscape of the Power Platform Community.   As our community family expands each week, we revisit our essential tools, tips, and tricks to ensure you’re well-versed in the community’s pulse. Keep an eye on the News & Announcements for your weekly Tuesday Tips—you never know what you may learn!   Today's Tip: How to Report Spam in Our Community We strive to maintain a professional and helpful community, and part of that effort involves keeping our platform free of spam. If you encounter a post that you believe is spam, please follow these steps to report it: Locate the Post: Find the post in question within the community.Kebab Menu: Click on the "Kebab" menu | 3 Dots, on the top right of the post.Report Inappropriate Content: Select "Report Inappropriate Content" from the menu.Submit Report: Fill out any necessary details on the form and submit your report.   Our community team will review the report and take appropriate action to ensure our community remains a valuable resource for everyone.   Thank you for helping us keep the community clean and useful!

Users online (5,328)