cancel
Showing results for 
Search instead for 
Did you mean: 
Reply
BitLord69
Memorable Member
Memorable Member

Patch problem; worked before now it doesn't

Hi all!

 

I've got an app handling our internal orders. Sometimes goods won't be delivered all in one go, so we need to split an order. This function has been working well before, but now it has stopped (unfortunately just after we've gone live with the app). Below is an  overview of the two screens involved and also a run through of the formulas I (try to) use to achieve this.

 

There are two main tables: Orderhuvud (OrderHead) and NyOrderRad (NewOrderRow) that are linked by an Id in Orderhuvud and OrderhuvudId in NyOrderRad.See the screen dump below for an overview of one of the app's main screens.

 

Overview of orders: Orderhuvud on the left and it's children, NyOrderRad, on the rightOverview of orders: Orderhuvud on the left and it's children, NyOrderRad, on the right

Pressing the little icon with a plus-sign in the order details section on the left brings us to the second screen where we can choose which records from an order that need to be moved.

 

Screen to select which order items to move to another orderScreen to select which order items to move to another order

This second screen has a gallery that is populated with this formula, and this works well: 

AddColumns(Filter('[dbo].[NyOrderRad]', OrderhuvudId = rSelectedOrder.Id),"DoSplit", false,"Splitamount", Antal)

 

Here's where the problem arises - when you press the check mark to do the split, I use the big formula that I will go through step by step: 

UpdateContext({rNyttOrderHuvud:Patch('[dbo].[Orderhuvud]', Defaults('[dbo].[Orderhuvud]'), {SkapadDatum:Text(Today(),"[$-sv-SE]yyyy-mm-dd"), HanteradAv:rCurrentUser.FullName,Bestallningsdatum:rSelectedOrder.Bestallningsdatum, Ordernummer:rSelectedOrder.Ordernummer,Kommentar:rSelectedOrder.Kommentar,Leverantor:rSelectedOrder.Leverantor,FraktKonto:nFRAKTKONTO})});ForAll(gOrderrader_scrSO.AllItems, If(cbSplit.Value = true && Value(txtAntal2Split.Text) >= Antal, Patch('[dbo].[NyOrderRad]', LookUp('[dbo].[NyOrderRad]', Id = Id),{OrderhuvudId:rNyttOrderHuvud.Id, Restnoterad:1}));If(cbSplit.Value = true && Value(txtAntal2Split.Text) < Antal, Patch('[dbo].[NyOrderRad]', LookUp('[dbo].[NyOrderRad]', Id = Id), {Antal:Antal - Value(txtAntal2Split.Text), Restnoterad:1});Patch('[dbo].[NyOrderRad]', Defaults('[dbo].[NyOrderRad]'), {Bestallare:Bestallare, BestEpost:BestEpost, BestalldKundDatum:BestalldKundDatum, Anvandare:Anvandare,Avdelning_Plats:Avdelning_Plats,Kategori:Kategori,Benamning:Benamning,Antal:Value(txtAntal2Split.Text),OrderhuvudId:rNyttOrderHuvud.Id,Konto:Konto,LevArtNr:LevArtNr, Pris:Pris,Ansvar:Ansvar,Verksamhet:Verksamhet,Projekt:Projekt,Aktivitet:Aktivitet,Objekt:Objekt,Restnoterad:1,Kommentar:Kommentar})))

 

Step 1: Create a new order head and save this record in a local variable, this works well!

UpdateContext(
	{rNyttOrderHuvud:Patch('[dbo].[Orderhuvud]', Defaults('[dbo].[Orderhuvud]'), 
			{SkapadDatum:Text(Today(),"[$-sv-SE]yyyy-mm-dd"), 
			HanteradAv:rCurrentUser.FullName,
			Bestallningsdatum:rSelectedOrder.Bestallningsdatum, 
			Ordernummer:rSelectedOrder.Ordernummer,
			Kommentar:rSelectedOrder.Kommentar,
			Leverantor:rSelectedOrder.Leverantor,
			FraktKonto:nFRAKTKONTO})});

Step 2: Loop through all the items in the gallery

Step 2.1 Check if an item has been checked

Step 2.2 If checked, see if all items of that particular record should be moved. If yes, update the reference to the newly created Order head from step 1.

 

This is where it stops working. The Lookup just returns the very first record in the table, and not the one checked in the gallery, and thus sets the reference for this wrong record. After that it stops the iteration alltogether, or more likely, it does run twice if I check two items, but the Lookup returns the same record both times so it looks like it runs only once.

If(cbSplit.Value = true && Value(txtAntal2Split.Text) >= Antal,
			Patch('[dbo].[NyOrderRad]', Lookup('[dbo].[NyOrderRad]', Id = Id), 
				{OrderhuvudId:rNyttOrderHuvud.Id, 
				Restnoterad:1}));

I tried replacing the Patch with UpdateIf, but that changed ALL of the records in NyOrderRad, givning me a minor heart failure in the process. Luckily I had a local copy od the table's content that I could restore.

 

How do I trace or catch the error? Since it's in a ForAll I cannot use UpdateContext to catch the result of the Patch. I guess the main problem is in the Lookup, but how woill I get it right?

 

Step 2.3 An item has been checked, but not all items should be moved, see screen dump 3

Two records selected, but not all items should be movedTwo records selected, but not all items should be moved

 Here's the fomula for that part:

If(cbSplit.Value = true && Value(txtAntal2Split.Text) < Antal, 
			Patch('[dbo].[NyOrderRad]', LookUp('[dbo].[NyOrderRad]', Id = Id), 
				{Antal:Antal - Value(txtAntal2Split.Text), 
				Restnoterad:1});
			Patch('[dbo].[NyOrderRad]', Defaults('[dbo].[NyOrderRad]'), 
				{Bestallare:Bestallare, 
				BestEpost:BestEpost, 
				BestalldKundDatum:BestalldKundDatum, Anvandare:Anvandare,
				Avdelning_Plats:Avdelning_Plats,
				Kategori:Kategori,
				Benamning:Benamning,
				Antal:Value(txtAntal2Split.Text),
				OrderhuvudId:rNyttOrderHuvud.Id,
				Konto:Konto,
				LevArtNr:LevArtNr, 
				Pris:Pris,
				Ansvar:Ansvar,
				Verksamhet:Verksamhet,
				Projekt:Projekt,
				Aktivitet:Aktivitet,
				Objekt:Objekt,
				Restnoterad:1,
				Kommentar:Kommentar})))

 

The first call to Patch, in italics above, does not behave as in Step 2.2; seemingly nothing happens, the amount is not updated. Isn't this odd? Almost exactly the same code behaves in two different ways, the difference being the setting of the column values.

The second Patch of this code works well, I do get two new records in the NyOrderrad table with the correct amounts.

 

As I write in the begining, this has worked before, but I'm not sure when it stopped.  I think pretty recently, but that's just a hunch.

 

I hope someone can shed some light on this before I pull my hair out! 

 

 

1 ACCEPTED SOLUTION

Accepted Solutions
BitLord69
Memorable Member
Memorable Member

After a few failed attempts I finally found a workaround!

 

As I suspected, it's the Lookup inside the Patch that goes awry: PA can't differentiate between the Id in the table and the Id in the gallery so it ends up using the Id from the table on both sides! I tried using the @-operator on the right side of the equal sign, but never got it to work.

 

My solution is to use AddColumn and make an alias for the Id-column so the Lookup can refer to the alias. Here are the two revised formulas (the new additions are in boldface):

Gallery:Items

AddColumns(Filter('[dbo].[NyOrderRad]', OrderhuvudId = rSelectedOrder.Id),"DoSplit", false,"Splitamount", Antal, "RadId", Id)

 

Part of the big formula inside the ForAll.

Patch('[dbo].[NyOrderRad]', LookUp('[dbo].[NyOrderRad]', Id = RadId),{OrderhuvudId:rNyttOrderHuvud.Id, Restnoterad:1}))

The questions is still if there is a better way to access the underlying record from the gallery; having to search for the record when it's right there seems a bit of a stupid thing to do. If there is, there would be no need to do the Lookup, and probably saving quite some time, especially if there are many items in the gallery. Luckily the operations in this part of the app don't involve many records, usually only a handful or two at most.

 

Hope someone clever can answer that questions! Hopefully it's something really simple that I have overlooked.

 

 

View solution in original post

3 REPLIES 3
Leo09
Helper V
Helper V

Hmmm, another problem that might caused by the new update. I wonder why PowerApps patches always break things.

BitLord69
Memorable Member
Memorable Member

After a few failed attempts I finally found a workaround!

 

As I suspected, it's the Lookup inside the Patch that goes awry: PA can't differentiate between the Id in the table and the Id in the gallery so it ends up using the Id from the table on both sides! I tried using the @-operator on the right side of the equal sign, but never got it to work.

 

My solution is to use AddColumn and make an alias for the Id-column so the Lookup can refer to the alias. Here are the two revised formulas (the new additions are in boldface):

Gallery:Items

AddColumns(Filter('[dbo].[NyOrderRad]', OrderhuvudId = rSelectedOrder.Id),"DoSplit", false,"Splitamount", Antal, "RadId", Id)

 

Part of the big formula inside the ForAll.

Patch('[dbo].[NyOrderRad]', LookUp('[dbo].[NyOrderRad]', Id = RadId),{OrderhuvudId:rNyttOrderHuvud.Id, Restnoterad:1}))

The questions is still if there is a better way to access the underlying record from the gallery; having to search for the record when it's right there seems a bit of a stupid thing to do. If there is, there would be no need to do the Lookup, and probably saving quite some time, especially if there are many items in the gallery. Luckily the operations in this part of the app don't involve many records, usually only a handful or two at most.

 

Hope someone clever can answer that questions! Hopefully it's something really simple that I have overlooked.

 

 

Hi ! I've had a similar issue with patching multiple records and not being able to use the internal ID column. I've seen people use the "With()" function to basically rename the ID column inside the expression so theres no issue with the distinction of the 2 ID. I cant give you the whole syntax right now as I am trying to fix this issue myself without going the "AddColumn()" route !

Helpful resources

Announcements

Exclusive LIVE Community Event: Power Apps Copilot Coffee Chat with Copilot Studio Product Team

  It's time for the SECOND Power Apps Copilot Coffee Chat featuring the Copilot Studio product team, which will be held LIVE on April 3, 2024 at 9:30 AM Pacific Daylight Time (PDT).     This is an incredible opportunity to connect with members of the Copilot Studio product team and ask them anything about Copilot Studio. We'll share our special guests with you shortly--but we want to encourage to mark your calendars now because you will not want to miss the conversation.   This live event will give you the unique opportunity to learn more about Copilot Studio plans, where we’ll focus, and get insight into upcoming features. We’re looking forward to hearing from the community, so bring your questions!   TO GET ACCESS TO THIS EXCLUSIVE AMA: Kudo this post to reserve your spot! Reserve your spot now by kudoing this post.  Reservations will be prioritized on when your kudo for the post comes through, so don't wait! Click that "kudo button" today.   Invitations will be sent on April 2nd.Users posting Kudos after April 2nd. at 9AM PDT may not receive an invitation but will be able to view the session online after conclusion of the event. Give your "kudo" today and mark your calendars for April 3rd, 2024 at 9:30 AM PDT and join us for an engaging and informative session!

Tuesday Tip: Unlocking Community Achievements and Earning Badges

TUESDAY TIPS are our way of communicating helpful things we've learned or shared that have helped members of the Community. Whether you're just getting started or you're a seasoned pro, Tuesday Tips will help you know where to go, what to look for, and navigate your way through the ever-growing--and ever-changing--world of the Power Platform Community! We cover basics about the Community, provide a few "insider tips" to make your experience even better, and share best practices gleaned from our most active community members and Super Users.   With so many new Community members joining us each week, we'll also review a few of our "best practices" so you know just "how" the Community works, so make sure to watch the News & Announcements each week for the latest and greatest Tuesday Tips!     THIS WEEK'S TIP: Unlocking Achievements and Earning BadgesAcross the Communities, you'll see badges on users profile that recognize and reward their engagement and contributions. These badges each signify a different achievement--and all of those achievements are available to any Community member! If you're a seasoned pro or just getting started, you too can earn badges for the great work you do. Check out some details on Community badges below--and find out more in the detailed link at the end of the article!       A Diverse Range of Badges to Collect The badges you can earn in the Community cover a wide array of activities, including: Kudos Received: Acknowledges the number of times a user’s post has been appreciated with a “Kudo.”Kudos Given: Highlights the user’s generosity in recognizing others’ contributions.Topics Created: Tracks the number of discussions initiated by a user.Solutions Provided: Celebrates the instances where a user’s response is marked as the correct solution.Reply: Counts the number of times a user has engaged with community discussions.Blog Contributor: Honors those who contribute valuable content and are invited to write for the community blog.       A Community Evolving Together Badges are not only a great way to recognize outstanding contributions of our amazing Community members--they are also a way to continue fostering a collaborative and supportive environment. As you continue to share your knowledge and assist each other these badges serve as a visual representation of your valuable contributions.   Find out more about badges in these Community Support pages in each Community: All About Community Badges - Power Apps CommunityAll About Community Badges - Power Automate CommunityAll About Community Badges - Copilot Studio CommunityAll About Community Badges - Power Pages Community

Tuesday Tips: Powering Up Your Community Profile

TUESDAY TIPS are our way of communicating helpful things we've learned or shared that have helped members of the Community. Whether you're just getting started or you're a seasoned pro, Tuesday Tips will help you know where to go, what to look for, and navigate your way through the ever-growing--and ever-changing--world of the Power Platform Community! We cover basics about the Community, provide a few "insider tips" to make your experience even better, and share best practices gleaned from our most active community members and Super Users.   With so many new Community members joining us each week, we'll also review a few of our "best practices" so you know just "how" the Community works, so make sure to watch the News & Announcements each week for the latest and greatest Tuesday Tips!   This Week's Tip: Power Up Your Profile!  🚀 It's where every Community member gets their start, and it's essential that you keep it updated! Your Community User Profile is how you're able to get messages, post solutions, ask questions--and as you rank up, it's where your badges will appear and how you'll be known when you start blogging in the Community Blog. Your Community User Profile is how the Community knows you--so it's essential that it works the way you need it to! From changing your username to updating contact information, this Knowledge Base Article is your best resource for powering up your profile.     Password Puzzles? No Problem! Find out how to sync your Azure AD password with your community account, ensuring a seamless sign-in. No separate passwords to remember! Job Jumps & Email Swaps Changed jobs? Got a new email? Fear not! You'll find out how to link your shiny new email to your existing community account, keeping your contributions and connections intact. Username Uncertainties Unraveled Picking the perfect username is crucial--and sometimes the original choice you signed up with doesn't fit as well as you may have thought. There's a quick way to request an update here--but remember, your username is your community identity, so choose wisely. "Need Admin Approval" Warning Window? If you see this error message while using the community, don't worry. A simple process will help you get where you need to go. If you still need assistance, find out how to contact your Community Support team. Whatever you're looking for, when it comes to your profile, the Community Account Support Knowledge Base article is your treasure trove of tips as you navigate the nuances of your Community Profile. It’s the ultimate resource for keeping your digital identity in tip-top shape while engaging with the Power Platform Community. So, dive in and power up your profile today!  💪🚀   Community Account Support | Power Apps Community Account Support | Power AutomateCommunity Account Support | Copilot Studio  Community Account Support | Power Pages

Super User of the Month | Chris Piasecki

In our 2nd installment of this new ongoing feature in the Community, we're thrilled to announce that Chris Piasecki is our Super User of the Month for March 2024. If you've been in the Community for a while, we're sure you've seen a comment or marked one of Chris' helpful tips as a solution--he's been a Super User for SEVEN consecutive seasons!       Since authoring his first reply in April 2020 to his most recent achievement organizing the Canadian Power Platform Summit this month, Chris has helped countless Community members with his insights and expertise. In addition to being a Super User, Chris is also a User Group leader, Microsoft MVP, and a featured speaker at the Microsoft Power Platform Conference. His contributions to the new SUIT program, along with his joyous personality and willingness to jump in and help so many members has made Chris a fixture in the Power Platform Community.   When Chris isn't authoring solutions or organizing events, he's actively leading Piasecki Consulting, specializing in solution architecture, integration, DevOps, and more--helping clients discover how to strategize and implement Microsoft's technology platforms. We are grateful for Chris' insightful help in the Community and look forward to even more amazing milestones as he continues to assist so many with his great tips, solutions--always with a smile and a great sense of humor.You can find Chris in the Community and on LinkedIn. Thanks for being such a SUPER user, Chris! 💪🌠

Tuesday Tips: Community Ranks and YOU

TUESDAY TIPS are our way of communicating helpful things we've learned or shared that have helped members of the Community. Whether you're just getting started or you're a seasoned pro, Tuesday Tips will help you know where to go, what to look for, and navigate your way through the ever-growing--and ever-changing--world of the Power Platform Community! We cover basics about the Community, provide a few "insider tips" to make your experience even better, and share best practices gleaned from our most active community members and Super Users.   With so many new Community members joining us each week, we'll also review a few of our "best practices" so you know just "how" the Community works, so make sure to watch the News & Announcements each week for the latest and greatest Tuesday Tips!This Week: Community Ranks--Moving from "Member" to "Community Champion"   Have you ever wondered how your fellow community members ascend the ranks within our community? What sets apart an Advocate from a Helper, or a Solution Sage from a Community Champion? In today’s #TuesdayTip, we’re unveiling the secrets and sharing tips to help YOU elevate your ranking—and why it matters to our vibrant communities. Community ranks serve as a window into a member’s role and activity. They celebrate your accomplishments and reveal whether someone has been actively contributing and assisting others. For instance, a Super User is someone who has been exceptionally helpful and engaged. Some ranks even come with special permissions, especially those related to community management. As you actively participate—whether by creating new topics, providing solutions, or earning kudos—your rank can climb. Each time you achieve a new rank, you’ll receive an email notification. Look out for the icon and rank name displayed next to your username—it’s a badge of honor! Fun fact: Your Community Engagement Team keeps an eye on these ranks, recognizing the most passionate and active community members. So shine brightly with valuable content, and you might just earn well-deserved recognition! Where can you see someone’s rank? When viewing a post, you’ll find a member’s rank to the left of their name.Click on a username to explore their profile, where their rank is prominently displayed. What about the ranks themselves? New members start as New Members, progressing to Regular Visitors, and then Frequent Visitors.Beyond that, we have a categorized system: Kudo Ranks: Earned through kudos (teal icons).Post Ranks: Based on your posts (purple icons).Solution Ranks: Reflecting your solutions (green icons).Combo Ranks: These orange icons combine kudos, solutions, and posts. The top ranks have unique names, making your journey even more exciting! So dive in, collect those kudos, share solutions, and let’s see how high you can rank! 🌟 🚀   Check out the Using the Community boards in each of the communities for more helpful information!  Power Apps, Power Automate, Copilot Studio & Power Pages

Find Out What Makes Super Users So Super

We know many of you visit the Power Platform Communities to ask questions and receive answers. But do you know that many of our best answers and solutions come from Community members who are super active, helping anyone who needs a little help getting unstuck with Business Applications products? We call these dedicated Community members Super Users because they are the real heroes in the Community, willing to jump in whenever they can to help! Maybe you've encountered them yourself and they've solved some of your biggest questions. Have you ever wondered, "Why?"We interviewed several of our Super Users to understand what drives them to help in the Community--and discover the difference it has made in their lives as well! Take a look in our gallery today: What Motivates a Super User? - Power Platform Community (microsoft.com)

Top Solution Authors
Top Kudoed Authors
Users online (5,935)