cancel
Showing results for 
Search instead for 
Did you mean: 
Reply
Datanerd
Helper II
Helper II

Collection collected from Sharepoint duplicating exisitng items when new items added

I have a canvas expense system connected to two SharePoint lists: Expenses and expense line items. 

Expenses Table

SharePointIDNameAmount
1Expense11000
2Expense22000
3Expense33000

 

Expenses Items Table

SharePointIDCategoryAmountDateExpenseID
1Food500 1
2Drinks500 1
3Airfare3000 2

 

The ExpenseID is created when submitting the form to relate the items. My flow;

 

  1. I have a submission gallery, that stores the expense items, and OnSelect collects from SharePoint expense items related,(ColRelatedItems). And navigates to the view items screen.
  2. The view item has the form(Expensesheader) and a gallery(Expenserelateditems) with the collection(ColRelatedItems) as the items.
  3. There is a button that adds an empty row to the gallery in case the user wants to add new items, this new item doesn't have an ExpenseID yet.
  4. There is a button that finally patches the items (New and updated) to the collection which will later be pushed to collection on submission.

I have a formula that unfortunately duplicates the items that previously existed in the collection when patching back to sharepoint.
here is my formula;

 

 

ForAll(ColRelatedItems,

<Checks the new empty row created is not uploaded and the expenseID is empty>
If(!IsBlank(Title) && IsBlank(LookUp(ExpenseRelatedItems, ExpensesID = GalleryExpensesDetail.Selected.ID)),

Patch(ExpenseRelatedItems,Defaults(ExpenseRelatedItems),{Title:Title,Amount:Amount,ExpensesID:GalleryExpensesDetails.Selected.ID}),

<Checks the new empty row created is not uploaded and the expenseID exists>
If( !IsBlank(Title) && !IsBlank(LookUp(ExpensesItems, ExpensesID = GalleryExpensesDetail.Selected.ID)), Patch(Title:Title,Amount:Amount,ExpensesID:GalleryExpensesDetails.Selected.ID})
)));

 

 

Not sure what I could be doing wrong with the formula

 

 

1 ACCEPTED SOLUTION

Accepted Solutions
RandyHayes
Super User
Super User

@Datanerd 

Keep in mind that doing a Patch on a collection using "ThisItem" can lead to issues.  It is not what you expect.  There is not direct link of a gallery row to a collection row by itself.  Patch has to try and look up what is in the "ThisItem" record to then patch that record in the collection.

 

Let me explain.

 

So, let's say you have two records in your collection and they are shown in a gallery:

The two records:  {Title: "", Value: 0}, {Title: "", Value: 0}

Now, let's say you have a means to edit the Title in your gallery and you edit the second row in the gallery and then issue a : Patch(myCollection, ThisItem, {Title: TextInput.Text})

This will cause a problem because it will patch the first record of the collection...not the second.  This is because ThisItem is a record and that record is {Title: "", Value: 0} which is the same as the first record!

You cannot rely on "ThisItem" to be the underlying record!!

 

So, the solution I provided you accounts for all of that.  

 

This was very specifically accounted for in the OnChange action formula I provided:

If(!IsBlank(ThisItem.ID),
    UpdateIf(yourCollection, ID=ThisItem.ID, {Changed: true})
)

Everything is based on the ID.  This is the key to everything (thus the primary key)

 

If you fill your collection with existing records with a formula such as:  

ClearCollect(myCollection, Filter(myData, columnX=value))

Then every record will have an ID.  That is essentially all we care about - except for the initial display of values - like if there was a Title textinput, we would set the Default of that to: ThisItem.Title  But after that, we don't care about .Title any longer.  The TextInput now contains the value that we are interested in.

 

With the OnChange formula above on the TextInput control, it will very specifically look at the ID column.  If it exists, it will update THAT record with a Changed column set to true.  That is it.  We don't care about trying to capture all the values in the gallery because we will get them later.  Doing so is just adding more work.

 

Finally, in the Patch function:

Patch(ExpenseRelatedItems,    
    ForAll(
        Filter(yourCollection, Changed || IsBlank(ID)) As _item,
        With(LookUp(GalleryExpensesDetails.AllItem, ID=_item.ID),
            {ID: ID,
             Title: TitleTextInputControl.Text,
             Amount: Value(AmountTextInputControl.Text),
             TravelExpensesID: GalleryExpensesDetails.Selected.ID
            }
        )
   )
)

We are very specifically filtering for any record that has a Changed column that is true.  OR any record that has no ID.

We then put all of that together in a table (The ForAll) with records that correspond to the datasource record needed.  We supply the ID of the record from the gallery...if there is one, then the Patch will update that record in the datasource, if not (blank), then it will create one.

 

This can all be done in an OnSuccess action of a form and can reference any LastSubmit record data that was submitted in the form submit.

 

Hopefully that all makes sense.

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

View solution in original post

17 REPLIES 17
RandyHayes
Super User
Super User

@Datanerd 

Your formula has some errors in it...but what is patchstuff??

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Hi, It's formula inside the patch for the columns to be updates. {Total : Total,...}

RandyHayes
Super User
Super User

@Datanerd 

How is it defined?  Your formula is not defining it.

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!
EdViegas
Responsive Resident
Responsive Resident

I advise you to create a lookup column in Expenses Items to Expenses (selecting ID for "In this column" field)!

Uhmm not sure what that means, but I've updated my formula to show the patch example

Hi, I do have it, The expensesID.

 

It seems to be working only that it's duplicating the existing items.

RandyHayes
Super User
Super User

@Datanerd 

Ah, see I thought you were copying and pasting your exact formula...now I see you were just shorthanding it in your post.

 

So my suggestion is to ditch the collection and work from your gallery where you already have the data.  And also to use the ForAll as the function it was designed to be (it is not a For Loop!)

 

Your formula would be more like this:

Patch(ExpenseRelatedItems,    
    ForAll(
        Filter(GalleryExpensesDetails.AllItem, !IsBlank(TitleInputControl.Text)),
        {ID: ID,
         Title:Title,
         Amount:Amount,
         TravelExpensesID: GalleryExpensesDetails.Selected.ID
        }
    )
)

The point of the above being that your gallery is already populated by the records from the datasource and it will have the correct ID needed.

Patch is smart enough to know when to create and when to update.  If you supply an ID, then it will update.  If the ID is blank, then it will create.

The above creates a table of records to create and/or update (that's the purpose of the ForAll) and then provides that table to Patch to act on the records.

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Thanks for this insight.

Just to clarify, I have two Galleries. 
 1. Has the expenseHeaderDetails(GalleryExpenseDetails) -  when an item on this is selected, I create a collection that pulls all the related expense line items with the expenseID.
2. The second gallery(GallerGrid), gets populated by the just pulled-in data ( The expense line items), this allows for the addition of new items that come without the expenseid and any updates on the existing ones.
so I push this data back to SP using the formula, hence I reference the first gallery's ID as the expenseID in the patch.

 

RandyHayes
Super User
Super User

@Datanerd 

So don't get caught up in the collection trap!  You will need a collection only for the purpose of being able to add records to a gallery.  Primarily, the only thing the collection needs to contain is the primary keys for the records (or blank if new).

Your formula to update and change records should base itself on the gallery - not the collection.  Otherwise you get into the wasted time of doing OnChange actions and such to update the collection...You need not waste the effort.  The gallery will have the values you want.

 

The only one suggestion is to use the OnChange actions to "tag" your record in your collection as changed.  This way you can filter just the changed and new records for your patch function.

If(!IsBlank(ThisItem.ID),
    UpdateIf(yourCollection, ID=ThisItem.ID, {Changed: true})
)

 

The formula mentioned would do what you need from that.  Based on what you have mentioned though, the following changes would/should be made:

Patch(ExpenseRelatedItems,    
    ForAll(
        Filter(yourCollection, IsChanged || IsBlank(ID)) As _item,
        With(LookUp(GalleryExpensesDetails.AllItem, ID=_item.ID),
            {ID: ID,
             Title: TitleTextInputControl.Text,
             Amount: Value(AmountTextInputControl.Text),
             TravelExpensesID: GalleryExpensesDetails.Selected.ID
            }
        )
   )
)

 

That would perform the action you need.

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Helpful resources

Announcements

Tuesday Tips: Getting Started in the Community

TUESDAY TIPS is back!   This weekly series of posts is our way of sharing helpful things we've learned or shared that have helped members of the Community. Whether you're just getting started or you're a seasoned pro, Tuesday Tips will help you know where to go, what to look for, and navigate your way through the ever-growing--and ever-changing--world of the Power Platform Community! The original run of Tuesday Tips was a highlight of last year, and these all-new Tips will hopefully prove to be just as informative as helpful. We will cover some basics about the Community, a few "insider tips" to make your experience even better, and sharing best practices gleaned from our most active community members and Super Users. Make sure to watch the News & Announcements each week for the latest and greatest Tuesday Tips!   THIS WEEK: I'm Brand New! What Do I Do? The number of new community members we have each week is pretty amazing, and we are so glad to welcome all of you to the Community! You may be wondering. "What do I do? Where do I get started? Will anyone be willing to help me? What I have a question? Help!"   Let's start with this: Welcome to the low-code revolution, and more importantly, welcome to the Power Platform Community! This is a great place to start. Whether you're busy with Power Apps, getting familiar with Power Automate, engaging Copilot Studio, or building in Power Pages, there are a few key places you should check out as you begin your journey: FORUMS: The forums are THE place to ask questions, look at questions asked by other Community members—and see answers and solutions from our Super Users and other helpful people in the Community. Power Apps ForumsPower Automate ForumsCopilot Studio ForumsPower Pages Forums   NEWS & ANNOUNCEMENTS: Our News & Announcements section highlights the newest and greatest updates in the Community, news from the product team, and so much more. It’s updated a few times each week and will also help you find ways to connect with what’s going on in the ever-growing world of Power Platform. Power Apps News & AnnouncementsPower Automate News & AnnouncementsCopilot Studio News & AnnouncementsPower Pages News & Announcements   GALLERIES: The Galleries section of the Community features tons of tips and tricks, features and benefits, and more—through videos created by our Super Users, product teams, and other helpful members of the Community. Power Apps GalleriesPower Automate Galleries Copilot Studio GalleriesPower Pages Galleries BLOGS: The community blogs section is full of handy step-by-step tips from members of the Community—and some of them include detailed answers to some of the questions most frequently asked questions, as well as how they solved a problem they faced. Power Apps Community BlogPower Automate Community BlogCopilot Studio Community BlogPower Pages Community Blog POWER UP PROGRAM: If you’d like to really take a huge step forward in your journey, we recommend checking out the Power Up Program, a Microsoft-sponsored initiative that trains new Power Platform users and has been a huge success since it launched a little over a year ago. There’s a waiting list, so definitely apply soon if you’re interested! Find out more here: Microsoft Power Up Program for career switchers.   There's so much more you'll discover in your Power Platform experience, and this Community is here for YOU! We are glad you've discovered us and can't wait to see where you grow! If you're new to the Community and just getting started, make sure to give this post a kudo and introduce yourself so we can welcome you!

Super User of the Month | Drew Poggemann

As part of a new monthly feature in the Community, we are excited to share that Drew Poggemann is our featured Super User for the month of February 2024. If you've been in the Community for a while, we're sure Drew's name is familiar to you, as he is one of our most active contributors--he's been a Super User for five consecutive seasons!   Since authoring his first reply 5 years ago to his 514th solution authored, Drew has helped countless Community members with his insights and expertise. In addition to being a Super User, Drew is also a User Group leader and a Microsoft MVP. His contributions to our Super User sessions and to the new SUIT program are always welcome--as well as his sense of humor and fun-loving way of sharing what he knows with others.   When Drew is not solving problems and authoring solutions, he's busy overseeing the Solution Architecture team at HBS, specializing in application architecture and business solution strategy--something he's been doing for over 30 years. We are grateful for Drew and the amazing way he has used his talent and skills to help so many others in the Community. If you are part of the SUIT program, you got to hear some great tips from Drew at the first SUIT session--and we know he still has much more to share!You can find him in the Community and on LinkedIn. Thank you for all you do, Drew!

Announcing Power Apps Copilot Cookbook Gallery

We are excited to share that the all-new Copilot Cookbook Gallery for Power Apps is now available in the Power Apps Community, full of tips and tricks on how to best use Microsoft Copilot as you develop and create in Power Apps. The new Copilot Cookbook is your go-to resource when you need inspiration--or when you're stuck--and aren't sure how to best partner with Copilot while creating apps.   Whether you're looking for the best prompts or just want to know about responsible AI use, visit Copilot Cookbook for regular updates you can rely on--while also serving up some of your greatest tips and tricks for the Community. Our team will be reviewing posts using the new "Copilot Studio" label to ensure we highlight and amplify the most relevant and recent content, so you're assured of high-quality content every time you visit. If you share a post that gets featured in the curated gallery, you'll get a PM in the Community to let you know!The curated gallery is ready for you to experience now, so visit the new Copilot Cookbook for Power Apps today: Copilot Cookbook - Power Platform Community. We can't wait to see what you "cook" up!      

Celebrating a New Season of Super Users with Charles Lamanna, CVP Microsoft Business Applications

February 8 was the kickoff to the 2024 Season One Super User program for Power Platform Communities, and we are thrilled to welcome back so many returning Super Users--as well as so many brand new Super Users who started their journey last fall. Our Community Super Users are the true heroes, answering questions, providing solutions, filtering spam, and so much more. The impact they make on the Communities each day is significant, and we wanted to do something special to welcome them at our first kickoff meeting of the year.   Charles Lamanna, Microsoft CVP of Business Applications, has stressed frequently how valuable our Community is to the growth and potential of Power Platform, and we are honored to share this message from him to our 2024 Season One Super Users--as well as anyone who might be interested in joining this elite group of Community members.     If you want to know more about Super Users, check out these posts for more information today:    Power Apps: What is A Super User? - Power Platform CommunityPower Automate: What is A Super User? - Power Platform Community Copilot Studio: What is A Super User? - Power Platform Community Power Pages: What is A Super User? - Power Platform Community

February 2024 User Group Update: Welcoming New Groups and Highlighting Upcoming Events

It's a new month and a brand-new year, which means another opportunity to celebrate our amazing User Groups!Each month, we highlight the new User Groups that have joined the community. It's been a busy season for new groups, because we are thrilled to welcome 15 New User Groups! Take a look at the list below, shared by the different community categories. If your group is listed here, give this post a kudo so we can celebrate with you!   We love our User Groups and the difference they make in the lives of our Community! Thank you to all the new User Groups, new User Group leaders--we look forward to hearing about your successes and the impact you will leave!   In addition to our monthly New User Group spotlight, it's a great time to share some of the latest events happening in our User Group community! Take a look at the list below to find one that fits your schedule and need! There's a great combination of in-person and virtual events to choose from. It's a great time of year to connect and engage with User Groups both locally and online. Please Welcome Our NEW User Groups   Power Platform: Heathcare Power Platform User Group Power Platform Connect Hub Power Platform Usergroup Denmark Mexico Norte- Power Platform User Group Pune Power User Group Sudbury Power Platform User GroupMicrosoft User Group GhanaMPPBLR - Microsoft Power Platform Bengaluru User Group Power Apps:   Myrtle Beach Power Platform User GroupAnanseTechWB PowerApps Copilot Studio: Pathfinders Power Platform Community Dynamics365: Cairo, Egypt MSD 365 Business Central/NAV/F&O User GruopMS Dynamics 365 Business Central LatamCincinnati OH D365 F&O User Group February User Group Events February 2024 Cleveland Power Platform User GroupPortallunsj - Februar 2024Indiana D365/AX February User Group MeetingQ1 2024 KC Power Platform and Dynamics 365 CRM Users Group 

Super Users 2024 Season One is Here!

   We are excited to announce the first season of our 2024 Super Users is here! Our kickoff to the new year welcomes many returning Super Users and several new faces, and it's always exciting to see the impact these incredible individuals will have on the Community in 2024! We are so grateful for the daily difference they make in the Community already and know they will keep staying engaged and excited for all that will happen this year.   How to Spot a Super User in the Community:Have you ever written a post or asked for help in the Community and had it answered by a user with the Super User icon next to their name? It means you have found the actual, real-life superheroes of the Power Platform Community! Super Users are our heroes because of the way they consistently make a difference in the Community. Our amazing Super Users help keep the Community a safe place by flagging spam and letting the Community Managers know about issues. They also make the Community a great place to find answers, because they are often the first to offer solutions and get clarity on questions. Finally, Super Users share valuable insights on ways to keep the Community growing, engaging, and looking ahead!We are honored to reveal the new badges for this season of Super Users! Congratulations to all the new and returning Super Users!     To better answer the question "What is a Super User?" please check out this article: Power Apps: What is A Super User? - Power Platform CommunityPower Automate: What is A Super User? - Power Platform Community Copilot Studio: What is A Super User? - Power Platform Community Power Pages: What is A Super User? - Power Platform Community

Top Solution Authors
Top Kudoed Authors
Users online (5,072)