cancel
Showing results for 
Search instead for 
Did you mean: 
Reply
Oscar-W
Frequent Visitor

Combo Box to Return Multiple SharePoint Rows with Patch, collect, forall

Hello,

 

Please forgive me, as I noticed there are very similar posts but ultimately I can't solve this problem and I'm going on 7 hours on trying to fix it from YouTube to the web and from this forum.

 

I have a SharePoint list with certain columns that need filling out. On my app on the phone I've used a form which is fine for individual entries to SP. Now we want a system for a user to add multiple entries for employees.

 

I've decided to go with collect, patch and forall:

 

My combobox is okay has the following code:

 

Office365Users.SearchUser({searchTerm:FindEmployee.SearchText}).DisplayName

 

My Submit button has the following code:

 

ClearCollect(EmployeeList,
{
Employees: FindEmployee.SelectedItems
}
);

ForAll(

EmployeeList,

Patch
('CodeCentre - Requests',
Defaults('CodeCentre - Requests'),
{Surname: "MCR"}, -Other suggetions on how to split the employee name Surname/First would be good as well. As MCR just stands for mass code request and is title column. App form uses First/Surname split out.
{WBS: Concatenate(Text('73PO-00_1'),Text(Project_1),Text(Section_1),Text(Area_1),Text(Role_1))},
{From: StartDPick.SelectedDate},
{Expire: EndDPick.SelectedDate},
{'Group/Employee': FindEmployee.Selected.DisplayName}))

 

This returns this multiple rows in my SP List but all with one employees name. The SP List column is text.

 

Any help on why this is returning this way?

 

Thanks!

1 ACCEPTED SOLUTION

Accepted Solutions
RandyHayes
Super User
Super User

@Oscar-W 

To start, your formula has the ForAll backward. You are trying to use it like a ForLoop in some development language - which PowerApps is not.  It is a function that returns a table of records based on your iteration table and record schema.

It is more efficient to use the function as intended and will provide better performance, especially with the Patch function that works best when providing a datasource and a table as the parameters.

 

Your Formula should be the following:

Patch('CodeCentre - Requests',
    ForAll(FindEmployee.SelectedItems,
        {Surname: "MCR", 
         WBS: Text('73PO-00_1') & Text(Project_1) & Text(Section_1) & Text(Area_1) &Text(Role_1),
         From: StartDPick.SelectedDate,
         Expire: EndDPick.SelectedDate,
         'Group/Employee': DisplayName
        }
    )
)

 

You have things like Project_1, Section_1, etc. in your formula that do not have any context to the scenario you have.  You might be using these incorrectly in your formula, but I cannot determine that as there is not additional information on what those are.

 

As for splitting the name - this is an age-old question...how do you split a name properly?  The assumption is first <space> last name...but, you can easily have people that have two-word first or last names, so how do you determine which?  I speak completely in regard to your Surname column in your formula.  You can get sur- and given-names from the Office 365 list.

 

I hope this is helpful for you.

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

View solution in original post

12 REPLIES 12
HenriDesmet59
Resolver IV
Resolver IV

Hello @Oscar-W ,

 

The Column 'Group/Employee' is the employees name column ? 

 

RandyHayes
Super User
Super User

@Oscar-W 

To start, your formula has the ForAll backward. You are trying to use it like a ForLoop in some development language - which PowerApps is not.  It is a function that returns a table of records based on your iteration table and record schema.

It is more efficient to use the function as intended and will provide better performance, especially with the Patch function that works best when providing a datasource and a table as the parameters.

 

Your Formula should be the following:

Patch('CodeCentre - Requests',
    ForAll(FindEmployee.SelectedItems,
        {Surname: "MCR", 
         WBS: Text('73PO-00_1') & Text(Project_1) & Text(Section_1) & Text(Area_1) &Text(Role_1),
         From: StartDPick.SelectedDate,
         Expire: EndDPick.SelectedDate,
         'Group/Employee': DisplayName
        }
    )
)

 

You have things like Project_1, Section_1, etc. in your formula that do not have any context to the scenario you have.  You might be using these incorrectly in your formula, but I cannot determine that as there is not additional information on what those are.

 

As for splitting the name - this is an age-old question...how do you split a name properly?  The assumption is first <space> last name...but, you can easily have people that have two-word first or last names, so how do you determine which?  I speak completely in regard to your Surname column in your formula.  You can get sur- and given-names from the Office 365 list.

 

I hope this is helpful for you.

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Hey Randy,

 

Thank you. Seriously. Thanks. The annoying thing is that I used something very similar to this not sure how I got it so convoluted.

 

For illustration on the WBS lines they're labels that are determine by a drop down to help staff request booking codes concat'd to give a complete WBS:

 

OscarW_0-1646841125809.png

 

So when filled out:

 

OscarW_1-1646841249122.png

 

Just wondering, apart from your YT videos wheres the best place to learn this coding part of PAs?

 

Hey Henri,

 

Randy helped me out. Thanks for your reply though.

@Oscar-W 

Well, the first stage of learning is to absolutely realize that you are NOT coding!  You are writing formulas just like you would write formulas in Excel (as PowerApps is modeled after Excel).  So, the more "code"-like you go, the harder it gets.  

Understand the basics of PowerApps in this way:

1) Understand JSON basics of what a record and table is.  Realize how that is so relevant to PowerApps data.

2) Understand Data Shaping functions in PowerApps (AddColumn, GroupBy, ForAll, etc.) and how they are so powerful to transform your data as needed for your app.

3) Stay away from collections and variables unless absolutely needed.

4) Avoid doing things in control actions (OnChange, OnSelect, etc.) - use only as basically needed - too much and you are trying to "develop" PowerApps...which it is not made for.

 

Those are some of the basic starting steps that I always recommend.  There is much more beyond that, but that is the foundation.

 

As for your response - I am not sure what you are showing in the two photos and what issue you are running in to on those.

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!
Oscar-W
Frequent Visitor

Thanks. I'll have a look at all these points listed.

 

The picture were just to show you how I was using the Project_1, Section_1 labels which I'm sure is quite unorthodox for PowerApps.

 

Whats interesting is when I try to use the code for surname/givenname I can't seem to find them like how DisplayName shows us:

 

OscarW_0-1646843644109.png

 

I haven't seen the surname one so that was a guess but I thought that GivenName was definitely a field I could retrieve. 

 

Is this because my combobox is only looking at:

 

Office365Users.SearchUser({searchTerm:FindEmployee.SearchText}).DisplayName ?

RandyHayes
Super User
Super User

@Oscar-W 

Ah...gotcha.  Then if those are controls, you should *always* reference the Property of the control and not just the control.  Without that property, it can cause problems at play time and confuse the app.

 

So, if they are all text controls, then the formula would change to the following:

Patch('CodeCentre - Requests',
    ForAll(FindEmployee.SelectedItems,
        {Surname: "MCR", 
         WBS: '73PO-00_1'.Text & Project_1.Text & Section_1.Text & Area_1.Text & Role_1.Text,
         From: StartDPick.SelectedDate,
         Expire: EndDPick.SelectedDate,
         'Group/Employee': DisplayName
        }
    )
)

 

As for the other issue...if you append a formula with a column name, then the table returned will only contain that column.  So, since you are appending DisplayName to your Items property on the Combobox, then it will only ever contain the DisplayName.

Change that Items property to:

Office365Users.SearchUserV2({searchTerm: Self.SearchText}).value

(NOTE: This uses the more current SearchUser action as the one you were using is deprecated)

 

Then your other formula would change to:

Patch('CodeCentre - Requests',
    ForAll(FindEmployee.SelectedItems,
        {Surname: Surname, 
         Forename: GivenName,
         WBS: '73PO-00_1'.Text & Project_1.Text & Section_1.Text & Area_1.Text & Role_1.Text,
         From: StartDPick.SelectedDate,
         Expire: EndDPick.SelectedDate,
         'Group/Employee': DisplayName
        }
    )
)

 

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!
Oscar-W
Frequent Visitor

Hey Robert,

 

Wow once again you're helping me a bunch. I do really want to leave you alone now but I implemented your first code fine no problem. Changing the reference point to the property and not the control.

 

However, when I implemented your bottom 2 amendments the button no longer works. The search bar works exactly like it did before but the button code returns this error:

 

Invalid argument type (Table). Expecting a record type. ?

 

Any ideas? No worries if not already helped a bunch.

 

RandyHayes
Super User
Super User

@Oscar-W 

(Randy actually 😉 not Robert)

 

No worries at all - happy to help.

 

So where are you seeing that error?  Specifically, where in the formula (or other formula) is that error occurring?

 

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Helpful resources

Announcements

Exclusive LIVE Community Event: Power Apps Copilot Coffee Chat with Copilot Studio Product Team

  It's time for the SECOND Power Apps Copilot Coffee Chat featuring the Copilot Studio product team, which will be held LIVE on April 3, 2024 at 9:30 AM Pacific Daylight Time (PDT).     This is an incredible opportunity to connect with members of the Copilot Studio product team and ask them anything about Copilot Studio. We'll share our special guests with you shortly--but we want to encourage to mark your calendars now because you will not want to miss the conversation.   This live event will give you the unique opportunity to learn more about Copilot Studio plans, where we’ll focus, and get insight into upcoming features. We’re looking forward to hearing from the community, so bring your questions!   TO GET ACCESS TO THIS EXCLUSIVE AMA: Kudo this post to reserve your spot! Reserve your spot now by kudoing this post.  Reservations will be prioritized on when your kudo for the post comes through, so don't wait! Click that "kudo button" today.   Invitations will be sent on April 2nd.Users posting Kudos after April 2nd. at 9AM PDT may not receive an invitation but will be able to view the session online after conclusion of the event. Give your "kudo" today and mark your calendars for April 3rd, 2024 at 9:30 AM PDT and join us for an engaging and informative session!

Tuesday Tip: Unlocking Community Achievements and Earning Badges

TUESDAY TIPS are our way of communicating helpful things we've learned or shared that have helped members of the Community. Whether you're just getting started or you're a seasoned pro, Tuesday Tips will help you know where to go, what to look for, and navigate your way through the ever-growing--and ever-changing--world of the Power Platform Community! We cover basics about the Community, provide a few "insider tips" to make your experience even better, and share best practices gleaned from our most active community members and Super Users.   With so many new Community members joining us each week, we'll also review a few of our "best practices" so you know just "how" the Community works, so make sure to watch the News & Announcements each week for the latest and greatest Tuesday Tips!     THIS WEEK'S TIP: Unlocking Achievements and Earning BadgesAcross the Communities, you'll see badges on users profile that recognize and reward their engagement and contributions. These badges each signify a different achievement--and all of those achievements are available to any Community member! If you're a seasoned pro or just getting started, you too can earn badges for the great work you do. Check out some details on Community badges below--and find out more in the detailed link at the end of the article!       A Diverse Range of Badges to Collect The badges you can earn in the Community cover a wide array of activities, including: Kudos Received: Acknowledges the number of times a user’s post has been appreciated with a “Kudo.”Kudos Given: Highlights the user’s generosity in recognizing others’ contributions.Topics Created: Tracks the number of discussions initiated by a user.Solutions Provided: Celebrates the instances where a user’s response is marked as the correct solution.Reply: Counts the number of times a user has engaged with community discussions.Blog Contributor: Honors those who contribute valuable content and are invited to write for the community blog.       A Community Evolving Together Badges are not only a great way to recognize outstanding contributions of our amazing Community members--they are also a way to continue fostering a collaborative and supportive environment. As you continue to share your knowledge and assist each other these badges serve as a visual representation of your valuable contributions.   Find out more about badges in these Community Support pages in each Community: All About Community Badges - Power Apps CommunityAll About Community Badges - Power Automate CommunityAll About Community Badges - Copilot Studio CommunityAll About Community Badges - Power Pages Community

Tuesday Tips: Powering Up Your Community Profile

TUESDAY TIPS are our way of communicating helpful things we've learned or shared that have helped members of the Community. Whether you're just getting started or you're a seasoned pro, Tuesday Tips will help you know where to go, what to look for, and navigate your way through the ever-growing--and ever-changing--world of the Power Platform Community! We cover basics about the Community, provide a few "insider tips" to make your experience even better, and share best practices gleaned from our most active community members and Super Users.   With so many new Community members joining us each week, we'll also review a few of our "best practices" so you know just "how" the Community works, so make sure to watch the News & Announcements each week for the latest and greatest Tuesday Tips!   This Week's Tip: Power Up Your Profile!  🚀 It's where every Community member gets their start, and it's essential that you keep it updated! Your Community User Profile is how you're able to get messages, post solutions, ask questions--and as you rank up, it's where your badges will appear and how you'll be known when you start blogging in the Community Blog. Your Community User Profile is how the Community knows you--so it's essential that it works the way you need it to! From changing your username to updating contact information, this Knowledge Base Article is your best resource for powering up your profile.     Password Puzzles? No Problem! Find out how to sync your Azure AD password with your community account, ensuring a seamless sign-in. No separate passwords to remember! Job Jumps & Email Swaps Changed jobs? Got a new email? Fear not! You'll find out how to link your shiny new email to your existing community account, keeping your contributions and connections intact. Username Uncertainties Unraveled Picking the perfect username is crucial--and sometimes the original choice you signed up with doesn't fit as well as you may have thought. There's a quick way to request an update here--but remember, your username is your community identity, so choose wisely. "Need Admin Approval" Warning Window? If you see this error message while using the community, don't worry. A simple process will help you get where you need to go. If you still need assistance, find out how to contact your Community Support team. Whatever you're looking for, when it comes to your profile, the Community Account Support Knowledge Base article is your treasure trove of tips as you navigate the nuances of your Community Profile. It’s the ultimate resource for keeping your digital identity in tip-top shape while engaging with the Power Platform Community. So, dive in and power up your profile today!  💪🚀   Community Account Support | Power Apps Community Account Support | Power AutomateCommunity Account Support | Copilot Studio  Community Account Support | Power Pages

Super User of the Month | Chris Piasecki

In our 2nd installment of this new ongoing feature in the Community, we're thrilled to announce that Chris Piasecki is our Super User of the Month for March 2024. If you've been in the Community for a while, we're sure you've seen a comment or marked one of Chris' helpful tips as a solution--he's been a Super User for SEVEN consecutive seasons!       Since authoring his first reply in April 2020 to his most recent achievement organizing the Canadian Power Platform Summit this month, Chris has helped countless Community members with his insights and expertise. In addition to being a Super User, Chris is also a User Group leader, Microsoft MVP, and a featured speaker at the Microsoft Power Platform Conference. His contributions to the new SUIT program, along with his joyous personality and willingness to jump in and help so many members has made Chris a fixture in the Power Platform Community.   When Chris isn't authoring solutions or organizing events, he's actively leading Piasecki Consulting, specializing in solution architecture, integration, DevOps, and more--helping clients discover how to strategize and implement Microsoft's technology platforms. We are grateful for Chris' insightful help in the Community and look forward to even more amazing milestones as he continues to assist so many with his great tips, solutions--always with a smile and a great sense of humor.You can find Chris in the Community and on LinkedIn. Thanks for being such a SUPER user, Chris! 💪🌠

Find Out What Makes Super Users So Super

We know many of you visit the Power Platform Communities to ask questions and receive answers. But do you know that many of our best answers and solutions come from Community members who are super active, helping anyone who needs a little help getting unstuck with Business Applications products? We call these dedicated Community members Super Users because they are the real heroes in the Community, willing to jump in whenever they can to help! Maybe you've encountered them yourself and they've solved some of your biggest questions. Have you ever wondered, "Why?"We interviewed several of our Super Users to understand what drives them to help in the Community--and discover the difference it has made in their lives as well! Take a look in our gallery today: What Motivates a Super User? - Power Platform Community (microsoft.com)

March User Group Update: New Groups and Upcoming Events!

  Welcome to this month’s celebration of our Community User Groups and exciting User Group events. We’re thrilled to introduce some brand-new user groups that have recently joined our vibrant community. Plus, we’ve got a lineup of engaging events you won’t want to miss. Let’s jump right in: New User Groups   Sacramento Power Platform GroupANZ Power Platform COE User GroupPower Platform MongoliaPower Platform User Group OmanPower Platform User Group Delta StateMid Michigan Power Platform Upcoming Events  DUG4MFG - Quarterly Meetup - Microsoft Demand PlanningDate: 19 Mar 2024 | 10:30 AM to 12:30 PM Central America Standard TimeDescription: Dive into the world of manufacturing with a focus on Demand Planning. Learn from industry experts and share your insights. Dynamics User Group HoustonDate: 07 Mar 2024 | 11:00 AM to 01:00 PM Central America Standard TimeDescription: Houston, get ready for an immersive session on Dynamics 365 and the Power Platform. Connect with fellow professionals and expand your knowledge. Reading Dynamics 365 & Power Platform User Group (Q1)Date: 05 Mar 2024 | 06:00 PM to 09:00 PM GMT Standard TimeDescription: Join our virtual meetup for insightful discussions, demos, and community updates. Let’s kick off Q1 with a bang! Leaders, Create Your Events!    Leaders of existing User Groups, don’t forget to create your events within the Community platform. By doing so, you’ll enable us to share them in future posts and newsletters. Let’s spread the word and make these gatherings even more impactful! Stay tuned for more updates, inspiring stories, and collaborative opportunities from and for our Community User Groups.   P.S. Have an event or success story to share? Reach out to us – we’d love to feature you!

Top Solution Authors
Top Kudoed Authors
Users online (3,764)