cancel
Showing results for 
Search instead for 
Did you mean: 
Reply
akg1421
Advocate II
Advocate II

Error when Filtering data source before Creating a Collection

Using mydatasource to create mycollection1 before filtering mydatasource to return only specific rows

ClearCollect(mycollection1,Blank());
ForAll(mydatasource As mydatasource,
	Filter(mydatasource,mydatasource.UserId="Jonathan"),
    Collect(mycollection1,
        {
            FullNameOriginator: LookUp(mycollection2, ID = mydatasource.'User (Originator)','Person name'),
            Status:mydatasource.Status,
            'User (Originator)':mydatasource.'User (Originator)',
            Subject:mydatasource.Subject,
            'Work item instructions':mydatasource.'Work item instructions',
            WorkflowWorkItemClaimed:mydatasource.WorkflowWorkItemClaimed,
            'User (UserId)':mydatasource.'User (UserId)',
            'Due date time':mydatasource.'Due date time'
        }
    )
);

I want to create collection based only on filtered rows returned from my datasource. In above query I am trying to filter but it returns error.

 

Is the syntax correct?

1 ACCEPTED SOLUTION

Accepted Solutions
poweractivate
Most Valuable Professional
Most Valuable Professional

@akg1421 

 

The second one is closer, but the second one is incorrect as well. As is said in the error message, there are too many arguments to ForAll. In your case, it means that the Filter itself has to be used as the iterable Table in the ForAll. In your second formula, the part where you have 

 

mydatasource As mydatasourceRecord,

 

has to instead be

 

Filter(mydatasource As mdsPreFilteredRecord,mdsPreFilteredRecord.UserId="Jonathan") As mydatasourceRecord

 

 

So like this:

 

ForAll
(
     Filter(mydatasource As mdsPreFilteredRecord,mdsPreFilteredRecord.UserId="Jonathan") As mydatasourceRecord
     ,Collect
     (
        mycollection1
        ,{
             FullNameOriginator: LookUp(mycollection2, ID = mydatasourceRecord.'User (Originator)','Person name')
            ,Status:mydatasourceRecord.Status
            ,'User (Originator)':mydatasourceRecord.'User (Originator)'
            ,Subject:mydatasourceRecord.Subject
            ,'Work item instructions':mydatasourceRecord.'Work item instructions'
            ,WorkflowWorkItemClaimed:mydatasourceRecord.WorkflowWorkItemClaimed
            ,'User (UserId)':mydatasourceRecord.'User (UserId)'
            ,'Due date time':mydatasourceRecord.'Due date time'
        }
     )
);

 

 

Check if it helps @akg1421 

View solution in original post

11 REPLIES 11
poweractivate
Most Valuable Professional
Most Valuable Professional

@akg1421 


@akg1421 wrote:

 

//
ForAll(mydatasource As mydatasource,....

 


You have assigned your record scope mydatasource to be identical to the data source scope mydatasource - you gave them the exact same name! I do not recommend it.

 

I don't recommend to use As with the identical name as the data source

 

Do it this way.

 

I don't know if it will fix it, but it could be problematic to make the As name identical, so it may be better not to:

 

 

ClearCollect(mycollection1,Blank());
ForAll(mydatasource As mydatasourceRecord,
	Filter(mydatasource,mydatasourceRecord.UserId="Jonathan"),
    Collect(mycollection1,
        {
            FullNameOriginator: LookUp(mycollection2, ID = mydatasourceRecord.'User (Originator)','Person name'),
            Status:mydatasourceRecord.Status,
            'User (Originator)':mydatasourceRecord.'User (Originator)',
            Subject:mydatasourceRecord.Subject,
            'Work item instructions':mydatasourceRecord.'Work item instructions',
            WorkflowWorkItemClaimed:mydatasourceRecord.WorkflowWorkItemClaimed,
            'User (UserId)':mydatasourceRecord.'User (UserId)',
            'Due date time':mydatasourceRecord.'Due date time'
        }
    )
);

 

 

See if this happened to help resolve it. 

akg1421
Advocate II
Advocate II

@poweractivate 

Which of the following is correct:

First:

ForAll(mydatasource;
Filter(mydatasource,ThisRecord.'User (UserId)' = "Jonathan"),
    Collect(mycollection1,
        {
            FullNameOriginator: LookUp(mycollection2, ID = mydatasource.'User (Originator)','Person name'),
            Status:mydatasource.Status,
            'User (Originator)':mydatasource.'User (Originator)',
            Subject:mydatasource.Subject,
            'Work item instructions':mydatasource.'Work item instructions',
            WorkflowWorkItemClaimed:mydatasource.WorkflowWorkItemClaimed,
            'User (UserId)':mydatasource.'User (UserId)',
            'Due date time':mydatasource.'Due date time'
        }
    )
);

gives error "Incompatible types of comparison. These types can't be compared: Text, Table." at:

LookUp(mycollection2, ID = mydatasource.'User (Originator)','Person name')

 

Second:

ForAll(mydatasource As mydatasourceRecord,
	Filter(mydatasource,mydatasourceRecord.UserId="Jonathan"),
    Collect(mycollection1,
        {
            FullNameOriginator: LookUp(mycollection2, ID = mydatasourceRecord.'User (Originator)','Person name'),
            Status:mydatasourceRecord.Status,
            'User (Originator)':mydatasourceRecord.'User (Originator)',
            Subject:mydatasourceRecord.Subject,
            'Work item instructions':mydatasourceRecord.'Work item instructions',
            WorkflowWorkItemClaimed:mydatasourceRecord.WorkflowWorkItemClaimed,
            'User (UserId)':mydatasourceRecord.'User (UserId)',
            'Due date time':mydatasourceRecord.'Due date time'
        }
    )
);

gives error "Invalid number of arguments: received 3, expected 2."

poweractivate
Most Valuable Professional
Most Valuable Professional

@akg1421 

 

The second one is closer, but the second one is incorrect as well. As is said in the error message, there are too many arguments to ForAll. In your case, it means that the Filter itself has to be used as the iterable Table in the ForAll. In your second formula, the part where you have 

 

mydatasource As mydatasourceRecord,

 

has to instead be

 

Filter(mydatasource As mdsPreFilteredRecord,mdsPreFilteredRecord.UserId="Jonathan") As mydatasourceRecord

 

 

So like this:

 

ForAll
(
     Filter(mydatasource As mdsPreFilteredRecord,mdsPreFilteredRecord.UserId="Jonathan") As mydatasourceRecord
     ,Collect
     (
        mycollection1
        ,{
             FullNameOriginator: LookUp(mycollection2, ID = mydatasourceRecord.'User (Originator)','Person name')
            ,Status:mydatasourceRecord.Status
            ,'User (Originator)':mydatasourceRecord.'User (Originator)'
            ,Subject:mydatasourceRecord.Subject
            ,'Work item instructions':mydatasourceRecord.'Work item instructions'
            ,WorkflowWorkItemClaimed:mydatasourceRecord.WorkflowWorkItemClaimed
            ,'User (UserId)':mydatasourceRecord.'User (UserId)'
            ,'Due date time':mydatasourceRecord.'Due date time'
        }
     )
);

 

 

Check if it helps @akg1421 

@poweractivate 

It's working fine. Collection is created as per requirement. However, it does not seem to be Filtering data for UserId="Jonathan"

poweractivate
Most Valuable Professional
Most Valuable Professional

@akg1421 

 

Maybe you want the Collection to be iterated on all items but for the final result to be Filtered - if so, then maybe you want it like this?

Filter
(
	ForAll
	(
		 mydatasource As mydatasourceRecord
		 ,Collect
		 (
			mycollection1
			,{
				 FullNameOriginator: LookUp(mycollection2, ID = mydatasourceRecord.'User (Originator)','Person name')
				,Status:mydatasourceRecord.Status
				,'User (Originator)':mydatasourceRecord.'User (Originator)'
				,Subject:mydatasourceRecord.Subject
				,'Work item instructions':mydatasourceRecord.'Work item instructions'
				,WorkflowWorkItemClaimed:mydatasourceRecord.WorkflowWorkItemClaimed
				,'User (UserId)':mydatasourceRecord.'User (UserId)'
				,'Due date time':mydatasourceRecord.'Due date time'
			}
		 )
	) As processedRecord
	,processedRecord.UserId="Jonathan"
)

 

Does the above work better?

 

@poweractivate Nope, your previous reply resolved the issue. 

Moreover, please guide how can I have the data fully loaded in collection before the user starts navigating through screens. Because the datasource is a "dynamics 365" entity and it takes usually 15 to 20 seconds before data is fully loaded and showing in Gallery.

 

I have tried App.OnStart() - Didn't work! I then tried LandingScreen.OnVisible() that also didn't work. What would be the right way to STOP user from navigating before the data is completely iterated and stored in collection.

poweractivate
Most Valuable Professional
Most Valuable Professional

@akg1421 

 

On the first screen of your app, have a big Label that says PLEASE WAIT.

Have a Timer Control on that same first screen where the big PLEASE WAIT label is, that is repeating each second. Make the Duration be 1000 to do this

Make the AutoStart property to be true

Make the Repeat property to be true

OnTimerEnd of the Timer control, use CountRows to check how many Records are in the Collection you are trying to load into.

 

If it is greater than some number of your choice, use Navigate(MainAppScreen) 

So for OnTimerEnd of the Timer control something like this:

 

If(CountRows(myCollection)>50,Navigate(MainAppScreen))

 

 Otherwise the Timer will auto repeat and check it again in another second.

 

See if something like the above could help as starting point @akg1421 

@poweractivate 

 

It just loops around with timer resetting. CountRows is dynamic, it may never be greater than the number of choice. It's values range from 0 to 50

 

If(CountRows(myCollection)>50,Navigate(MainAppScreen))

 

 

Any solution to this?

poweractivate
Most Valuable Professional
Most Valuable Professional

@akg1421 

 

Instead of 50 just use 0 - or use a smaller number like 5 or 10 does it work better that way?

Try just 0 for now, it sounds like you don't have so many records right now - so just use 0.

Helpful resources

Announcements

Celebrating the May Super User of the Month: Laurens Martens

  @LaurensM  is an exceptional contributor to the Power Platform Community. Super Users like Laurens inspire others through their example, encouragement, and active participation. We are excited to celebrated Laurens as our Super User of the Month for May 2024.   Consistent Engagement:  He consistently engages with the community by answering forum questions, sharing insights, and providing solutions. Laurens dedication helps other users find answers and overcome challenges.   Community Expertise: As a Super User, Laurens plays a crucial role in maintaining a knowledge sharing environment. Always ensuring a positive experience for everyone.   Leadership: He shares valuable insights on community growth, engagement, and future trends. Their contributions help shape the Power Platform Community.   Congratulations, Laurens Martens, for your outstanding work! Keep inspiring others and making a difference in the community!   Keep up the fantastic work!        

Check out the Copilot Studio Cookbook today!

We are excited to announce our new Copilot Cookbook Gallery in the Copilot Studio Community. We can't wait for you to share your expertise and your experience!    Join us for an amazing opportunity where you'll be one of the first to contribute to the Copilot Cookbook—your ultimate guide to mastering Microsoft Copilot. Whether you're seeking inspiration or grappling with a challenge while crafting apps, you probably already know that Copilot Cookbook is your reliable assistant, offering a wealth of tips and tricks at your fingertips--and we want you to add your expertise. What can you "cook" up?   Click this link to get started: https://aka.ms/CS_Copilot_Cookbook_Gallery   Don't miss out on this exclusive opportunity to be one of the first in the Community to share your app creation journey with Copilot. We'll be announcing a Cookbook Challenge very soon and want to make sure you one of the first "cooks" in the kitchen.   Don't miss your moment--start submitting in the Copilot Cookbook Gallery today!     Thank you,  Engagement Team

Announcing Power Apps Copilot Cookbook Gallery

We are excited to share that the all-new Copilot Cookbook Gallery for Power Apps is now available in the Power Apps Community, full of tips and tricks on how to best use Microsoft Copilot as you develop and create in Power Apps. The new Copilot Cookbook is your go-to resource when you need inspiration--or when you're stuck--and aren't sure how to best partner with Copilot while creating apps.   Whether you're looking for the best prompts or just want to know about responsible AI use, visit Copilot Cookbook for regular updates you can rely on--while also serving up some of your greatest tips and tricks for the Community. Check Out the new Copilot Cookbook for Power Apps today: Copilot Cookbook - Power Platform Community.  We can't wait to see what you "cook" up!      

Tuesday Tip | How to Report Spam in Our Community

It's time for another TUESDAY TIPS, your weekly connection with the most insightful tips and tricks that empower both newcomers and veterans in the Power Platform Community! Every Tuesday, we bring you a curated selection of the finest advice, distilled from the resources and tools in the Community. Whether you’re a seasoned member or just getting started, Tuesday Tips are the perfect compass guiding you across the dynamic landscape of the Power Platform Community.   As our community family expands each week, we revisit our essential tools, tips, and tricks to ensure you’re well-versed in the community’s pulse. Keep an eye on the News & Announcements for your weekly Tuesday Tips—you never know what you may learn!   Today's Tip: How to Report Spam in Our Community We strive to maintain a professional and helpful community, and part of that effort involves keeping our platform free of spam. If you encounter a post that you believe is spam, please follow these steps to report it: Locate the Post: Find the post in question within the community.Kebab Menu: Click on the "Kebab" menu | 3 Dots, on the top right of the post.Report Inappropriate Content: Select "Report Inappropriate Content" from the menu.Submit Report: Fill out any necessary details on the form and submit your report.   Our community team will review the report and take appropriate action to ensure our community remains a valuable resource for everyone.   Thank you for helping us keep the community clean and useful!

Community Roundup: A Look Back at Our Last 10 Tuesday Tips

As we continue to grow and learn together, it's important to reflect on the valuable insights we've shared. For today's #TuesdayTip, we're excited to take a moment to look back at the last 10 tips we've shared in case you missed any or want to revisit them. Thanks for your incredible support for this series--we're so glad it was able to help so many of you navigate your community experience!   Getting Started in the Community An overview of everything you need to know about navigating the community on one page!  Community Links: ○ Power Apps ○ Power Automate  ○ Power Pages  ○ Copilot Studio    Community Ranks and YOU Have you ever wondered how your fellow community members ascend the ranks within our community? We explain everything about ranks and how to achieve points so you can climb up in the rankings! Community Links: ○ Power Apps ○ Power Automate  ○ Power Pages  ○ Copilot Studio    Powering Up Your Community Profile Your Community User Profile is how the Community knows you--so it's essential that it works the way you need it to! From changing your username to updating contact information, this Knowledge Base Article is your best resource for powering up your profile. Community Links: ○ Power Apps ○ Power Automate  ○ Power Pages  ○ Copilot Studio    Community Blogs--A Great Place to Start There's so much you'll discover in the Community Blogs, and we hope you'll check them out today!  Community Links: ○ Power Apps ○ Power Automate  ○ Power Pages  ○ Copilot Studio    Unlocking Community Achievements and Earning Badges Across the Communities, you'll see badges on users profile that recognize and reward their engagement and contributions. Check out some details on Community badges--and find out more in the detailed link at the end of the article! Community Links: ○ Power Apps  ○ Power Automate  ○ Power Pages  ○ Copilot Studio    Blogging in the Community Interested in blogging? Everything you need to know on writing blogs in our four communities! Get started blogging across the Power Platform communities today! Community Links: ○ Power Apps  ○ Power Automate  ○ Power Pages  ○ Copilot Studio   Subscriptions & Notifications We don't want you to miss a thing in the community! Read all about how to subscribe to sections of our forums and how to setup your notifications! Community Links: ○ Power Apps  ○ Power Automate  ○ Power Pages  ○ Copilot Studio   Getting Started with Private Messages & Macros Do you want to enhance your communication in the Community and streamline your interactions? One of the best ways to do this is to ensure you are using Private Messaging--and the ever-handy macros that are available to you as a Community member! Community Links: ○ Power Apps  ○ Power Automate  ○ Power Pages  ○ Copilot Studio   Community User Groups Learn everything about being part of, starting, or leading a User Group in the Power Platform Community. Community Links: ○ Power Apps  ○ Power Automate  ○ Power Pages  ○ Copilot Studio   Update Your Community Profile Today! Keep your community profile up to date which is essential for staying connected and engaged with the community. Community Links: ○ Power Apps  ○ Power Automate  ○ Power Pages  ○ Copilot Studio   Thank you for being an integral part of our journey.   Here's to many more Tuesday Tips as we pave the way for a brighter, more connected future! As always, watch the News & Announcements for the next set of tips, coming soon!

Hear what's next for the Power Up Program

Hear from Principal Program Manager, Dimpi Gandhi, to discover the latest enhancements to the Microsoft #PowerUpProgram, including a new accelerated video-based curriculum crafted with the expertise of Microsoft MVPs, Rory Neary and Charlie Phipps-Bennett. If you’d like to hear what’s coming next, click the link below to sign up today! https://aka.ms/PowerUp  

Top Solution Authors
Top Kudoed Authors
Users online (5,183)