cancel
Showing results for 
Search instead for 
Did you mean: 
Reply
HansHeintz
Post Prodigy
Post Prodigy

For All Patch ThisRecord not working

This used to work in my app

 

;;ForAll(
           MyCollection
               ;Patch(ThisRecord;{Test:"1"})
        ) 

Now it is just not doing anything anymore (no errors just ... nothing happens)

1 ACCEPTED SOLUTION

Accepted Solutions
RandyHayes
Super User
Super User

@HansHeintz 

The ForAll was designed as a table producing function.  It can do actions within it (depending on where you use the function).  However, most of the time it is used as a for/loop and causes bad performance in the app.  But, there are times that it has to be used as a loop.  It should be avoided if possible.  Whole different conversation.  But, suffice to say, there would not be an error message for it as PowerApps lets you use it either way.

 

Your initial formula would not do what you expect because you are just doing a Patch statement over and over depending on the amount of records in the MyCollection table. 

Patch is also a function that returns a record.  It will, in this case, not update your collection, it would simply be patching the record you provide it (ThisRecord) with another record ( {Test:1} ).  IN this context, patch will be returning a record only.  It is not given a datasource, only a record.  Patch is very intelligent depending on what you supply it.  If you supply a record as the source, it will only return a patched record.  So, your formula would do nothing because you are not capturing the result of the Patch.

 

I cannot imagine that that formula ever did anything because of what I mention above.  This is how that function works.  It doesn't patch or replace anything except the source and second records are patched together.

 

Searching for your formulas in PowerApps is a challenge and they should be centralized and minimized as much as possible to always avoid any duplication.  That said, it sounds like that is not the case for you and you have to look around for it.  So you'll need to rely on unpacking the app and viewing in VS or other editor.

 

The UpdateIf, based on your formula, will be more effective and efficient in this case.  So, I'd try to change in those places (and perhaps consider centralizing to a none duplicated formula the best you can).

 

Yes you could use :  ClearCollect(MyCollection; ForAll(MyCollection, Patch(ThisRecord, {Test:1})))

But that is a lot of processing for your app and will take it MUCH more time than : UpdateIf(MyCollection, true, {Test:1})

 

 

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

View solution in original post

6 REPLIES 6
RandyHayes
Super User
Super User

@HansHeintz 

Your ForAll is backward - ForAll is a function that returns a table, not a For/Loop.

 

However, it appears that you are trying to change the Test column of all records in your collection.  If so, then utilize the following to do so:

UpdateIf(MyCollection, true, {Test:1})

 

I hope this is helpful for you.

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

The ForAll function evaluates a formula for all the records in a table. The formula can calculate a value and/or perform actions, such as modifying data or working with a connection.

 

I guess I can forgive myself into thinking I can use ForAll as a For/Loop

 

Question remains why it was working and not anymore now.

Also why there are no error messages while I/m doing things backward.

 

I don't mind using UpdateIf in stead of ForAll but I am a bit worried that I have to find every instance of it in my app (finding code is not something Powerapps excels at) or otherwise my next update will leave all my users with problems.

 

I guess I should Use ClearCollect(MyCollection;ForAll(MyCollection..etc

 

Luckily I found this to search my code!

RandyHayes
Super User
Super User

@HansHeintz 

The ForAll was designed as a table producing function.  It can do actions within it (depending on where you use the function).  However, most of the time it is used as a for/loop and causes bad performance in the app.  But, there are times that it has to be used as a loop.  It should be avoided if possible.  Whole different conversation.  But, suffice to say, there would not be an error message for it as PowerApps lets you use it either way.

 

Your initial formula would not do what you expect because you are just doing a Patch statement over and over depending on the amount of records in the MyCollection table. 

Patch is also a function that returns a record.  It will, in this case, not update your collection, it would simply be patching the record you provide it (ThisRecord) with another record ( {Test:1} ).  IN this context, patch will be returning a record only.  It is not given a datasource, only a record.  Patch is very intelligent depending on what you supply it.  If you supply a record as the source, it will only return a patched record.  So, your formula would do nothing because you are not capturing the result of the Patch.

 

I cannot imagine that that formula ever did anything because of what I mention above.  This is how that function works.  It doesn't patch or replace anything except the source and second records are patched together.

 

Searching for your formulas in PowerApps is a challenge and they should be centralized and minimized as much as possible to always avoid any duplication.  That said, it sounds like that is not the case for you and you have to look around for it.  So you'll need to rely on unpacking the app and viewing in VS or other editor.

 

The UpdateIf, based on your formula, will be more effective and efficient in this case.  So, I'd try to change in those places (and perhaps consider centralizing to a none duplicated formula the best you can).

 

Yes you could use :  ClearCollect(MyCollection; ForAll(MyCollection, Patch(ThisRecord, {Test:1})))

But that is a lot of processing for your app and will take it MUCH more time than : UpdateIf(MyCollection, true, {Test:1})

 

 

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!
v-jefferni
Community Support
Community Support

Hi @HansHeintz ,

 

If the data source of the two functions is the same, it is not allowed to use ForAll with Patch/Update to update it:

vjefferni_0-1634805737626.png

 

Note the syntax of the Patch function, in your case it just merged the two records and finally create a new table, leave the collection unmodified:

https://docs.microsoft.com/en-us/powerapps/maker/canvas-apps/functions/function-patch#syntax

Patch( Record1, Record2 [, …] )

  • Record(s) - Required. At least two records that you want to merge. Records are processed in order from the beginning of the argument list to the end, with later property values overriding earlier ones.

https://docs.microsoft.com/en-us/powerapps/maker/canvas-apps/functions/function-patch#merge-records-...

 

Hope this helps.

 

Best regards,

Community Support Team _ Jeffer Ni
If this post helps, then please consider Accept it as the solution to help the other members find it.

 

 

Community Support Team _ Jeffer Ni

If this post helps, then please consider Accept it as the solution to help the other members find it.

HansHeintz
Post Prodigy
Post Prodigy

Looking into an earlier version of my app I found code had been changed after all so nothing changed with the forall, my bad.

ForAll does never change the collection it runs on it seems. 

I iterated throught all my uses of the function and nowhere else used it to change the collection itself but nowhere I use the return value of the function so I always thought it was meant to be a about changing what you throw at it.

 

RandyHayes
Super User
Super User

@HansHeintz 

Yes, it all depends on how you use the output of the ForAll to push it to your collection.  And, more importantly, how you specify the Patch statement.  In your case, you were patching two records...Patch would then return a result and do nothing else.  Since you were not capturing or using that, it was lost.

 

I believe it is important to view functions as functions that return a result.  Most all do.  Some do not.  Those that do not return results are meant to be in behavioral actions in your app.  Those that do, are meant to be used in non-behavioral actions (properties) and should be looked at that way.

 

A common misconception is :  ClearCollect(aCol, {"A val"});  Patch(aCol, {Value:"New val"}) 

The expectation many have is that this will change A val to New val.  The reality is, it does nothing.  The Collect function will create a table with one record with one column called Value and put the text "A Val" in it.

Patch will try to patch a table with a record...which will result in nothing and then Patch will return it, which will just be the original value, but it is not used...it is just discarded.

ClearCollect(aCol, "A val");  Update(aCol, First(aCol), {Value:"New val"}) on the other hand, uses Update - which will update a record in a table.  So, in this case, it will change the Value of the first record in the collection.

ClearCollect(aCol, "A val");  UpdateIf(aCol, Value="A val", {Value:"New val"}) likewise, will update the table record, in this case, the one that matches that value (criteria of Value="A val" is true).

In your case, you wanted to change all of the records in the collection, so using the UpdateIf(aCol, true, {Value:"New val"}) will update all records because the criteria will evaluate to true for every record...and thus it will update it.

 

So, the moral of the story is...use Update and UpdateIf to change your collection record values.  Otherwise you run into complexity.

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Helpful resources

Announcements

Announcing Power Apps Copilot Cookbook Gallery

We are excited to share that the all-new Copilot Cookbook Gallery for Power Apps is now available in the Power Apps Community, full of tips and tricks on how to best use Microsoft Copilot as you develop and create in Power Apps. The new Copilot Cookbook is your go-to resource when you need inspiration--or when you're stuck--and aren't sure how to best partner with Copilot while creating apps.   Whether you're looking for the best prompts or just want to know about responsible AI use, visit Copilot Cookbook for regular updates you can rely on--while also serving up some of your greatest tips and tricks for the Community. Our team will be reviewing posts using the new "Copilot" label to ensure we highlight and amplify the most relevant and recent content, so you're assured of high-quality content every time you visit. If you share a post that gets featured in the curated gallery, you'll get a PM in the Community to let you know!The curated gallery is ready for you to experience now, so visit the new Copilot Cookbook for Power Apps today: Copilot Cookbook - Power Platform Community. We can't wait to see what you "cook" up!      

Tuesday Tips: Getting Started in the Community

TUESDAY TIPS is back!   This weekly series of posts is our way of sharing helpful things we've learned or shared that have helped members of the Community. Whether you're just getting started or you're a seasoned pro, Tuesday Tips will help you know where to go, what to look for, and navigate your way through the ever-growing--and ever-changing--world of the Power Platform Community! The original run of Tuesday Tips was a highlight of last year, and these all-new Tips will hopefully prove to be just as informative as helpful. We will cover some basics about the Community, a few "insider tips" to make your experience even better, and sharing best practices gleaned from our most active community members and Super Users. Make sure to watch the News & Announcements each week for the latest and greatest Tuesday Tips!   THIS WEEK: I'm Brand New! What Do I Do? The number of new community members we have each week is pretty amazing, and we are so glad to welcome all of you to the Community! You may be wondering. "What do I do? Where do I get started? Will anyone be willing to help me? What I have a question? Help!"   Let's start with this: Welcome to the low-code revolution, and more importantly, welcome to the Power Platform Community! This is a great place to start. Whether you're busy with Power Apps, getting familiar with Power Automate, engaging Copilot Studio, or building in Power Pages, there are a few key places you should check out as you begin your journey: FORUMS: The forums are THE place to ask questions, look at questions asked by other Community members—and see answers and solutions from our Super Users and other helpful people in the Community. Power Apps ForumsPower Automate ForumsCopilot Studio ForumsPower Pages Forums   NEWS & ANNOUNCEMENTS: Our News & Announcements section highlights the newest and greatest updates in the Community, news from the product team, and so much more. It’s updated a few times each week and will also help you find ways to connect with what’s going on in the ever-growing world of Power Platform. Power Apps News & AnnouncementsPower Automate News & AnnouncementsCopilot Studio News & AnnouncementsPower Pages News & Announcements   GALLERIES: The Galleries section of the Community features tons of tips and tricks, features and benefits, and more—through videos created by our Super Users, product teams, and other helpful members of the Community. Power Apps GalleriesPower Automate Galleries Copilot Studio GalleriesPower Pages Galleries BLOGS: The community blogs section is full of handy step-by-step tips from members of the Community—and some of them include detailed answers to some of the questions most frequently asked questions, as well as how they solved a problem they faced. Power Apps Community BlogPower Automate Community BlogCopilot Studio Community BlogPower Pages Community Blog POWER UP PROGRAM: If you’d like to really take a huge step forward in your journey, we recommend checking out the Power Up Program, a Microsoft-sponsored initiative that trains new Power Platform users and has been a huge success since it launched a little over a year ago. There’s a waiting list, so definitely apply soon if you’re interested! Find out more here: Microsoft Power Up Program for career switchers.   There's so much more you'll discover in your Power Platform experience, and this Community is here for YOU! We are glad you've discovered us and can't wait to see where you grow! If you're new to the Community and just getting started, make sure to give this post a kudo and introduce yourself so we can welcome you!

Super User of the Month | Drew Poggemann

As part of a new monthly feature in the Community, we are excited to share that Drew Poggemann is our featured Super User for the month of February 2024. If you've been in the Community for a while, we're sure Drew's name is familiar to you, as he is one of our most active contributors--he's been a Super User for five consecutive seasons!   Since authoring his first reply 5 years ago to his 514th solution authored, Drew has helped countless Community members with his insights and expertise. In addition to being a Super User, Drew is also a User Group leader and a Microsoft MVP. His contributions to our Super User sessions and to the new SUIT program are always welcome--as well as his sense of humor and fun-loving way of sharing what he knows with others.   When Drew is not solving problems and authoring solutions, he's busy overseeing the Solution Architecture team at HBS, specializing in application architecture and business solution strategy--something he's been doing for over 30 years. We are grateful for Drew and the amazing way he has used his talent and skills to help so many others in the Community. If you are part of the SUIT program, you got to hear some great tips from Drew at the first SUIT session--and we know he still has much more to share!You can find him in the Community and on LinkedIn. Thank you for all you do, Drew!

Celebrating a New Season of Super Users with Charles Lamanna, CVP Microsoft Business Applications

February 8 was the kickoff to the 2024 Season One Super User program for Power Platform Communities, and we are thrilled to welcome back so many returning Super Users--as well as so many brand new Super Users who started their journey last fall. Our Community Super Users are the true heroes, answering questions, providing solutions, filtering spam, and so much more. The impact they make on the Communities each day is significant, and we wanted to do something special to welcome them at our first kickoff meeting of the year.   Charles Lamanna, Microsoft CVP of Business Applications, has stressed frequently how valuable our Community is to the growth and potential of Power Platform, and we are honored to share this message from him to our 2024 Season One Super Users--as well as anyone who might be interested in joining this elite group of Community members.     If you want to know more about Super Users, check out these posts for more information today:    Power Apps: What is A Super User? - Power Platform CommunityPower Automate: What is A Super User? - Power Platform Community Copilot Studio: What is A Super User? - Power Platform Community Power Pages: What is A Super User? - Power Platform Community

February 2024 User Group Update: Welcoming New Groups and Highlighting Upcoming Events

It's a new month and a brand-new year, which means another opportunity to celebrate our amazing User Groups!Each month, we highlight the new User Groups that have joined the community. It's been a busy season for new groups, because we are thrilled to welcome 15 New User Groups! Take a look at the list below, shared by the different community categories. If your group is listed here, give this post a kudo so we can celebrate with you!   We love our User Groups and the difference they make in the lives of our Community! Thank you to all the new User Groups, new User Group leaders--we look forward to hearing about your successes and the impact you will leave!   In addition to our monthly New User Group spotlight, it's a great time to share some of the latest events happening in our User Group community! Take a look at the list below to find one that fits your schedule and need! There's a great combination of in-person and virtual events to choose from. It's a great time of year to connect and engage with User Groups both locally and online. Please Welcome Our NEW User Groups   Power Platform: Heathcare Power Platform User Group Power Platform Connect Hub Power Platform Usergroup Denmark Mexico Norte- Power Platform User Group Pune Power User Group Sudbury Power Platform User GroupMicrosoft User Group GhanaMPPBLR - Microsoft Power Platform Bengaluru User Group Power Apps:   Myrtle Beach Power Platform User GroupAnanseTechWB PowerApps Copilot Studio: Pathfinders Power Platform Community Dynamics365: Cairo, Egypt MSD 365 Business Central/NAV/F&O User GruopMS Dynamics 365 Business Central LatamCincinnati OH D365 F&O User Group February User Group Events February 2024 Cleveland Power Platform User GroupPortallunsj - Februar 2024Indiana D365/AX February User Group MeetingQ1 2024 KC Power Platform and Dynamics 365 CRM Users Group 

Super Users 2024 Season One is Here!

   We are excited to announce the first season of our 2024 Super Users is here! Our kickoff to the new year welcomes many returning Super Users and several new faces, and it's always exciting to see the impact these incredible individuals will have on the Community in 2024! We are so grateful for the daily difference they make in the Community already and know they will keep staying engaged and excited for all that will happen this year.   How to Spot a Super User in the Community:Have you ever written a post or asked for help in the Community and had it answered by a user with the Super User icon next to their name? It means you have found the actual, real-life superheroes of the Power Platform Community! Super Users are our heroes because of the way they consistently make a difference in the Community. Our amazing Super Users help keep the Community a safe place by flagging spam and letting the Community Managers know about issues. They also make the Community a great place to find answers, because they are often the first to offer solutions and get clarity on questions. Finally, Super Users share valuable insights on ways to keep the Community growing, engaging, and looking ahead!We are honored to reveal the new badges for this season of Super Users! Congratulations to all the new and returning Super Users!     To better answer the question "What is a Super User?" please check out this article: Power Apps: What is A Super User? - Power Platform CommunityPower Automate: What is A Super User? - Power Platform Community Copilot Studio: What is A Super User? - Power Platform Community Power Pages: What is A Super User? - Power Platform Community

Top Solution Authors
Top Kudoed Authors
Users online (2,668)