cancel
Showing results for 
Search instead for 
Did you mean: 
Reply
CABIRD
Post Patron
Post Patron

ForAll patch

Hello

 

Audit app, see the image below.

 

MS PowerAppAudit.jpg

 

 

 

 

For this app, I'm using SharePoint Online (SPO) lists.

 

SPO lists

  • FloorRoom 
  • Questions
  • Auditor
  • AuditAnswers

The audit app has a gallery with questions id, questions, radio buttons and text input for 'comments.' Submitting the data to SPO. The first question, the comment is added. All remaining questions have the same comment added. 

 

Comments: TextInput1_1.Text

 

SPO Comments.jpg

 

 

 

 

 

Full button OnSelect code below. 

Set(varShowSpinner, true);
Set(varRecord, Patch(Auditor, Defaults(Auditor), {Title: Label4.Text, Department: Label5.Text, RoomNumber: ComboBox1.Selected.RoomNumber}));
ForAll(colAuditor, Patch(Auditor, Defaults(Auditor), {RoomNumber: RoomNumber}));
ForAll(colQuestions, Patch(AuditAnswers, Defaults(AuditAnswers), {Title: Answer, QuestionID: ID, AuditID: varRecord.ID, Comments: TextInput1_1.Text}));
Set(varShowSpinner, false);

 

How can I remedy this?

 

Thank you. 

12 REPLIES 12
gabibalaban
Multi Super User
Multi Super User

Hi @CABIRD ,

 

Is the colQuestions the source of Gallery1 ? 

If so... change:

ForAll(colQuestions  Gallery1.AllItems, Patch(AuditAnswers, Defaults(AuditAnswers), {Title: Answer, QuestionID: ID, AuditID: varRecord.ID, Comments: TextInput1_1.Text}));

 

Hope it helps !

RandyHayes
Super User
Super User

@CABIRD 

I am not sure what the collection colQuestions is or what value it provides to your scenario, but consider the following change to your OnSelect action Formula:

Set(varShowSpinner, true);

With({_record: Patch(Auditor, Defaults(Auditor), {Title: Label4.Text, Department: Label5.Text, RoomNumber: ComboBox1.Selected.RoomNumber})},

    Collect(Auditor, ForAll(colAuditor, {RoomNumber: RoomNumber}));
    Collect(AuditAnswers, ForAll(Gallery1.AllItems, {Title:Radio2.Selected.Value, QuestionID: ID, AuditID: _record.ID, Comments: TextInput1_1.Text}));
    
);

Set(varShowSpinner, false);

 

The reason you are only getting the first value is that you are not referencing the text input control in the context of the Gallery.  

In the above Formula, we first Patch a new record to Auditor with the values of, what appear to be, static (non-gallery) controls from your screen.  We store that in the scope context variable _record.

 

Next, within the scope, we iterate through the collection colAuditor (also not sure the purpose of this collection) and create records with the RoomNumber column set to what I would suspect comes from your colAuditor collection of room records.

 

Next, we iterate through the Gallery items and create records in AuditAnswers that contain values from the controls WITHIN the gallery context.  I was able to determine that you have the Radio2 and TextInput1_1 controls and that you have the prior ID of the record first created in Auditor.  However, I was not able to determine where the AuditID was coming from, so I assume it is in the record of the Items of the Gallery.

 

I hope this is helpful for you.

 

 

 

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Hello @RandyHayes 

Thank you for responding I appreciate you doing so. 

I think I understand the use of _record variable. However, the formula doesn't hold user input. The user selects the 
radio button pass. Next question user selects N/A. Next question users choose to answer fail and adds comments.
All entries are cleared. AuditID refers to an Auditor for example room 101 and this was audited by John Doe.  colAuditor lists the persons carrying out the inspection.  colAuditor.jpg colQuestions holds questions. An authorised user can amend or add questions. colQuestions.jpg colAudit stores and hopefully sends user answers to SPO audit answers. colAuditAnswers.jpg


A supervisor or receptionist or maintenance person selects a room audit for example room 101 and reviews auditor answers to questions.  Report screen.jpg


Hopefully, I've clarified my objectives and it helps you to understand my error. With a bit of luck resolve my issue. Thank you. 

Hello @gabibalaban 

 

Thank you for responding. I appreciate you doing so. 

 

Sadly this throws errors. colquestions holds the question and response for example question ID, the question and answer such as fail, pass or N/A.

 

colQuestionTable.jpg

 

 

This is sent to SPO Audit answers 

 

SPOAudit Answers.jpg

 

 

 

 

Hopefully, that clarifies the issue.

 

Have a fabulous day.  

@CABIRD 

So I think you might be missing something, or I am not understanding you.  The Gallery IS a collection/table of items including ALL of the controls in it.  So, if you base your formula for the Submit off of the Gallery, you will have all the values that have been entered.

 

Where I might be misunderstanding is with this one key phrase in your last response

All entries are cleared.

What does that mean?  Your sequence never mentioned the "user clicks submit" 

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Hello @RandyHayes 

 

Thank you for responding. Very much appreciated. 

 

I'm hoping the images will better explain the issue. I'm assuming the radio button answers and or comments are not stored.

 

DataInputAdded.jpgDataInputsDisappear.jpg

RandyHayes
Super User
Super User

@CABIRD 

If those are disappearing when you change the radio control, then you must have some formula in the OnSelect or OnChange of the radio?  I would remove that as it is most likely some patch that is going to cause your gallery to reset.

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Hello @RandyHayes 

 

Thank you for replying. Much appreciated. 

 

Below is the code applied to OnChange, OnSelect. 

 

OnSelect
Set(varShowSpinner, !varShowSpinner)

OnChange
Set(varShowSpinner, true);
Patch(colQuestions, ThisItem,{Answer: Radio2.Selected.Value});
Set(varShowSpinner, false)

 Removal has no effect. Gallery clears.

RandyHayes
Super User
Super User

@CABIRD 

Yep!  That is why your gallery is clearing.  Remove those formulas.  You don't need them if you are using that submit button to submit your data.

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Helpful resources

Announcements

Exclusive LIVE Community Event: Power Apps Copilot Coffee Chat with Copilot Studio Product Team

  It's time for the SECOND Power Apps Copilot Coffee Chat featuring the Copilot Studio product team, which will be held LIVE on April 3, 2024 at 9:30 AM Pacific Daylight Time (PDT).     This is an incredible opportunity to connect with members of the Copilot Studio product team and ask them anything about Copilot Studio. We'll share our special guests with you shortly--but we want to encourage to mark your calendars now because you will not want to miss the conversation.   This live event will give you the unique opportunity to learn more about Copilot Studio plans, where we’ll focus, and get insight into upcoming features. We’re looking forward to hearing from the community, so bring your questions!   TO GET ACCESS TO THIS EXCLUSIVE AMA: Kudo this post to reserve your spot! Reserve your spot now by kudoing this post.  Reservations will be prioritized on when your kudo for the post comes through, so don't wait! Click that "kudo button" today.   Invitations will be sent on April 2nd.Users posting Kudos after April 2nd. at 9AM PDT may not receive an invitation but will be able to view the session online after conclusion of the event. Give your "kudo" today and mark your calendars for April 3rd, 2024 at 9:30 AM PDT and join us for an engaging and informative session!

Tuesday Tip: Unlocking Community Achievements and Earning Badges

TUESDAY TIPS are our way of communicating helpful things we've learned or shared that have helped members of the Community. Whether you're just getting started or you're a seasoned pro, Tuesday Tips will help you know where to go, what to look for, and navigate your way through the ever-growing--and ever-changing--world of the Power Platform Community! We cover basics about the Community, provide a few "insider tips" to make your experience even better, and share best practices gleaned from our most active community members and Super Users.   With so many new Community members joining us each week, we'll also review a few of our "best practices" so you know just "how" the Community works, so make sure to watch the News & Announcements each week for the latest and greatest Tuesday Tips!     THIS WEEK'S TIP: Unlocking Achievements and Earning BadgesAcross the Communities, you'll see badges on users profile that recognize and reward their engagement and contributions. These badges each signify a different achievement--and all of those achievements are available to any Community member! If you're a seasoned pro or just getting started, you too can earn badges for the great work you do. Check out some details on Community badges below--and find out more in the detailed link at the end of the article!       A Diverse Range of Badges to Collect The badges you can earn in the Community cover a wide array of activities, including: Kudos Received: Acknowledges the number of times a user’s post has been appreciated with a “Kudo.”Kudos Given: Highlights the user’s generosity in recognizing others’ contributions.Topics Created: Tracks the number of discussions initiated by a user.Solutions Provided: Celebrates the instances where a user’s response is marked as the correct solution.Reply: Counts the number of times a user has engaged with community discussions.Blog Contributor: Honors those who contribute valuable content and are invited to write for the community blog.       A Community Evolving Together Badges are not only a great way to recognize outstanding contributions of our amazing Community members--they are also a way to continue fostering a collaborative and supportive environment. As you continue to share your knowledge and assist each other these badges serve as a visual representation of your valuable contributions.   Find out more about badges in these Community Support pages in each Community: All About Community Badges - Power Apps CommunityAll About Community Badges - Power Automate CommunityAll About Community Badges - Copilot Studio CommunityAll About Community Badges - Power Pages Community

Tuesday Tips: Powering Up Your Community Profile

TUESDAY TIPS are our way of communicating helpful things we've learned or shared that have helped members of the Community. Whether you're just getting started or you're a seasoned pro, Tuesday Tips will help you know where to go, what to look for, and navigate your way through the ever-growing--and ever-changing--world of the Power Platform Community! We cover basics about the Community, provide a few "insider tips" to make your experience even better, and share best practices gleaned from our most active community members and Super Users.   With so many new Community members joining us each week, we'll also review a few of our "best practices" so you know just "how" the Community works, so make sure to watch the News & Announcements each week for the latest and greatest Tuesday Tips!   This Week's Tip: Power Up Your Profile!  🚀 It's where every Community member gets their start, and it's essential that you keep it updated! Your Community User Profile is how you're able to get messages, post solutions, ask questions--and as you rank up, it's where your badges will appear and how you'll be known when you start blogging in the Community Blog. Your Community User Profile is how the Community knows you--so it's essential that it works the way you need it to! From changing your username to updating contact information, this Knowledge Base Article is your best resource for powering up your profile.     Password Puzzles? No Problem! Find out how to sync your Azure AD password with your community account, ensuring a seamless sign-in. No separate passwords to remember! Job Jumps & Email Swaps Changed jobs? Got a new email? Fear not! You'll find out how to link your shiny new email to your existing community account, keeping your contributions and connections intact. Username Uncertainties Unraveled Picking the perfect username is crucial--and sometimes the original choice you signed up with doesn't fit as well as you may have thought. There's a quick way to request an update here--but remember, your username is your community identity, so choose wisely. "Need Admin Approval" Warning Window? If you see this error message while using the community, don't worry. A simple process will help you get where you need to go. If you still need assistance, find out how to contact your Community Support team. Whatever you're looking for, when it comes to your profile, the Community Account Support Knowledge Base article is your treasure trove of tips as you navigate the nuances of your Community Profile. It’s the ultimate resource for keeping your digital identity in tip-top shape while engaging with the Power Platform Community. So, dive in and power up your profile today!  💪🚀   Community Account Support | Power Apps Community Account Support | Power AutomateCommunity Account Support | Copilot Studio  Community Account Support | Power Pages

Super User of the Month | Chris Piasecki

In our 2nd installment of this new ongoing feature in the Community, we're thrilled to announce that Chris Piasecki is our Super User of the Month for March 2024. If you've been in the Community for a while, we're sure you've seen a comment or marked one of Chris' helpful tips as a solution--he's been a Super User for SEVEN consecutive seasons!       Since authoring his first reply in April 2020 to his most recent achievement organizing the Canadian Power Platform Summit this month, Chris has helped countless Community members with his insights and expertise. In addition to being a Super User, Chris is also a User Group leader, Microsoft MVP, and a featured speaker at the Microsoft Power Platform Conference. His contributions to the new SUIT program, along with his joyous personality and willingness to jump in and help so many members has made Chris a fixture in the Power Platform Community.   When Chris isn't authoring solutions or organizing events, he's actively leading Piasecki Consulting, specializing in solution architecture, integration, DevOps, and more--helping clients discover how to strategize and implement Microsoft's technology platforms. We are grateful for Chris' insightful help in the Community and look forward to even more amazing milestones as he continues to assist so many with his great tips, solutions--always with a smile and a great sense of humor.You can find Chris in the Community and on LinkedIn. Thanks for being such a SUPER user, Chris! 💪🌠

Find Out What Makes Super Users So Super

We know many of you visit the Power Platform Communities to ask questions and receive answers. But do you know that many of our best answers and solutions come from Community members who are super active, helping anyone who needs a little help getting unstuck with Business Applications products? We call these dedicated Community members Super Users because they are the real heroes in the Community, willing to jump in whenever they can to help! Maybe you've encountered them yourself and they've solved some of your biggest questions. Have you ever wondered, "Why?"We interviewed several of our Super Users to understand what drives them to help in the Community--and discover the difference it has made in their lives as well! Take a look in our gallery today: What Motivates a Super User? - Power Platform Community (microsoft.com)

March User Group Update: New Groups and Upcoming Events!

  Welcome to this month’s celebration of our Community User Groups and exciting User Group events. We’re thrilled to introduce some brand-new user groups that have recently joined our vibrant community. Plus, we’ve got a lineup of engaging events you won’t want to miss. Let’s jump right in: New User Groups   Sacramento Power Platform GroupANZ Power Platform COE User GroupPower Platform MongoliaPower Platform User Group OmanPower Platform User Group Delta StateMid Michigan Power Platform Upcoming Events  DUG4MFG - Quarterly Meetup - Microsoft Demand PlanningDate: 19 Mar 2024 | 10:30 AM to 12:30 PM Central America Standard TimeDescription: Dive into the world of manufacturing with a focus on Demand Planning. Learn from industry experts and share your insights. Dynamics User Group HoustonDate: 07 Mar 2024 | 11:00 AM to 01:00 PM Central America Standard TimeDescription: Houston, get ready for an immersive session on Dynamics 365 and the Power Platform. Connect with fellow professionals and expand your knowledge. Reading Dynamics 365 & Power Platform User Group (Q1)Date: 05 Mar 2024 | 06:00 PM to 09:00 PM GMT Standard TimeDescription: Join our virtual meetup for insightful discussions, demos, and community updates. Let’s kick off Q1 with a bang! Leaders, Create Your Events!    Leaders of existing User Groups, don’t forget to create your events within the Community platform. By doing so, you’ll enable us to share them in future posts and newsletters. Let’s spread the word and make these gatherings even more impactful! Stay tuned for more updates, inspiring stories, and collaborative opportunities from and for our Community User Groups.   P.S. Have an event or success story to share? Reach out to us – we’d love to feature you!

Top Solution Authors
Top Kudoed Authors
Users online (10,116)