cancel
Showing results for 
Search instead for 
Did you mean: 
Reply
vjnvinod
Advocate I
Advocate I

Formula error for submitting button

Hi Experts,

 

I am getting the below error in my formula, not sure what i am missing here

 

Patch('VarianceData',First(Filter('VarianceData','EmailAdress'=lbl_useremail.Text)),{Comments:drp_Comments.Selected.Value,Comments:txt_comments.Text});
 
UpdateContext({showsuccess:true});

Navigate(Screen2)

 

 

vjnvinod_0-1671523828967.png

 

1 ACCEPTED SOLUTION

Accepted Solutions
poweractivate
Most Valuable Professional
Most Valuable Professional

@vjnvinod 

Just take it out

or just put

Comments:"test" 

temporarily.

 

If "test" works but needs to be changed to the actual value of a Form control:

Look in the Canvas App form for the name of the correct control and just use that. You will need to just look at each control until you find the one that makes sense. Just click on it and then look at the Tree view on the left side, or look on the top right side as well, see what the name of the Control is.

Example:

1. I click a Control below that looks like it might be the one I am looking for.

2. Then I look at one of the boxed red areas to see the name is Label1 and that's how I can find the name of a Control.

poweractivate_1-1671529118117.png

3. After I found the right one, I can replace txt_comments.Text with Label1.Text (but if you literally use Label1 instead of txt_comments it probably won't work, look for the actual name of your Control and makes sure it's the right one that has the right information you need to put in the Comments column)

 

See if it helps @vjnvinod 

View solution in original post

12 REPLIES 12
shoog
Multi Super User
Multi Super User

You're updating the Comments field two times with different values within your patch function, that's not allowed.

You probably intend to update two different fields.

poweractivate
Most Valuable Professional
Most Valuable Professional

Patch
(
   'VarianceData'
   ,First(Filter('VarianceData','EmailAdress'=lbl_useremail.Text)) 
   {        
         Comments:drp_Comments.Selected.Value
        ,Comments:txt_comments.Text
    }
); 
UpdateContext({showsuccess:true});
Navigate(Screen2)

1. In the above, you have Comments defined twice, you can't do that, change it to

    {        
         Comments:drp_Comments.Selected.Value
        ,Another_Comments:txt_comments.Text
    }

Replace Another_Comments above as appropriate or use Comments: only once, e.g.

    {        
         Comments:drp_Comments.Selected.Value
    }

 

poweractivate
Most Valuable Professional
Most Valuable Professional

@vjnvinod 

 

I also recommend rewriting the formula like this:

 

Patch
(
   'VarianceData'
   ,LookUp('VarianceData','EmailAdress'=lbl_useremail.Text) 
   ,{        
        Comments:txt_comments.Text
    }
); 
UpdateContext({showsuccess:true});
Navigate(Screen2)

 

or even better, like this:

 

With
(
    {_myRecord: LookUp('VarianceData','EmailAdress'=lbl_useremail.Text) }
   ,Patch
   (
       'VarianceData'   
      ,{     
           ID:_myRecord.ID   
           Comments:txt_comments.Text
       }
   ); 
   UpdateContext({showsuccess:true});
   Navigate(Screen2)
)

 

If 'VarianceData' is not a standard SharePoint List. then replace ID in the above with the primary column of your 'VarianceData' data source. The primary column or primary key uniquely identifies all the Records in a Table.

 

If you don't like the With formula, you can do it like this:

 

Patch
(
    'VarianceData'   
   ,{     
        ID:LookUp('VarianceData','EmailAdress'=lbl_useremail.Text).ID 
        Comments:txt_comments.Text
    }
); 
UpdateContext({showsuccess:true});
Navigate(Screen2)

 

 

However, if you'll use any other fields from the LookUp I recommend keeping the With version, for example:

 

 

With
(
    {_myRecord: LookUp('VarianceData','EmailAdress'=lbl_useremail.Text) }
   ,Patch
   (
      'VarianceData'   
      ,{     
           ID:_myRecord.ID   
           Comments:txt_comments.Text
       }
   ); 
   UpdateContext({showsuccess:true});
   UpdateContext({currentRecordColumn3:_myRecord.Column3}); 
   //The With avoids having to repeat the LookUp formula again - without the With you have to write the above line as //UpdateContext({currentRecordColumn3:LookUp('VarianceData','EmailAdress'=lbl_useremail.Text).Column3}); 
   Navigate(Screen2)
)

 

See if this helps as well @vjnvinod 

 

Note that in both the version you gave, and the above, a new record is created if the Filter, LookUp, etc. has no match. If this is intended behavior, then that is fine.

 

If that is not intended behavior,

then you may want to do this instead if you want to avoid creating a new record in case of no match:

 

With
(
    {_myRecord: LookUp('VarianceData','EmailAdress'=lbl_useremail.Text) }
   ,If
    ( 
       IsBlank(_myRecord)
      ,Notify("No VarianceData found with email address " & lbl_useremail.Text,Error) 
      ,Patch
      (
           'VarianceData'   
          ,{     
              ID:_myRecord.ID   
              Comments:txt_comments.Text
           }
       ); 
   )
   UpdateContext({showsuccess:true});
   Navigate(Screen2)
)​

 

 

@poweractivate  @shoog 

 

i am still getting the error, when hoover its says some unexpected character

vjnvinod_1-1671525041270.png

 

see the formula below, basically i have one dropdown and 1 text comment for users to click on submitt button

 

Patch
(
'VarianceData'
,First(Filter('VarianceData','EmailAdress'=lbl_useremail.Text))
{
Comments:drp_Comments.Selected.Value
,OtherComments:txt_comments.Text
}
);
UpdateContext({showsuccess:true});
Navigate(Screen2)

@shoog 

 

yes below are the 2 fields in sharepoint list which i intend to update, can you recommend a formula?

vjnvinod_0-1671525270486.png

 please note that Comments is a dropdown combo box

and Othercomments is a text box

poweractivate
Most Valuable Professional
Most Valuable Professional

@vjnvinod 

Missing a comma before the opening curly brace

Patch
(
   'VarianceData'
   ,First(Filter('VarianceData','EmailAdress'=lbl_useremail.Text))
   ,{
       Comments:drp_Comments.Selected.Value
      ,OtherComments:txt_comments.Text
   }
);
UpdateContext({showsuccess:true});
Navigate(Screen2)

 Note that the above only works without error if OtherComments exists as a column in VarianceData

 

@poweractivate 

see the error below, there is some issue with txt_comments

vjnvinod_0-1671525888787.png

 

here is what i have used based on above thread

 

Patch(VarianceData,First(Filter(VarianceData,EmailAdress=lbl_useremail.Text)),{Comments:drp_Comments.Selected.Value,OtherComments:txt_comments.Text});
UpdateContext({showsuccess:true});
Navigate(Screen2)

poweractivate
Most Valuable Professional
Most Valuable Professional


@vjnvinod wrote:

@shoog 

 

yes below are the 2 fields in sharepoint list which i intend to update, can you recommend a formula?

vjnvinod_0-1671525270486.png

 please note that Comments is a dropdown combo box

and Othercomments is a text box


A Drop down Control and a Combo box Control are not the same thing.

If Comments is a Combo box control mapped to a SharePoint Choice Column that allows multiple selections you may want to use drp_Comments.SelectedItems  if you want all selected choices rather than only the last selected choice:

Patch
(
   'VarianceData'
   ,First(Filter('VarianceData','EmailAdress'=lbl_useremail.Text))
   ,{
       Comments:drp_Comments.SelectedItems
      ,OtherComments:txt_comments.Text
   }
);
UpdateContext({showsuccess:true});
Navigate(Screen2)​

If you get an error, replace drp_Comments.SelectedItems  with drp_Comments.Selected.Value - maybe it's just a Drop down control so it can have only one Selected value anyway then if it's a Drop down control.

 

If it's a SharePoint List I recommend writing like this if possible:

With
(
    {_myRecord:LookUp('VarianceData','EmailAdress'=lbl_useremail.Text)}
   ,Patch
   (
      'VarianceData'
      ,First(Filter('VarianceData','EmailAdress'=lbl_useremail.Text))
      ,{
          ID:_myRecord.ID
         ,Comments:drp_Comments.SelectedItems //or use drp_Comments.Selected.Value
         ,OtherComments:txt_comments.Text
      }
   );
   UpdateContext({showsuccess:true});
   Navigate(Screen2)​​
)

 


To avoid creating new values ever, do this instead:

With
(
    {_myRecord: LookUp('VarianceData','EmailAdress'=lbl_useremail.Text) }
   ,If
    ( 
       IsBlank(_myRecord)
      ,Notify("No VarianceData found with email address " & lbl_useremail.Text,Error) 
      ,Patch
      (
           'VarianceData'   
          ,{     
               ID:_myRecord.ID
              ,Comments:drp_Comments.SelectedItems //or use drp_Comments.Selected.Value
              ,OtherComments:txt_comments.Text
           }
       ); 
   )
   UpdateContext({showsuccess:true});
   Navigate(Screen2)
)

 See if it helps @vjnvinod 

poweractivate
Most Valuable Professional
Most Valuable Professional


@vjnvinod wrote:

@poweractivate 

 

OtherComments:txt_comments.Text


txt_comments may not exist as a name of a Control in your app.

Double check it.

Helpful resources

Announcements

Check out the Copilot Studio Cookbook today!

We are excited to announce our new Copilot Cookbook Gallery in the Copilot Studio Community. We can't wait for you to share your expertise and your experience!    Join us for an amazing opportunity where you'll be one of the first to contribute to the Copilot Cookbook—your ultimate guide to mastering Microsoft Copilot. Whether you're seeking inspiration or grappling with a challenge while crafting apps, you probably already know that Copilot Cookbook is your reliable assistant, offering a wealth of tips and tricks at your fingertips--and we want you to add your expertise. What can you "cook" up?   Click this link to get started: https://aka.ms/CS_Copilot_Cookbook_Gallery   Don't miss out on this exclusive opportunity to be one of the first in the Community to share your app creation journey with Copilot. We'll be announcing a Cookbook Challenge very soon and want to make sure you one of the first "cooks" in the kitchen.   Don't miss your moment--start submitting in the Copilot Cookbook Gallery today!     Thank you,  Engagement Team

Announcing Power Apps Copilot Cookbook Gallery

We are excited to share that the all-new Copilot Cookbook Gallery for Power Apps is now available in the Power Apps Community, full of tips and tricks on how to best use Microsoft Copilot as you develop and create in Power Apps. The new Copilot Cookbook is your go-to resource when you need inspiration--or when you're stuck--and aren't sure how to best partner with Copilot while creating apps.   Whether you're looking for the best prompts or just want to know about responsible AI use, visit Copilot Cookbook for regular updates you can rely on--while also serving up some of your greatest tips and tricks for the Community. Check Out the new Copilot Cookbook for Power Apps today: Copilot Cookbook - Power Platform Community.  We can't wait to see what you "cook" up!      

Tuesday Tip | How to Report Spam in Our Community

It's time for another TUESDAY TIPS, your weekly connection with the most insightful tips and tricks that empower both newcomers and veterans in the Power Platform Community! Every Tuesday, we bring you a curated selection of the finest advice, distilled from the resources and tools in the Community. Whether you’re a seasoned member or just getting started, Tuesday Tips are the perfect compass guiding you across the dynamic landscape of the Power Platform Community.   As our community family expands each week, we revisit our essential tools, tips, and tricks to ensure you’re well-versed in the community’s pulse. Keep an eye on the News & Announcements for your weekly Tuesday Tips—you never know what you may learn!   Today's Tip: How to Report Spam in Our Community We strive to maintain a professional and helpful community, and part of that effort involves keeping our platform free of spam. If you encounter a post that you believe is spam, please follow these steps to report it: Locate the Post: Find the post in question within the community.Kebab Menu: Click on the "Kebab" menu | 3 Dots, on the top right of the post.Report Inappropriate Content: Select "Report Inappropriate Content" from the menu.Submit Report: Fill out any necessary details on the form and submit your report.   Our community team will review the report and take appropriate action to ensure our community remains a valuable resource for everyone.   Thank you for helping us keep the community clean and useful!

Community Roundup: A Look Back at Our Last 10 Tuesday Tips

As we continue to grow and learn together, it's important to reflect on the valuable insights we've shared. For today's #TuesdayTip, we're excited to take a moment to look back at the last 10 tips we've shared in case you missed any or want to revisit them. Thanks for your incredible support for this series--we're so glad it was able to help so many of you navigate your community experience!   Getting Started in the Community An overview of everything you need to know about navigating the community on one page!  Community Links: ○ Power Apps ○ Power Automate  ○ Power Pages  ○ Copilot Studio    Community Ranks and YOU Have you ever wondered how your fellow community members ascend the ranks within our community? We explain everything about ranks and how to achieve points so you can climb up in the rankings! Community Links: ○ Power Apps ○ Power Automate  ○ Power Pages  ○ Copilot Studio    Powering Up Your Community Profile Your Community User Profile is how the Community knows you--so it's essential that it works the way you need it to! From changing your username to updating contact information, this Knowledge Base Article is your best resource for powering up your profile. Community Links: ○ Power Apps ○ Power Automate  ○ Power Pages  ○ Copilot Studio    Community Blogs--A Great Place to Start There's so much you'll discover in the Community Blogs, and we hope you'll check them out today!  Community Links: ○ Power Apps ○ Power Automate  ○ Power Pages  ○ Copilot Studio    Unlocking Community Achievements and Earning Badges Across the Communities, you'll see badges on users profile that recognize and reward their engagement and contributions. Check out some details on Community badges--and find out more in the detailed link at the end of the article! Community Links: ○ Power Apps  ○ Power Automate  ○ Power Pages  ○ Copilot Studio    Blogging in the Community Interested in blogging? Everything you need to know on writing blogs in our four communities! Get started blogging across the Power Platform communities today! Community Links: ○ Power Apps  ○ Power Automate  ○ Power Pages  ○ Copilot Studio   Subscriptions & Notifications We don't want you to miss a thing in the community! Read all about how to subscribe to sections of our forums and how to setup your notifications! Community Links: ○ Power Apps  ○ Power Automate  ○ Power Pages  ○ Copilot Studio   Getting Started with Private Messages & Macros Do you want to enhance your communication in the Community and streamline your interactions? One of the best ways to do this is to ensure you are using Private Messaging--and the ever-handy macros that are available to you as a Community member! Community Links: ○ Power Apps  ○ Power Automate  ○ Power Pages  ○ Copilot Studio   Community User Groups Learn everything about being part of, starting, or leading a User Group in the Power Platform Community. Community Links: ○ Power Apps  ○ Power Automate  ○ Power Pages  ○ Copilot Studio   Update Your Community Profile Today! Keep your community profile up to date which is essential for staying connected and engaged with the community. Community Links: ○ Power Apps  ○ Power Automate  ○ Power Pages  ○ Copilot Studio   Thank you for being an integral part of our journey.   Here's to many more Tuesday Tips as we pave the way for a brighter, more connected future! As always, watch the News & Announcements for the next set of tips, coming soon!

Hear what's next for the Power Up Program

Hear from Principal Program Manager, Dimpi Gandhi, to discover the latest enhancements to the Microsoft #PowerUpProgram, including a new accelerated video-based curriculum crafted with the expertise of Microsoft MVPs, Rory Neary and Charlie Phipps-Bennett. If you’d like to hear what’s coming next, click the link below to sign up today! https://aka.ms/PowerUp  

Welcome to the Power Apps Community

Welcome! Congratulations on joining the Microsoft Power Apps community! You are now a part of a vibrant group of peers and industry experts who are here to network, share knowledge, and even have a little fun! Now that you are a member, you can enjoy the following resources:   The Microsoft Power Apps Community Forums If you are looking for support with any part of Microsoft Power Apps, our forums are the place to go. They are titled "Get Help with Microsoft Power Apps " and there you will find thousands of technical professionals with years of experience who are ready and eager to answer your questions. You now have the ability to post, reply and give "kudos" on the Power Apps community forums! Make sure you conduct a quick search before creating a new post because your question may have already been asked and answered!   Microsoft Power Apps IdeasDo you have an idea to improve the Microsoft Power Apps experience, or a feature request for future product updates? Then the "Power Apps Ideas" section is where you can contribute your suggestions and vote for ideas posted by other community members. We constantly look to the most voted Ideas when planning updates, so your suggestions and votes will always make a difference.   Community Blog & NewsOver the years, more than 600 Power Apps Community Blog Articles have been written and published by our thriving community. Our community members have learned some excellent tips and have keen insights on building Power Apps. On the Power Apps Community Blog, read the latest Power Apps related posts from our community blog authors around the world. Let us know if you would like to become an author and contribute your own writing — everything Power Apps related is welcome!   Power Apps Samples, Learning and Videos GalleriesOur galleries have a little bit of everything to do with Power Apps. Our galleries are great for finding inspiration for your next app or component. You can view, comment and kudo the apps and component gallery to see what others have created! Or share Power Apps that you have created with other Power Apps enthusiasts. Along with all of that awesome content, there is the Power Apps Community Video & MBAS gallery where you can watch tutorials and demos by Microsoft staff, partners, and community gurus in our community video gallery.   Again, we are excited to welcome you to the Microsoft Power Apps community family! Whether you are brand new to the world of process automation or you are a seasoned Power Apps veteran. Our goal is to shape the community to be your ‘go to’ for support, networking, education, inspiration and encouragement as we enjoy this adventure together!   Let us know in the Community Feedback if you have any questions or comments about your community experience.To learn more about the community and your account be sure to visit our Community Support Area boards to learn more! We look forward to seeing you in the Power Apps Community!The Power Apps Team

Top Solution Authors
Top Kudoed Authors
Users online (5,105)