cancel
Showing results for 
Search instead for 
Did you mean: 
Reply
vjnvinod
Advocate I
Advocate I

Formula error for submitting button

Hi Experts,

 

I am getting the below error in my formula, not sure what i am missing here

 

Patch('VarianceData',First(Filter('VarianceData','EmailAdress'=lbl_useremail.Text)),{Comments:drp_Comments.Selected.Value,Comments:txt_comments.Text});
 
UpdateContext({showsuccess:true});

Navigate(Screen2)

 

 

vjnvinod_0-1671523828967.png

 

1 ACCEPTED SOLUTION

Accepted Solutions
poweractivate
Most Valuable Professional
Most Valuable Professional

@vjnvinod 

Just take it out

or just put

Comments:"test" 

temporarily.

 

If "test" works but needs to be changed to the actual value of a Form control:

Look in the Canvas App form for the name of the correct control and just use that. You will need to just look at each control until you find the one that makes sense. Just click on it and then look at the Tree view on the left side, or look on the top right side as well, see what the name of the Control is.

Example:

1. I click a Control below that looks like it might be the one I am looking for.

2. Then I look at one of the boxed red areas to see the name is Label1 and that's how I can find the name of a Control.

poweractivate_1-1671529118117.png

3. After I found the right one, I can replace txt_comments.Text with Label1.Text (but if you literally use Label1 instead of txt_comments it probably won't work, look for the actual name of your Control and makes sure it's the right one that has the right information you need to put in the Comments column)

 

See if it helps @vjnvinod 

View solution in original post

12 REPLIES 12
shoog
Multi Super User
Multi Super User

You're updating the Comments field two times with different values within your patch function, that's not allowed.

You probably intend to update two different fields.

poweractivate
Most Valuable Professional
Most Valuable Professional

Patch
(
   'VarianceData'
   ,First(Filter('VarianceData','EmailAdress'=lbl_useremail.Text)) 
   {        
         Comments:drp_Comments.Selected.Value
        ,Comments:txt_comments.Text
    }
); 
UpdateContext({showsuccess:true});
Navigate(Screen2)

1. In the above, you have Comments defined twice, you can't do that, change it to

    {        
         Comments:drp_Comments.Selected.Value
        ,Another_Comments:txt_comments.Text
    }

Replace Another_Comments above as appropriate or use Comments: only once, e.g.

    {        
         Comments:drp_Comments.Selected.Value
    }

 

poweractivate
Most Valuable Professional
Most Valuable Professional

@vjnvinod 

 

I also recommend rewriting the formula like this:

 

Patch
(
   'VarianceData'
   ,LookUp('VarianceData','EmailAdress'=lbl_useremail.Text) 
   ,{        
        Comments:txt_comments.Text
    }
); 
UpdateContext({showsuccess:true});
Navigate(Screen2)

 

or even better, like this:

 

With
(
    {_myRecord: LookUp('VarianceData','EmailAdress'=lbl_useremail.Text) }
   ,Patch
   (
       'VarianceData'   
      ,{     
           ID:_myRecord.ID   
           Comments:txt_comments.Text
       }
   ); 
   UpdateContext({showsuccess:true});
   Navigate(Screen2)
)

 

If 'VarianceData' is not a standard SharePoint List. then replace ID in the above with the primary column of your 'VarianceData' data source. The primary column or primary key uniquely identifies all the Records in a Table.

 

If you don't like the With formula, you can do it like this:

 

Patch
(
    'VarianceData'   
   ,{     
        ID:LookUp('VarianceData','EmailAdress'=lbl_useremail.Text).ID 
        Comments:txt_comments.Text
    }
); 
UpdateContext({showsuccess:true});
Navigate(Screen2)

 

 

However, if you'll use any other fields from the LookUp I recommend keeping the With version, for example:

 

 

With
(
    {_myRecord: LookUp('VarianceData','EmailAdress'=lbl_useremail.Text) }
   ,Patch
   (
      'VarianceData'   
      ,{     
           ID:_myRecord.ID   
           Comments:txt_comments.Text
       }
   ); 
   UpdateContext({showsuccess:true});
   UpdateContext({currentRecordColumn3:_myRecord.Column3}); 
   //The With avoids having to repeat the LookUp formula again - without the With you have to write the above line as //UpdateContext({currentRecordColumn3:LookUp('VarianceData','EmailAdress'=lbl_useremail.Text).Column3}); 
   Navigate(Screen2)
)

 

See if this helps as well @vjnvinod 

 

Note that in both the version you gave, and the above, a new record is created if the Filter, LookUp, etc. has no match. If this is intended behavior, then that is fine.

 

If that is not intended behavior,

then you may want to do this instead if you want to avoid creating a new record in case of no match:

 

With
(
    {_myRecord: LookUp('VarianceData','EmailAdress'=lbl_useremail.Text) }
   ,If
    ( 
       IsBlank(_myRecord)
      ,Notify("No VarianceData found with email address " & lbl_useremail.Text,Error) 
      ,Patch
      (
           'VarianceData'   
          ,{     
              ID:_myRecord.ID   
              Comments:txt_comments.Text
           }
       ); 
   )
   UpdateContext({showsuccess:true});
   Navigate(Screen2)
)​

 

 

@poweractivate  @shoog 

 

i am still getting the error, when hoover its says some unexpected character

vjnvinod_1-1671525041270.png

 

see the formula below, basically i have one dropdown and 1 text comment for users to click on submitt button

 

Patch
(
'VarianceData'
,First(Filter('VarianceData','EmailAdress'=lbl_useremail.Text))
{
Comments:drp_Comments.Selected.Value
,OtherComments:txt_comments.Text
}
);
UpdateContext({showsuccess:true});
Navigate(Screen2)

@shoog 

 

yes below are the 2 fields in sharepoint list which i intend to update, can you recommend a formula?

vjnvinod_0-1671525270486.png

 please note that Comments is a dropdown combo box

and Othercomments is a text box

poweractivate
Most Valuable Professional
Most Valuable Professional

@vjnvinod 

Missing a comma before the opening curly brace

Patch
(
   'VarianceData'
   ,First(Filter('VarianceData','EmailAdress'=lbl_useremail.Text))
   ,{
       Comments:drp_Comments.Selected.Value
      ,OtherComments:txt_comments.Text
   }
);
UpdateContext({showsuccess:true});
Navigate(Screen2)

 Note that the above only works without error if OtherComments exists as a column in VarianceData

 

@poweractivate 

see the error below, there is some issue with txt_comments

vjnvinod_0-1671525888787.png

 

here is what i have used based on above thread

 

Patch(VarianceData,First(Filter(VarianceData,EmailAdress=lbl_useremail.Text)),{Comments:drp_Comments.Selected.Value,OtherComments:txt_comments.Text});
UpdateContext({showsuccess:true});
Navigate(Screen2)

poweractivate
Most Valuable Professional
Most Valuable Professional


@vjnvinod wrote:

@shoog 

 

yes below are the 2 fields in sharepoint list which i intend to update, can you recommend a formula?

vjnvinod_0-1671525270486.png

 please note that Comments is a dropdown combo box

and Othercomments is a text box


A Drop down Control and a Combo box Control are not the same thing.

If Comments is a Combo box control mapped to a SharePoint Choice Column that allows multiple selections you may want to use drp_Comments.SelectedItems  if you want all selected choices rather than only the last selected choice:

Patch
(
   'VarianceData'
   ,First(Filter('VarianceData','EmailAdress'=lbl_useremail.Text))
   ,{
       Comments:drp_Comments.SelectedItems
      ,OtherComments:txt_comments.Text
   }
);
UpdateContext({showsuccess:true});
Navigate(Screen2)​

If you get an error, replace drp_Comments.SelectedItems  with drp_Comments.Selected.Value - maybe it's just a Drop down control so it can have only one Selected value anyway then if it's a Drop down control.

 

If it's a SharePoint List I recommend writing like this if possible:

With
(
    {_myRecord:LookUp('VarianceData','EmailAdress'=lbl_useremail.Text)}
   ,Patch
   (
      'VarianceData'
      ,First(Filter('VarianceData','EmailAdress'=lbl_useremail.Text))
      ,{
          ID:_myRecord.ID
         ,Comments:drp_Comments.SelectedItems //or use drp_Comments.Selected.Value
         ,OtherComments:txt_comments.Text
      }
   );
   UpdateContext({showsuccess:true});
   Navigate(Screen2)​​
)

 


To avoid creating new values ever, do this instead:

With
(
    {_myRecord: LookUp('VarianceData','EmailAdress'=lbl_useremail.Text) }
   ,If
    ( 
       IsBlank(_myRecord)
      ,Notify("No VarianceData found with email address " & lbl_useremail.Text,Error) 
      ,Patch
      (
           'VarianceData'   
          ,{     
               ID:_myRecord.ID
              ,Comments:drp_Comments.SelectedItems //or use drp_Comments.Selected.Value
              ,OtherComments:txt_comments.Text
           }
       ); 
   )
   UpdateContext({showsuccess:true});
   Navigate(Screen2)
)

 See if it helps @vjnvinod 

poweractivate
Most Valuable Professional
Most Valuable Professional


@vjnvinod wrote:

@poweractivate 

 

OtherComments:txt_comments.Text


txt_comments may not exist as a name of a Control in your app.

Double check it.

Helpful resources

Announcements

Exclusive LIVE Community Event: Power Apps Copilot Coffee Chat with Copilot Studio Product Team

  It's time for the SECOND Power Apps Copilot Coffee Chat featuring the Copilot Studio product team, which will be held LIVE on April 3, 2024 at 9:30 AM Pacific Daylight Time (PDT).     This is an incredible opportunity to connect with members of the Copilot Studio product team and ask them anything about Copilot Studio. We'll share our special guests with you shortly--but we want to encourage to mark your calendars now because you will not want to miss the conversation.   This live event will give you the unique opportunity to learn more about Copilot Studio plans, where we’ll focus, and get insight into upcoming features. We’re looking forward to hearing from the community, so bring your questions!   TO GET ACCESS TO THIS EXCLUSIVE AMA: Kudo this post to reserve your spot! Reserve your spot now by kudoing this post.  Reservations will be prioritized on when your kudo for the post comes through, so don't wait! Click that "kudo button" today.   Invitations will be sent on April 2nd.Users posting Kudos after April 2nd. at 9AM PDT may not receive an invitation but will be able to view the session online after conclusion of the event. Give your "kudo" today and mark your calendars for April 3rd, 2024 at 9:30 AM PDT and join us for an engaging and informative session!

Tuesday Tip: Unlocking Community Achievements and Earning Badges

TUESDAY TIPS are our way of communicating helpful things we've learned or shared that have helped members of the Community. Whether you're just getting started or you're a seasoned pro, Tuesday Tips will help you know where to go, what to look for, and navigate your way through the ever-growing--and ever-changing--world of the Power Platform Community! We cover basics about the Community, provide a few "insider tips" to make your experience even better, and share best practices gleaned from our most active community members and Super Users.   With so many new Community members joining us each week, we'll also review a few of our "best practices" so you know just "how" the Community works, so make sure to watch the News & Announcements each week for the latest and greatest Tuesday Tips!     THIS WEEK'S TIP: Unlocking Achievements and Earning BadgesAcross the Communities, you'll see badges on users profile that recognize and reward their engagement and contributions. These badges each signify a different achievement--and all of those achievements are available to any Community member! If you're a seasoned pro or just getting started, you too can earn badges for the great work you do. Check out some details on Community badges below--and find out more in the detailed link at the end of the article!       A Diverse Range of Badges to Collect The badges you can earn in the Community cover a wide array of activities, including: Kudos Received: Acknowledges the number of times a user’s post has been appreciated with a “Kudo.”Kudos Given: Highlights the user’s generosity in recognizing others’ contributions.Topics Created: Tracks the number of discussions initiated by a user.Solutions Provided: Celebrates the instances where a user’s response is marked as the correct solution.Reply: Counts the number of times a user has engaged with community discussions.Blog Contributor: Honors those who contribute valuable content and are invited to write for the community blog.       A Community Evolving Together Badges are not only a great way to recognize outstanding contributions of our amazing Community members--they are also a way to continue fostering a collaborative and supportive environment. As you continue to share your knowledge and assist each other these badges serve as a visual representation of your valuable contributions.   Find out more about badges in these Community Support pages in each Community: All About Community Badges - Power Apps CommunityAll About Community Badges - Power Automate CommunityAll About Community Badges - Copilot Studio CommunityAll About Community Badges - Power Pages Community

Tuesday Tips: Powering Up Your Community Profile

TUESDAY TIPS are our way of communicating helpful things we've learned or shared that have helped members of the Community. Whether you're just getting started or you're a seasoned pro, Tuesday Tips will help you know where to go, what to look for, and navigate your way through the ever-growing--and ever-changing--world of the Power Platform Community! We cover basics about the Community, provide a few "insider tips" to make your experience even better, and share best practices gleaned from our most active community members and Super Users.   With so many new Community members joining us each week, we'll also review a few of our "best practices" so you know just "how" the Community works, so make sure to watch the News & Announcements each week for the latest and greatest Tuesday Tips!   This Week's Tip: Power Up Your Profile!  🚀 It's where every Community member gets their start, and it's essential that you keep it updated! Your Community User Profile is how you're able to get messages, post solutions, ask questions--and as you rank up, it's where your badges will appear and how you'll be known when you start blogging in the Community Blog. Your Community User Profile is how the Community knows you--so it's essential that it works the way you need it to! From changing your username to updating contact information, this Knowledge Base Article is your best resource for powering up your profile.     Password Puzzles? No Problem! Find out how to sync your Azure AD password with your community account, ensuring a seamless sign-in. No separate passwords to remember! Job Jumps & Email Swaps Changed jobs? Got a new email? Fear not! You'll find out how to link your shiny new email to your existing community account, keeping your contributions and connections intact. Username Uncertainties Unraveled Picking the perfect username is crucial--and sometimes the original choice you signed up with doesn't fit as well as you may have thought. There's a quick way to request an update here--but remember, your username is your community identity, so choose wisely. "Need Admin Approval" Warning Window? If you see this error message while using the community, don't worry. A simple process will help you get where you need to go. If you still need assistance, find out how to contact your Community Support team. Whatever you're looking for, when it comes to your profile, the Community Account Support Knowledge Base article is your treasure trove of tips as you navigate the nuances of your Community Profile. It’s the ultimate resource for keeping your digital identity in tip-top shape while engaging with the Power Platform Community. So, dive in and power up your profile today!  💪🚀   Community Account Support | Power Apps Community Account Support | Power AutomateCommunity Account Support | Copilot Studio  Community Account Support | Power Pages

Super User of the Month | Chris Piasecki

In our 2nd installment of this new ongoing feature in the Community, we're thrilled to announce that Chris Piasecki is our Super User of the Month for March 2024. If you've been in the Community for a while, we're sure you've seen a comment or marked one of Chris' helpful tips as a solution--he's been a Super User for SEVEN consecutive seasons!       Since authoring his first reply in April 2020 to his most recent achievement organizing the Canadian Power Platform Summit this month, Chris has helped countless Community members with his insights and expertise. In addition to being a Super User, Chris is also a User Group leader, Microsoft MVP, and a featured speaker at the Microsoft Power Platform Conference. His contributions to the new SUIT program, along with his joyous personality and willingness to jump in and help so many members has made Chris a fixture in the Power Platform Community.   When Chris isn't authoring solutions or organizing events, he's actively leading Piasecki Consulting, specializing in solution architecture, integration, DevOps, and more--helping clients discover how to strategize and implement Microsoft's technology platforms. We are grateful for Chris' insightful help in the Community and look forward to even more amazing milestones as he continues to assist so many with his great tips, solutions--always with a smile and a great sense of humor.You can find Chris in the Community and on LinkedIn. Thanks for being such a SUPER user, Chris! 💪🌠

Find Out What Makes Super Users So Super

We know many of you visit the Power Platform Communities to ask questions and receive answers. But do you know that many of our best answers and solutions come from Community members who are super active, helping anyone who needs a little help getting unstuck with Business Applications products? We call these dedicated Community members Super Users because they are the real heroes in the Community, willing to jump in whenever they can to help! Maybe you've encountered them yourself and they've solved some of your biggest questions. Have you ever wondered, "Why?"We interviewed several of our Super Users to understand what drives them to help in the Community--and discover the difference it has made in their lives as well! Take a look in our gallery today: What Motivates a Super User? - Power Platform Community (microsoft.com)

March User Group Update: New Groups and Upcoming Events!

  Welcome to this month’s celebration of our Community User Groups and exciting User Group events. We’re thrilled to introduce some brand-new user groups that have recently joined our vibrant community. Plus, we’ve got a lineup of engaging events you won’t want to miss. Let’s jump right in: New User Groups   Sacramento Power Platform GroupANZ Power Platform COE User GroupPower Platform MongoliaPower Platform User Group OmanPower Platform User Group Delta StateMid Michigan Power Platform Upcoming Events  DUG4MFG - Quarterly Meetup - Microsoft Demand PlanningDate: 19 Mar 2024 | 10:30 AM to 12:30 PM Central America Standard TimeDescription: Dive into the world of manufacturing with a focus on Demand Planning. Learn from industry experts and share your insights. Dynamics User Group HoustonDate: 07 Mar 2024 | 11:00 AM to 01:00 PM Central America Standard TimeDescription: Houston, get ready for an immersive session on Dynamics 365 and the Power Platform. Connect with fellow professionals and expand your knowledge. Reading Dynamics 365 & Power Platform User Group (Q1)Date: 05 Mar 2024 | 06:00 PM to 09:00 PM GMT Standard TimeDescription: Join our virtual meetup for insightful discussions, demos, and community updates. Let’s kick off Q1 with a bang! Leaders, Create Your Events!    Leaders of existing User Groups, don’t forget to create your events within the Community platform. By doing so, you’ll enable us to share them in future posts and newsletters. Let’s spread the word and make these gatherings even more impactful! Stay tuned for more updates, inspiring stories, and collaborative opportunities from and for our Community User Groups.   P.S. Have an event or success story to share? Reach out to us – we’d love to feature you!

Top Solution Authors
Top Kudoed Authors
Users online (5,226)