Gallery filtering issues

[Lefty]

Hi,

I have a gallery where I am trying to display only items where users are reviewers or if the user is the person who raised the item. It appears all the items are visible to all users, and I cannot figure out from my code why, on my items property of my gallery I have:

Sort(
    Filter(
        List,
        (
        'Created By'.Email = vUser ||
        LineManager.Email = vUser ||
        Approver1.Value = vUser ||
        Approver12.Email = vUser ||    
        Approver13.Email = vUser ||
        "Email1" = vUser ||
        "Email2" = vUser ||
        "Email3" = vUser ||
        Lower("Email4") = Lower(vUser) ||
        vUser = "Email5" ||
        CurrentUser.Email in MyMngr.MyUser 
    ) 
    
    &&


    StartsWith(
        YourName.DisplayName,tbSearchInput.Text)
        Or StartsWith(RefNumber,Trim(tbSearchInput.Text)) 
   ),
   

  ID,
  Descending
)

I would expect the above code to display items to only those users who are named in any of the above values or any user in the MyMngr table which I have set at App startup, but all items are visible to all users. regardless of the above.... any ideas?

Thanks

[iAm_ManCat]

Hi @Lefty 

Is CurrentUser one of the fields in your datasource or is it something you've set inside the App?

[Lefty]

Hi @iAm_ManCat 

It's set up in my app, I needed to pull full names and other info, so I set it on app on start

[iAm_ManCat · Accepted solution]

Ok thanks for confirming, the reason I ask is that if it evaluates to true then none of the other || filters will apply.

So, need to ask about MyMngr as well, as if CurrentUser and MyMngr are not a direct part of the List, then filtering by it will show all items

It works out to this:

Sort(
    Filter(
        List,
        (
           (   'Created By'.Email = vUser ||
                LineManager.Email = vUser ||
                Approver1.Value = vUser ||
                Approver12.Email = vUser ||    
                Approver13.Email = vUser ||
                "Email1" = vUser ||
                "Email2" = vUser ||
                "Email3" = vUser ||
                Lower("Email4") = Lower(vUser) ||
                vUser = "Email5"
            )
            ||
            CurrentUser.Email in MyMngr.MyUser 
        ) 
    
        &&
           StartsWith(
                   YourName.DisplayName,tbSearchInput.Text)
                   Or StartsWith(RefNumber,Trim(tbSearchInput.Text)
           ) 
   ),

  ID,
  Descending
)

Which then basically becomes

Sort(
    Filter(
        List,
        (
           (  
             These conditions
            )
            ||
            true/false
        ) 
    
        &&
           StartsWith(
                   YourName.DisplayName,tbSearchInput.Text)
                   Or StartsWith(RefNumber,Trim(tbSearchInput.Text)
           ) 
   ),

  ID,
  Descending
)

So that whole initial filter part then basically becomes true/false, rather than filtering:

Sort(
    Filter(
        List,
        (
            true/false
        ) 
    
        &&
           StartsWith(
                   YourName.DisplayName,tbSearchInput.Text)
                   Or StartsWith(RefNumber,Trim(tbSearchInput.Text)
           ) 
   ),

  ID,
  Descending
)

So I think you can try removing that for the moment and we can look at how you want to filter that part once we've got the rest of it working. Additionally, you can help your filter search via the textbox, by not filtering if the length of the text in the search textbox is zero 🙂

So it becomes (temporarily):

Sort(
    Filter(
        List,
        (
           'Created By'.Email = vUser ||
           LineManager.Email = vUser ||
           Approver1.Value = vUser ||
           Approver12.Email = vUser ||    
           Approver13.Email = vUser ||
           "Email1" = vUser ||
           "Email2" = vUser ||
           "Email3" = vUser ||
           Lower("Email4") = Lower(vUser) ||
           vUser = "Email5"
        ) 
    
        &&
        (
           Len(tbSearchInput.Text)=0
           ||
           (
              StartsWith(YourName.DisplayName,tbSearchInput.Text)
              ||
              StartsWith(RefNumber,Trim(tbSearchInput.Text))
           ) 
        )
   ),

  ID,
  Descending
)

Could you try that and then let me know if its filtering correctly, then once we have that working we can discuss the MyMngr situation and get that incorporated into the filter 🙂

Cheers,

Sancho

[Lefty]

Hi @iAm_ManCat 

Thanks so much for explaining, as always a life saver!

It sort of makes sense to me, I've removed the CurrentUser.Email in MyMngr and placed it in an or condition outside of the filter, and added the Len function too, thanks for the extra tip.

I've added some test data to see if my test account sees this and now it only displays the 1 record the account is a reviewer for (really difficult to test this as its a live app).

When I add my test account to the table of users in MyMngr, it then shows all records to that test account.

I think this is working as expected now, do you think there is still an issue, as per your comment about incorporating MyMngr later on into the filter or do you think as per your suggestion of placing it outside of the filter like so it is ok:

Sort(
    Filter(
        List,
        (
        'Created By'.Email = vUser ||
        LineManager.Email = vUser ||
        Approver1.Value = vUser ||
        Approver12.Email = vUser ||    
        Approver13.Email = vUser ||
        "Email1" = vUser ||
        "Email2" = vUser ||
        "Email3" = vUser ||
        Lower("Email4") = Lower(vUser) ||
        vUser = "Email5" ||
       // CurrentUser.Email in MyMngr.MyUser 
    ) 
	
	|| CurrentUser.Email in MyMngr.MyUser 
    
    &&
      (
           Len(tbSearchInput.Text)=0 //not filtering if the length of the text in the search textbox is zero 
           ||
           (
              StartsWith(YourName.DisplayName,tbSearchInput.Text)
              ||
              StartsWith(RefNumber,Trim(tbSearchInput.Text))
           ) 
        )
   ),

  ID,
  Descending
)

[iAm_ManCat]

Hey @Lefty,

If its performing as you expect then it's probably ok. Glad we managed to get it sorted!

In terms of the 'its a live App' issue - I can provide a helpful suggestion on that - What I sometimes do is add a column to all datasources called "DevData" thats a boolean true/false. Then when you set up the App/flows, you have different paths/outputs depending on whether the data entered has DevData=true. Anyway, its just a suggestion that you might find useful, not a requirement 🙂

Cheers,

Sancho

[Lefty]

Thanks @iAm_ManCat 

Just waiting on 1 user to respond as they have the most records where they are stated as a reviewer, but I think we are good.

I'll give your DevData column a try to see how it works out for me. I will make your previous response as an answer, but may reach out if I need further help, if that is ok?

[Lefty]

Hello @iAm_ManCat 

I have noticed my search is not working for all users. It is only working for users who are in MyMngr.MyUser 

Any ideas why this would not be working please?

Thanks

[iAm_ManCat]

Yeah, I think the placement of the MyManager query may be why - is it that you want it to show all records if the user is in MyMngr? If yes, then maybe we need to put it back where it was in the beginning - the search part should now only work when searching

Sort(
    Filter(
        List,
        (
        'Created By'.Email = vUser ||
        LineManager.Email = vUser ||
        Approver1.Value = vUser ||
        Approver12.Email = vUser ||    
        Approver13.Email = vUser ||
        "Email1" = vUser ||
        "Email2" = vUser ||
        "Email3" = vUser ||
        Lower("Email4") = Lower(vUser) ||
        vUser = "Email5"
        //putting this back in here, it will override all of the above if its true
        || CurrentUser.Email in MyMngr.MyUser 
        ) 
        &&
        (
            Len(tbSearchInput.Text)=0 //not filtering if the length of the text in the search textbox is zero 
            ||
            (
                StartsWith(YourName.DisplayName,tbSearchInput.Text)
                ||
                StartsWith(RefNumber,Trim(tbSearchInput.Text))
            ) 
        )
   ),

  ID,
  Descending
)

[Lefty]

Hi Yes, if the user is in MyMngr then they should see all the records.... putting it back in the first filter would then put me in the same situation I was with when you helped me I assume, as it will show all records for all users, or have I missed a trick 

Thanks