cancel
Showing results for 
Search instead for 
Did you mean: 
Reply
syhrh
Super User
Super User

Holidays Condition for Formula

Hi, I have this label that will be visible if employees do not apply for Annual Leave 3 days in advance. 3 days means Monday, Tuesday, and Wednesday. The employee can apply on Thursday.

 

anonymous21_0-1660196892273.png         anonymous21_4-1660197120790.png

I set the date picker as 29 August and 31 August is a holiday so when employees apply for Annual leave, their StartDate is 29 August or 30 August or 31 August or 1 September, the label should be visible as 31 August doesn't count in the 3 days requirement. As you can see from the picture below, the label is not visible when it's 1 September while the label should only be invisible on 2 September

        anonymous21_1-1660196948657.png

These are the formulas I use.

//App.OnStart
Set(checkCondition, LookUp('Leave Policy', Title="AnnualLeave"));
Set(
    checkCondition, 
    First(
        SortByColumns(
            Filter(
                'Leave Policy', 
                Title = "AnnualLeave" && 'Effective Date' <= DatePicker1.SelectedDate
            ), 
        "EffectiveDate", Descending)
    )
);
Set(checkCondition2, checkCondition.Days);
//DataCardValue2.OnChange
//DataCardValue2 is Start Date
//DataCardValue17 is End Date
Set(
    VarDateDiff,
    RoundDown(
        DateDiff(
            DatePicker1.SelectedDate,
            DataCardValue2.SelectedDate,
            Days
        ) / 7,
        0
    ) * 5 + Mod(
        5 + Weekday(DataCardValue2.SelectedDate) - Weekday(DatePicker1.SelectedDate),
        5
    ) - CountIf(Holidays, StartDate >= DataCardValue2.SelectedDate, StartDate <= DataCardValue17.SelectedDate)
);
If(
    Weekday(DataCardValue2.SelectedDate) = 7 || Weekday(DataCardValue2.SelectedDate) = 1,
    Set(
        VarDateDiff,
        0
    );
    Set(
        VarWeekEndError,
        true
    ),
    Set(
        VarWeekEndError,
        false
    )
);
Set(
    VarNegativeDateError,
    If(
        DatePicker1.SelectedDate > DataCardValue2.SelectedDate,
        true,
        false
    )
);
Set(
    VarAllowHoliday,
    If(
        VarDateDiff >= Value(checkCondition2),
        true,
        false
    )
);

I tried to change the VarDateDiff >= Value(CheckCondition2), into VarDate > Value(CheckCondition2). It works for holidays only but if there are no holidays then it exceeds the 3 days requirement.

 

How to fix this issue?

 

Thank you.

 

1 ACCEPTED SOLUTION

Accepted Solutions

Dear @syhrh ,

 

Could you please provide each of those 3 examples and the holidays you had in between. I can make a similar test case - this will help me figure out what is wrong.

 

I made three test cases

Lets assume today's date is 24rth august

 

  1. Start Date is 30th august and End date is 5th September. WE have a company holiday on 25th August. - Success
    • I got the error successfully
    • Anonymous_Hippo_0-1661319657474.png

       

  2. Start Date is 31st August and end date is 5th Sept. we have the same holiday fallin on 25th august. Since our difference is 3 we do not see any error now- Success
    • Screenshot 2022-08-24 004341.png
  3. Start Date is 31st August and end date is 23rd Sept. We have holidays on 25th Aug, 29 Aug, 30th Aug. Therefore holiday can be requested only on 1st sept - Success
    • Screenshot 2022-08-24 011114.png

Here make sure that you are using the correct checkcondition2 value here i am using 3 days.

i updated the formulas to catch a couple more errors

 

//StartDate OnChnage
Set(
    VarDateDiff, //This variable gives the number of days from today to start date of planned leave- excluding holidays and weekends
    RoundDown(
        DateDiff(
            Today(),
            DataCardValue2.SelectedDate,
            Days
        ) / 7,
        0
    ) * 5 + Mod(
        5 + Weekday(DataCardValue2.SelectedDate) - Weekday(Today()),
        5
    )- CountIf(Holidays, StartDate >= Today(), StartDate <= DataCardValue2.SelectedDate)// this counts the # of holidays falling inbetween Today and Start date
);
If(
    IsBlank(DataCardValue17.SelectedDate),//if End date is not set the show error
    Set(
        VarDateDiff,
        0
    );
    Set(
        VarEndDatenotSetError,
        true
    ),
    Set(
        VarEndDatenotSetError,
        false
    )
);
If(DataCardValue2.SelectedDate >DataCardValue17.SelectedDate,Set(VarStartDateLess,true),Set(VarStartDateLess,false));
If(DataCardValue17.SelectedDate < DataCardValue2.SelectedDate,Set(VarEndDateLess,true),Set(VarEndDateLess,false));

If(
    Weekday(DataCardValue2.SelectedDate) = 7 || Weekday(DataCardValue2.SelectedDate) = 1,
    Set(
        VarDateDiff,
        0
    );
    Set(
        VarWeekEndError,
        true
    ),
    Set(
        VarWeekEndError,
        false
    )
);
If(!IsBlank(LookUp(Holidays,DataCardValue2.SelectedDate=StartDate)) || !IsBlank(LookUp(Holidays,DataCardValue17.SelectedDate=StartDate)),Set(VarHolidayError,true),Set(VarHolidayError,false));
Set(
    VarNegativeDateError,
    If(
        Today() > DataCardValue2.SelectedDate,
        true,
        false
    )
);
Set(
    VarAllowHoliday,
    If(
        VarDateDiff >= Value(checkCondition2),
        true,
        false
    )
);

 

Error Text

If(VarEndDatenotSetError,"End date needs to be set to allow leave calculation",If(VarHolidayError,"Start Date or end Date cannot be on a holiday",If(VarEndDateLess,"End Date needs to be after Start Date",If(VarStartDateLess,"Start Date needs to be before end date", If(VarEndDatenotSetError,"End date needs to be set to allow leave calculation", If(VarWeekEndError,"Start Date cannot be on a weekend",If(VarNegativeDateError,"Start Date cannot be less than or equal to Today", If(!VarAllowHoliday,"Cannot apply for annual leave as your start date is less than " & Value(checkCondition2) &" days from today (Excluding Weekdays)"))))))))

 

Honestly this should work not sure why it is not working for you

View solution in original post

8 REPLIES 8
Anonymous_Hippo
Super User
Super User

Hello @syhrh ,

 

Could you please explain the required logic on how  to handle holidays. lets say that Today's Date is August 15 th and I want to request vacation from 18th August but there is a holiday on 17th August. Should we only count working days when making the 3 days calculation or should we ignore the holiday in between. Thank you 🙂

Hi @Anonymous_Hippo, the 3 days calculation should only count working days so the 17 August isn't included. So you cannot apply for leave from 18 August because it doesn't meet the 3-day requirement and you can only apply on 19 August. 

Thank you.

Clear now ! @syhrh  Could you also please explain the logic of what you are trying to do with checkcondition2. also could you share a screenshot of that sharepoint list. I think the second formula is good  - the problem child is checkcondition2 

 

Thanks 

Hi @Anonymous_Hippo, the checkcondition2 is to check the days based on the Leave Policy list. In case admin wants to add another policy for the Annual Leave leave application 

anonymous21_0-1660697583517.png

 

@syhrh 

Looks like you are calculating the holidays part incorrectly . In your current formula you are considering holidays that fall in between the start date and end date only but we need to consider holidays falling in between Today and the start date only.

 

Can you try both these formula instead - both can be copy pasted directly (i have changed the names to match your variables) 

 

Start date OnChange property

 

Set(
    VarDateDiff, //This variable gives the number of days from today to start date of planned leave- excluding holidays and weekends
    RoundDown(
        DateDiff(
            Today(),
            DataCardValue2.SelectedDate,
            Days
        ) / 7,
        0
    ) * 5 + Mod(
        5 + Weekday(DataCardValue2.SelectedDate) - Weekday(Today()),
        5
    )- CountIf(Holidays, StartDate >= Today(), StartDate <= DataCardValue2.SelectedDate)// this counts the # of holidays falling inbetween Today and Start date
);
If(
    IsBlank(DataCardValue17.SelectedDate),//if Start date is not set the show error
    Set(
        VarDateDiff,
        0
    );
    Set(
        VarStartDatenotSetError,
        true
    ),
    Set(
        VarStartDatenotSetError,
        false
    )
);
If(
    Weekday(DataCardValue2.SelectedDate) = 7 || Weekday(DataCardValue2.SelectedDate) = 1,
    Set(
        VarDateDiff,
        0
    );
    Set(
        VarWeekEndError,
        true
    ),
    Set(
        VarWeekEndError,
        false
    )
);
Set(
    VarNegativeDateError,
    If(
        Today() > DataCardValue2.SelectedDate,
        true,
        false
    )
);
Set(
    VarAllowHoliday,
    If(
        VarDateDiff >= Value(checkCondition2),
        true,
        false
    )
);

 

 

OnStart

 

//App.OnStart
Set(checkCondition, LookUp('Leave Policy', Title="AnnualLeave"));
Set(
    checkCondition, 
    First(
        SortByColumns(
            Filter(
                'Leave Policy', 
                Title = "AnnualLeave" && 'Effective Date' <= DatePicker1.SelectedDate
            ), 
        "EffectiveDate", Descending)
    )
);
Set(checkCondition2, checkCondition.Days);

 

 

Error Text

 

If(VarStartDatenotSetError,"Start date needs to be set to allow leave calculation",If(VarWeekEndError,"Start Date cannot be on a weekend",If(VarNegativeDateError,"Start Date cannot be less than or equal to Today",If(!VarAllowHoliday,"Cannot apply for annual leave as your start date is less than "&Value(checkCondition2)&" days from today (Excluding Weekdays)"))))

 

 

Cheers !

Hi @Anonymous_Hippo,

I've tested the formula 3 times, each on a different holiday using a date picker just like you showed me in a previous post. The first test works fine for the 3-day requirement. In the second test, the label will only disappear when it's 4 days for the StartDate. In the third test, the label will only disappear when it's 6 days for the StartDate. It keeps increasing over the days. How to fix it?

 

Thank you.

Dear @syhrh ,

 

Could you please provide each of those 3 examples and the holidays you had in between. I can make a similar test case - this will help me figure out what is wrong.

 

I made three test cases

Lets assume today's date is 24rth august

 

  1. Start Date is 30th august and End date is 5th September. WE have a company holiday on 25th August. - Success
    • I got the error successfully
    • Anonymous_Hippo_0-1661319657474.png

       

  2. Start Date is 31st August and end date is 5th Sept. we have the same holiday fallin on 25th august. Since our difference is 3 we do not see any error now- Success
    • Screenshot 2022-08-24 004341.png
  3. Start Date is 31st August and end date is 23rd Sept. We have holidays on 25th Aug, 29 Aug, 30th Aug. Therefore holiday can be requested only on 1st sept - Success
    • Screenshot 2022-08-24 011114.png

Here make sure that you are using the correct checkcondition2 value here i am using 3 days.

i updated the formulas to catch a couple more errors

 

//StartDate OnChnage
Set(
    VarDateDiff, //This variable gives the number of days from today to start date of planned leave- excluding holidays and weekends
    RoundDown(
        DateDiff(
            Today(),
            DataCardValue2.SelectedDate,
            Days
        ) / 7,
        0
    ) * 5 + Mod(
        5 + Weekday(DataCardValue2.SelectedDate) - Weekday(Today()),
        5
    )- CountIf(Holidays, StartDate >= Today(), StartDate <= DataCardValue2.SelectedDate)// this counts the # of holidays falling inbetween Today and Start date
);
If(
    IsBlank(DataCardValue17.SelectedDate),//if End date is not set the show error
    Set(
        VarDateDiff,
        0
    );
    Set(
        VarEndDatenotSetError,
        true
    ),
    Set(
        VarEndDatenotSetError,
        false
    )
);
If(DataCardValue2.SelectedDate >DataCardValue17.SelectedDate,Set(VarStartDateLess,true),Set(VarStartDateLess,false));
If(DataCardValue17.SelectedDate < DataCardValue2.SelectedDate,Set(VarEndDateLess,true),Set(VarEndDateLess,false));

If(
    Weekday(DataCardValue2.SelectedDate) = 7 || Weekday(DataCardValue2.SelectedDate) = 1,
    Set(
        VarDateDiff,
        0
    );
    Set(
        VarWeekEndError,
        true
    ),
    Set(
        VarWeekEndError,
        false
    )
);
If(!IsBlank(LookUp(Holidays,DataCardValue2.SelectedDate=StartDate)) || !IsBlank(LookUp(Holidays,DataCardValue17.SelectedDate=StartDate)),Set(VarHolidayError,true),Set(VarHolidayError,false));
Set(
    VarNegativeDateError,
    If(
        Today() > DataCardValue2.SelectedDate,
        true,
        false
    )
);
Set(
    VarAllowHoliday,
    If(
        VarDateDiff >= Value(checkCondition2),
        true,
        false
    )
);

 

Error Text

If(VarEndDatenotSetError,"End date needs to be set to allow leave calculation",If(VarHolidayError,"Start Date or end Date cannot be on a holiday",If(VarEndDateLess,"End Date needs to be after Start Date",If(VarStartDateLess,"Start Date needs to be before end date", If(VarEndDatenotSetError,"End date needs to be set to allow leave calculation", If(VarWeekEndError,"Start Date cannot be on a weekend",If(VarNegativeDateError,"Start Date cannot be less than or equal to Today", If(!VarAllowHoliday,"Cannot apply for annual leave as your start date is less than " & Value(checkCondition2) &" days from today (Excluding Weekdays)"))))))))

 

Honestly this should work not sure why it is not working for you

Hi @Anonymous_Hippo, it works! Thank you so much for your time and effort. I really appreciate it. 

Helpful resources

Announcements

Celebrating the May Super User of the Month: Laurens Martens

  @LaurensM  is an exceptional contributor to the Power Platform Community. Super Users like Laurens inspire others through their example, encouragement, and active participation. We are excited to celebrated Laurens as our Super User of the Month for May 2024.   Consistent Engagement:  He consistently engages with the community by answering forum questions, sharing insights, and providing solutions. Laurens dedication helps other users find answers and overcome challenges.   Community Expertise: As a Super User, Laurens plays a crucial role in maintaining a knowledge sharing environment. Always ensuring a positive experience for everyone.   Leadership: He shares valuable insights on community growth, engagement, and future trends. Their contributions help shape the Power Platform Community.   Congratulations, Laurens Martens, for your outstanding work! Keep inspiring others and making a difference in the community!   Keep up the fantastic work!        

Check out the Copilot Studio Cookbook today!

We are excited to announce our new Copilot Cookbook Gallery in the Copilot Studio Community. We can't wait for you to share your expertise and your experience!    Join us for an amazing opportunity where you'll be one of the first to contribute to the Copilot Cookbook—your ultimate guide to mastering Microsoft Copilot. Whether you're seeking inspiration or grappling with a challenge while crafting apps, you probably already know that Copilot Cookbook is your reliable assistant, offering a wealth of tips and tricks at your fingertips--and we want you to add your expertise. What can you "cook" up?   Click this link to get started: https://aka.ms/CS_Copilot_Cookbook_Gallery   Don't miss out on this exclusive opportunity to be one of the first in the Community to share your app creation journey with Copilot. We'll be announcing a Cookbook Challenge very soon and want to make sure you one of the first "cooks" in the kitchen.   Don't miss your moment--start submitting in the Copilot Cookbook Gallery today!     Thank you,  Engagement Team

Announcing Power Apps Copilot Cookbook Gallery

We are excited to share that the all-new Copilot Cookbook Gallery for Power Apps is now available in the Power Apps Community, full of tips and tricks on how to best use Microsoft Copilot as you develop and create in Power Apps. The new Copilot Cookbook is your go-to resource when you need inspiration--or when you're stuck--and aren't sure how to best partner with Copilot while creating apps.   Whether you're looking for the best prompts or just want to know about responsible AI use, visit Copilot Cookbook for regular updates you can rely on--while also serving up some of your greatest tips and tricks for the Community. Check Out the new Copilot Cookbook for Power Apps today: Copilot Cookbook - Power Platform Community.  We can't wait to see what you "cook" up!      

Tuesday Tip | How to Report Spam in Our Community

It's time for another TUESDAY TIPS, your weekly connection with the most insightful tips and tricks that empower both newcomers and veterans in the Power Platform Community! Every Tuesday, we bring you a curated selection of the finest advice, distilled from the resources and tools in the Community. Whether you’re a seasoned member or just getting started, Tuesday Tips are the perfect compass guiding you across the dynamic landscape of the Power Platform Community.   As our community family expands each week, we revisit our essential tools, tips, and tricks to ensure you’re well-versed in the community’s pulse. Keep an eye on the News & Announcements for your weekly Tuesday Tips—you never know what you may learn!   Today's Tip: How to Report Spam in Our Community We strive to maintain a professional and helpful community, and part of that effort involves keeping our platform free of spam. If you encounter a post that you believe is spam, please follow these steps to report it: Locate the Post: Find the post in question within the community.Kebab Menu: Click on the "Kebab" menu | 3 Dots, on the top right of the post.Report Inappropriate Content: Select "Report Inappropriate Content" from the menu.Submit Report: Fill out any necessary details on the form and submit your report.   Our community team will review the report and take appropriate action to ensure our community remains a valuable resource for everyone.   Thank you for helping us keep the community clean and useful!

Community Roundup: A Look Back at Our Last 10 Tuesday Tips

As we continue to grow and learn together, it's important to reflect on the valuable insights we've shared. For today's #TuesdayTip, we're excited to take a moment to look back at the last 10 tips we've shared in case you missed any or want to revisit them. Thanks for your incredible support for this series--we're so glad it was able to help so many of you navigate your community experience!   Getting Started in the Community An overview of everything you need to know about navigating the community on one page!  Community Links: ○ Power Apps ○ Power Automate  ○ Power Pages  ○ Copilot Studio    Community Ranks and YOU Have you ever wondered how your fellow community members ascend the ranks within our community? We explain everything about ranks and how to achieve points so you can climb up in the rankings! Community Links: ○ Power Apps ○ Power Automate  ○ Power Pages  ○ Copilot Studio    Powering Up Your Community Profile Your Community User Profile is how the Community knows you--so it's essential that it works the way you need it to! From changing your username to updating contact information, this Knowledge Base Article is your best resource for powering up your profile. Community Links: ○ Power Apps ○ Power Automate  ○ Power Pages  ○ Copilot Studio    Community Blogs--A Great Place to Start There's so much you'll discover in the Community Blogs, and we hope you'll check them out today!  Community Links: ○ Power Apps ○ Power Automate  ○ Power Pages  ○ Copilot Studio    Unlocking Community Achievements and Earning Badges Across the Communities, you'll see badges on users profile that recognize and reward their engagement and contributions. Check out some details on Community badges--and find out more in the detailed link at the end of the article! Community Links: ○ Power Apps  ○ Power Automate  ○ Power Pages  ○ Copilot Studio    Blogging in the Community Interested in blogging? Everything you need to know on writing blogs in our four communities! Get started blogging across the Power Platform communities today! Community Links: ○ Power Apps  ○ Power Automate  ○ Power Pages  ○ Copilot Studio   Subscriptions & Notifications We don't want you to miss a thing in the community! Read all about how to subscribe to sections of our forums and how to setup your notifications! Community Links: ○ Power Apps  ○ Power Automate  ○ Power Pages  ○ Copilot Studio   Getting Started with Private Messages & Macros Do you want to enhance your communication in the Community and streamline your interactions? One of the best ways to do this is to ensure you are using Private Messaging--and the ever-handy macros that are available to you as a Community member! Community Links: ○ Power Apps  ○ Power Automate  ○ Power Pages  ○ Copilot Studio   Community User Groups Learn everything about being part of, starting, or leading a User Group in the Power Platform Community. Community Links: ○ Power Apps  ○ Power Automate  ○ Power Pages  ○ Copilot Studio   Update Your Community Profile Today! Keep your community profile up to date which is essential for staying connected and engaged with the community. Community Links: ○ Power Apps  ○ Power Automate  ○ Power Pages  ○ Copilot Studio   Thank you for being an integral part of our journey.   Here's to many more Tuesday Tips as we pave the way for a brighter, more connected future! As always, watch the News & Announcements for the next set of tips, coming soon!

Hear what's next for the Power Up Program

Hear from Principal Program Manager, Dimpi Gandhi, to discover the latest enhancements to the Microsoft #PowerUpProgram, including a new accelerated video-based curriculum crafted with the expertise of Microsoft MVPs, Rory Neary and Charlie Phipps-Bennett. If you’d like to hear what’s coming next, click the link below to sign up today! https://aka.ms/PowerUp  

Top Solution Authors
Top Kudoed Authors
Users online (3,756)