cancel
Showing results for 
Search instead for 
Did you mean: 
Reply
marclotorto1
Frequent Visitor

Issue updating a SharePoint list within a gallery using OnChange property

Hello,

 

I am currently building an app for a client that utilizes a gallery and SharePoint Online list to replicate the repeating table functionality of InfoPath/SharePoint 2010. For each item in the table, I am collecting a link (single line text), the name of the link (single line text, also the Title field), the name of a reviewer (people picker), date reviewed (date picker), and a reviewed checkbox (Yes/No).

 

I utilize the OnChange property to update the change to each field on each edit with the Patch function. Example code:

 

OnChange: 

 

 

Patch('Links-Spare Parts', ThisItem,
   {Title: txtSPDocName.Text,
   Link: txtSPDocLink.Text,
   'Person Who Verified': drpSparePartsDocReviewer.Selected,
   'Date Verified': dteSparePartsReviewedDate.SelectedDate,
   ReviewCompleted: chkSparePartsReviewCompleted.Value,
   Section: "Spare Parts"});

 

 

 

The behavior works as expected when updated just the text input fields DocName and Link. But when I update the Reviewer people picker, date selector, or review complete check box, it clears the values in the Reviewer people picker and the date selector. The OnChange property isn't clearing or resetting those fields, just patching to the list. What's weirder is when I just set a label to the Reviewer.Selected.DisplayName, it shows the DisplayName as expected. So the data is there in the people picker, but the name doesn't show from the outside and get's cleared. Any ideas for a fix for this?

 

Some screenshots: 

When searching for name, and then selecting

marclotorto1_1-1638990802267.png

 

After selecting the name - notice it pulls it into the label as selected, but clears the people picker box above

marclotorto1_2-1638990819450.png

 

Same for the date picker

marclotorto1_3-1638990840010.png

 

After selecting the date, the value in the picker clears but it shows that the date is still selected with the label

marclotorto1_2-1638990819450.png

 

Thanks in advance

 

 

1 ACCEPTED SOLUTION

Accepted Solutions

@marclotorto1 

Yes, this is because the Combobox OnChange action that you are using will happen because you are technically changing the selection in the combobox...so it runs your formula...which changes the selection (even though it is the same) and then runs the formula again...and again...and again!

Be cautious with Comboboxes and using the OnChange action as this is one of the few controls that will do what you are seeing.

I would suggest trying to avoid using any of the OnSomething actions in PowerApps except for very basic actions (and there are exceptions to this rule).  But, using those actions is very "program-like" and PowerApps is not a programming platform.  

However, working around this is going to be a combination of design choices and function.  

Typically the design choice is to say that you would have a specific "save" button/icon on each row and it is visible when a value is changed.  The user would then click on that save button/icon to THEN perform the formula you have.

Another option is to perform the saves by a button outside of the gallery to save them all, or have an automatic save running by - when the screen is changed or at specific times.

All design choices.

 

Functionality choices are to determine if the function of automatically saving (and thus producing data actions on every control) is needed.  If not, then consider the design choices above.  If so, then you need to work around the OnChange situation of a combobox.  That can be done with "flag" variables to exclude actions when they are not needed...it's a hassle to deal with though.

 

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

View solution in original post

8 REPLIES 8

@marclotorto1 

I would first change the formula you had to:

UpdateIf('Links-Spare Parts', ID=ThisItem.ID,
   {Title: txtSPDocName.Text,
   Link: txtSPDocLink.Text,
   'Person Who Verified': drpSparePartsDocReviewer.Selected,
   'Date Verified': dteSparePartsReviewedDate.SelectedDate,
   ReviewCompleted: chkSparePartsReviewCompleted.Value,
   Section: "Spare Parts"}
);

This will be more precice in that action.

 

As for the controls and their values after the update...this is going to depend on:

- the Default properties of the checkbox and datepicker

- the DefaultSelectedItems property of the combobox

- the Items property of the combobox

- the Items property of your Gallery.

 

So, if you can fill in those details, perhaps the answer will come from that.

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Thanks for the response Randy. I've updated all patch functions to UpdateIf.

 

My values for the other properties are as follows:

- the Default properties of the checkbox and datepicker - these were blank, I've updated themn to ThisItem.Reviewer and ThisItem.DateReviewed. This eliminated the clearing of the date picker, but the Reviewer picker is still clearing...

 

- the DefaultSelectedItems property of the combobox - this is blank

- the Items property of the combobox - it is Choices([@'Links-Spare Parts'].'Person Who Verified')

- the Items property of your Gallery - this is my SharePoint list filtered where the Parent ID 'Master ID' = the ID of these items, which are set on creation. It's a one to many relationship: Filter('Links-Spare Parts', varRecord.ID = MasterID).

 

I am now getting this error which has been popping up and I can't seem to find much after googling: 

marclotorto1_0-1638992504268.png

 

Any ideas?

 

@marclotorto1 

So the error you are seeing is that there is a conflict in the record.  This means that for some reason the record in the list has changed and you are trying to update with older record information. \

For the combobox, you will need to set the DefaultSelectedItems property.  Based on what I see, it should be ThisItem.'Person Who Verified'

 

 

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Hey Randy,

 

So I updated the DefaultSelectedItems to ThisItem.'Person Who Verified' and it accepted it. However now I am getting a super weird error where I am getting a ton of runtime errors on the OnChange property for the reviewer box - 

marclotorto1_0-1638996815006.png

 

Seems similar to the issue before: 

marclotorto1_1-1638996847479.png

 

These error will flicker and duplicate it anyway from 6-8 times in the OnCheck list. Any ideas? Thanks for your help.

 

marclotorto1
Frequent Visitor

Walked away for about 15 mins and came back and now there's 483 runtime errors... would love some clarity if anyone else has run into this.

marclotorto1_0-1638999809604.png

 

@marclotorto1 

Yes, this is because the Combobox OnChange action that you are using will happen because you are technically changing the selection in the combobox...so it runs your formula...which changes the selection (even though it is the same) and then runs the formula again...and again...and again!

Be cautious with Comboboxes and using the OnChange action as this is one of the few controls that will do what you are seeing.

I would suggest trying to avoid using any of the OnSomething actions in PowerApps except for very basic actions (and there are exceptions to this rule).  But, using those actions is very "program-like" and PowerApps is not a programming platform.  

However, working around this is going to be a combination of design choices and function.  

Typically the design choice is to say that you would have a specific "save" button/icon on each row and it is visible when a value is changed.  The user would then click on that save button/icon to THEN perform the formula you have.

Another option is to perform the saves by a button outside of the gallery to save them all, or have an automatic save running by - when the screen is changed or at specific times.

All design choices.

 

Functionality choices are to determine if the function of automatically saving (and thus producing data actions on every control) is needed.  If not, then consider the design choices above.  If so, then you need to work around the OnChange situation of a combobox.  That can be done with "flag" variables to exclude actions when they are not needed...it's a hassle to deal with though.

 

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Thanks for the indepth response Randy. Will work on this and get back to you. Thanks again.

@marclotorto1 

Happy to help!

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Helpful resources

Announcements

Community will be READ ONLY July 16th, 5p PDT -July 22nd

Dear Community Members,   We'd like to let you know of an upcoming change to the community platform: starting July 16th, the platform will transition to a READ ONLY mode until July 22nd.   During this period, members will not be able to Kudo, Comment, or Reply to any posts.   On July 22nd, please be on the lookout for a message sent to the email address registered on your community profile. This email is crucial as it will contain your unique code and link to register for the new platform encompassing all of the communities.   What to Expect in the New Community: A more unified experience where all products, including Power Apps, Power Automate, Copilot Studio, and Power Pages, will be accessible from one community.Community Blogs that you can syndicate and link to for automatic updates. We appreciate your understanding and cooperation during this transition. Stay tuned for the exciting new features and a seamless community experience ahead!

Summer of Solutions | Week 4 Results | Winners will be posted on July 24th

We are excited to announce the Summer of Solutions Challenge!   This challenge is kicking off on Monday, June 17th and will run for (4) weeks.  The challenge is open to all Power Platform (Power Apps, Power Automate, Copilot Studio & Power Pages) community members. We invite you to participate in a quest to provide solutions in the Forums to as many questions as you can. Answers can be provided in all the communities.    Entry Period: This Challenge will consist of four weekly Entry Periods as follows (each an “Entry Period”)   - 12:00 a.m. PT on June 17, 2024 – 11:59 p.m. PT on June 23, 2024 - 12:00 a.m. PT on June 24, 2024 – 11:59 p.m. PT on June 30, 2024 - 12:00 a.m. PT on July 1, 2024 – 11:59 p.m. PT on July 7, 2024 - 12:00 a.m. PT on July 8, 2024 – 11:59 p.m. PT on July 14, 2024   Entries will be eligible for the Entry Period in which they are received and will not carryover to subsequent weekly entry periods.  You must enter into each weekly Entry Period separately.   How to Enter: We invite you to participate in a quest to provide "Accepted Solutions" to as many questions as you can. Answers can be provided in all the communities. Users must provide a solution which can be an “Accepted Solution” in the Forums in all of the communities and there are no limits to the number of “Accepted Solutions” that a member can provide for entries in this challenge, but each entry must be substantially unique and different.    Winner Selection and Prizes: At the end of each week, we will list the top ten (10) Community users which will consist of: 5 Community Members & 5 Super Users and they will advance to the final drawing. We will post each week in the News & Announcements the top 10 Solution providers.  At the end of the challenge, we will add all of the top 10 weekly names and enter them into a random drawing.  Then we will randomly select ten (10) winners (5 Community Members & 5 Super Users) from among all eligible entrants received across all weekly Entry Periods to receive the prize listed below. If a winner declines, we will draw again at random for the next winner.  A user will only be able to win once overall. If they are drawn multiple times, another user will be drawn at random.  Individuals will be contacted before the announcement with the opportunity to claim or deny the prize.  Once all of the winners have been notified, we will post in the News & Announcements of each community with the list of winners.   Each winner will receive one (1) Pass to the Power Platform Conference in Las Vegas, Sep. 18-20, 2024 ($1800 value). NOTE: Prize is for conference attendance only and any other costs such as airfare, lodging, transportation, and food are the sole responsibility of the winner. Tickets are not transferable to any other party or to next year’s event.   ** PLEASE SEE THE ATTACHED RULES for this CHALLENGE**   Week 1 Results: Congratulations to the Week 1 qualifiers, you are being entered in the random drawing that will take place at the end of the challenge. Community MembersNumber of SolutionsSuper UsersNumber of Solutions @anandm08  23 @WarrenBelz  31 @DBO_DV  10 @Amik  19 AmínAA 6 @mmbr1606  12 @rzuber  4 @happyume  7 @Giraldoj  3@ANB 6 (tie)   @SpongYe  6 (tie)     Week 2 Results: Congratulations to the Week 2 qualifiers, you are being entered in the random drawing that will take place at the end of the challenge. Community MembersSolutionsSuper UsersSolutions @anandm08  10@WarrenBelz 25 @DBO_DV  6@mmbr1606 14 @AmínAA 4 @Amik  12 @royg  3 @ANB  10 @AllanDeCastro  2 @SunilPashikanti  5 @Michaelfp  2 @FLMike  5 @eduardo_izzo  2   Meekou 2   @rzuber  2   @Velegandla  2     @PowerPlatform-P  2   @Micaiah  2     Week 3 Results: Congratulations to the Week 3 qualifiers, you are being entered in the random drawing that will take place at the end of the challenge.   Week 3:Community MembersSolutionsSuper UsersSolutionsPower Apps anandm0861WarrenBelz86DBO_DV25Amik66Michaelfp13mmbr160647Giraldoj13FLMike31AmínAA13SpongYe27     Week 4 Results: Congratulations to the Week 4 qualifiers, you are being entered in the random drawing that will take place at the end of the challenge.   Week 4:Community MembersSolutionsSuper UsersSolutionsPower Apps DBO-DV21WarranBelz26Giraldoj7mmbr160618Muzammmil_0695067Amik14samfawzi_acml6FLMike12tzuber6ANB8   SunilPashikanti8

Check Out | 2024 Release Wave 2 Plans for Microsoft Dynamics 365 and Microsoft Power Platform

On July 16, 2024, we published the 2024 release wave 2 plans for Microsoft Dynamics 365 and Microsoft Power Platform. These plans are a compilation of the new capabilities planned to be released between October 2024 to March 2025. This release introduces a wealth of new features designed to enhance customer understanding and improve overall user experience, showcasing our dedication to driving digital transformation for our customers and partners.    The upcoming wave is centered around utilizing advanced AI and Microsoft Copilot technologies to enhance user productivity and streamline operations across diverse business applications. These enhancements include intelligent automation, AI-powered insights, and immersive user experiences that are designed to break down barriers between data, insights, and individuals. Watch a summary of the release highlights.    Discover the latest features that empower organizations to operate more efficiently and adaptively. From AI-driven sales insights and customer service enhancements to predictive analytics in supply chain management and autonomous financial processes, the new capabilities enable businesses to proactively address challenges and capitalize on opportunities.    

Updates to Transitions in the Power Platform Communities

We're embarking on a journey to enhance your experience by transitioning to a new community platform. Our team has been diligently working to create a fresh community site, leveraging the very Dynamics 365 and Power Platform tools our community advocates for.  We started this journey with transitioning Copilot Studio forums and blogs in June. The move marks the beginning of a new chapter, and we're eager for you to be a part of it. The rest of the Power Platform product sites will be moving over this summer.   Stay tuned for more updates as we get closer to the launch. We can't wait to welcome you to our new community space, designed with you in mind. Let's connect, learn, and grow together.   Here's to new beginnings and endless possibilities!   If you have any questions, observations or concerns throughout this process please go to https://aka.ms/PPCommSupport.   To stay up to date on the latest details of this migration and other important Community updates subscribe to our News and Announcements forums: Copilot Studio, Power Apps, Power Automate, Power Pages

Top Solution Authors
Top Kudoed Authors
Users online (1,977)