cancel
Showing results for 
Search instead for 
Did you mean: 
Reply
marclotorto1
Frequent Visitor

Issue updating a SharePoint list within a gallery using OnChange property

Hello,

 

I am currently building an app for a client that utilizes a gallery and SharePoint Online list to replicate the repeating table functionality of InfoPath/SharePoint 2010. For each item in the table, I am collecting a link (single line text), the name of the link (single line text, also the Title field), the name of a reviewer (people picker), date reviewed (date picker), and a reviewed checkbox (Yes/No).

 

I utilize the OnChange property to update the change to each field on each edit with the Patch function. Example code:

 

OnChange: 

 

 

Patch('Links-Spare Parts', ThisItem,
   {Title: txtSPDocName.Text,
   Link: txtSPDocLink.Text,
   'Person Who Verified': drpSparePartsDocReviewer.Selected,
   'Date Verified': dteSparePartsReviewedDate.SelectedDate,
   ReviewCompleted: chkSparePartsReviewCompleted.Value,
   Section: "Spare Parts"});

 

 

 

The behavior works as expected when updated just the text input fields DocName and Link. But when I update the Reviewer people picker, date selector, or review complete check box, it clears the values in the Reviewer people picker and the date selector. The OnChange property isn't clearing or resetting those fields, just patching to the list. What's weirder is when I just set a label to the Reviewer.Selected.DisplayName, it shows the DisplayName as expected. So the data is there in the people picker, but the name doesn't show from the outside and get's cleared. Any ideas for a fix for this?

 

Some screenshots: 

When searching for name, and then selecting

marclotorto1_1-1638990802267.png

 

After selecting the name - notice it pulls it into the label as selected, but clears the people picker box above

marclotorto1_2-1638990819450.png

 

Same for the date picker

marclotorto1_3-1638990840010.png

 

After selecting the date, the value in the picker clears but it shows that the date is still selected with the label

marclotorto1_2-1638990819450.png

 

Thanks in advance

 

 

1 ACCEPTED SOLUTION

Accepted Solutions
RandyHayes
Super User
Super User

@marclotorto1 

Yes, this is because the Combobox OnChange action that you are using will happen because you are technically changing the selection in the combobox...so it runs your formula...which changes the selection (even though it is the same) and then runs the formula again...and again...and again!

Be cautious with Comboboxes and using the OnChange action as this is one of the few controls that will do what you are seeing.

I would suggest trying to avoid using any of the OnSomething actions in PowerApps except for very basic actions (and there are exceptions to this rule).  But, using those actions is very "program-like" and PowerApps is not a programming platform.  

However, working around this is going to be a combination of design choices and function.  

Typically the design choice is to say that you would have a specific "save" button/icon on each row and it is visible when a value is changed.  The user would then click on that save button/icon to THEN perform the formula you have.

Another option is to perform the saves by a button outside of the gallery to save them all, or have an automatic save running by - when the screen is changed or at specific times.

All design choices.

 

Functionality choices are to determine if the function of automatically saving (and thus producing data actions on every control) is needed.  If not, then consider the design choices above.  If so, then you need to work around the OnChange situation of a combobox.  That can be done with "flag" variables to exclude actions when they are not needed...it's a hassle to deal with though.

 

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

View solution in original post

8 REPLIES 8
RandyHayes
Super User
Super User

@marclotorto1 

I would first change the formula you had to:

UpdateIf('Links-Spare Parts', ID=ThisItem.ID,
   {Title: txtSPDocName.Text,
   Link: txtSPDocLink.Text,
   'Person Who Verified': drpSparePartsDocReviewer.Selected,
   'Date Verified': dteSparePartsReviewedDate.SelectedDate,
   ReviewCompleted: chkSparePartsReviewCompleted.Value,
   Section: "Spare Parts"}
);

This will be more precice in that action.

 

As for the controls and their values after the update...this is going to depend on:

- the Default properties of the checkbox and datepicker

- the DefaultSelectedItems property of the combobox

- the Items property of the combobox

- the Items property of your Gallery.

 

So, if you can fill in those details, perhaps the answer will come from that.

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Thanks for the response Randy. I've updated all patch functions to UpdateIf.

 

My values for the other properties are as follows:

- the Default properties of the checkbox and datepicker - these were blank, I've updated themn to ThisItem.Reviewer and ThisItem.DateReviewed. This eliminated the clearing of the date picker, but the Reviewer picker is still clearing...

 

- the DefaultSelectedItems property of the combobox - this is blank

- the Items property of the combobox - it is Choices([@'Links-Spare Parts'].'Person Who Verified')

- the Items property of your Gallery - this is my SharePoint list filtered where the Parent ID 'Master ID' = the ID of these items, which are set on creation. It's a one to many relationship: Filter('Links-Spare Parts', varRecord.ID = MasterID).

 

I am now getting this error which has been popping up and I can't seem to find much after googling: 

marclotorto1_0-1638992504268.png

 

Any ideas?

 

RandyHayes
Super User
Super User

@marclotorto1 

So the error you are seeing is that there is a conflict in the record.  This means that for some reason the record in the list has changed and you are trying to update with older record information. \

For the combobox, you will need to set the DefaultSelectedItems property.  Based on what I see, it should be ThisItem.'Person Who Verified'

 

 

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Hey Randy,

 

So I updated the DefaultSelectedItems to ThisItem.'Person Who Verified' and it accepted it. However now I am getting a super weird error where I am getting a ton of runtime errors on the OnChange property for the reviewer box - 

marclotorto1_0-1638996815006.png

 

Seems similar to the issue before: 

marclotorto1_1-1638996847479.png

 

These error will flicker and duplicate it anyway from 6-8 times in the OnCheck list. Any ideas? Thanks for your help.

 

marclotorto1
Frequent Visitor

Walked away for about 15 mins and came back and now there's 483 runtime errors... would love some clarity if anyone else has run into this.

marclotorto1_0-1638999809604.png

 

RandyHayes
Super User
Super User

@marclotorto1 

Yes, this is because the Combobox OnChange action that you are using will happen because you are technically changing the selection in the combobox...so it runs your formula...which changes the selection (even though it is the same) and then runs the formula again...and again...and again!

Be cautious with Comboboxes and using the OnChange action as this is one of the few controls that will do what you are seeing.

I would suggest trying to avoid using any of the OnSomething actions in PowerApps except for very basic actions (and there are exceptions to this rule).  But, using those actions is very "program-like" and PowerApps is not a programming platform.  

However, working around this is going to be a combination of design choices and function.  

Typically the design choice is to say that you would have a specific "save" button/icon on each row and it is visible when a value is changed.  The user would then click on that save button/icon to THEN perform the formula you have.

Another option is to perform the saves by a button outside of the gallery to save them all, or have an automatic save running by - when the screen is changed or at specific times.

All design choices.

 

Functionality choices are to determine if the function of automatically saving (and thus producing data actions on every control) is needed.  If not, then consider the design choices above.  If so, then you need to work around the OnChange situation of a combobox.  That can be done with "flag" variables to exclude actions when they are not needed...it's a hassle to deal with though.

 

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Thanks for the indepth response Randy. Will work on this and get back to you. Thanks again.

RandyHayes
Super User
Super User

@marclotorto1 

Happy to help!

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Helpful resources

Announcements

Back to Basics: Tuesday Tip #2: All About Community Ranks

This weekly series is our way of helping the amazing members of our community--both new members and seasoned veterans--learn and grow in how to best engage in the community! Each Tuesday, we will feature new areas of content that will help you best understand the community--from ranking and badges to profile avatars, from Super Users to blogging in the community. Our hope is that this information will help each of our community members grow in their experience with Power Platform, with the community, and with each other!   Have you ever wondered how your fellow community members earn the different ranks available? What is the difference between an Advocate and a Helper, a Solution Sage and a Community Champion? In today's #TuesdayTip, we share the secrets and tips to help YOU keep your ranking growing--and why it's so important to our communities. What are community ranks? - Power Platform Community (microsoft.com)   Get the details in this Knowledge Base article that shows you what ranks are, how they are achieved, and what they mean to you as you engage with other community members on a regular basis. Once you start your journey in the community, ranking up, you'll find the benefits. So get busy with those kudos, solutions, and more! We can't wait to see how you rank!That's it for this week. Tune in for more Tuesday Tips next Tuesday and join the community as we continue to get "Back to Basics."

It's #MPPC23 Week! Check Out the Community Sessions and Events Happening in Vegas

After all the planning and preparing, the annual Microsoft Power Platform Conference is finally here! We are excited to see so many of our community in Las Vegas this week. To help make sure you don't miss any of the workshops, sessions, and events we have planned, make sure to check out this handy Community One-Sheet, and download the pdf today! Make sure to stop by the Community Lounge to meet @hugobernier, @EricArcher, @heaher_italent, and @AshleyFelts from our team! See you in Vegas!    

Join Us for the First-Ever Biz Apps Community User Group Meeting: Live from MPPC23

  Join us for the first-ever the Biz Apps Community User Group meeting live from the Power Platform Conference! This one hour user group meeting is all about discovering the value and benefits of User Groups! Discover how you can find a group in your local area or about specific topics where you can learn new skills and meet like-minded people as a user group member.   Hear from User Group leaders about why they do what they do and what resources they receive to help them succeed as community ambassadors. If you have never attended a User Group meeting before, this will be a great introduction! We hope you are inspired to find a group that meets your unique interests!   October 5th at 2:15 pm Pacific time   If you're attending #MPPC23 in Las Vegas, join us in person! Find out more here: https://powerplatformconf.com/#!/session/Biz%20Apps%20Community%20User%20Group%20Meeting%20-%20Live%20from%20MPPC/6172   Not at MPPC23? Attend vvirtually by registering here: https://aka.ms/MPPCusergroupmeeting2023    If you can't attend this meeting live, don't worry! We will record this meeting and share it with the Community at powerusers.microsoft.com 

Back to Basics: Tuesday Tip #1: All About YOUR Community Account

We are excited to kick off our new #TuesdayTIps series, "Back to Basics." This weekly series is our way of helping the amazing members of our community--both new members and seasoned veterans--learn and grow in how to best engage in the community! Each Tuesday, we will feature new areas of content that will help you best understand the community--from ranking and badges to profile avatars, from Super Users to blogging in the community. Our hope is that this information will help each of our community members grow in their experience with Power Platform, with the community, and with each other!     This Week's Tips: Account Support: Changing Passwords, Changing Email Addresses or Usernames, "Need Admin Approval," Etc.Wondering how to get support for your community account? Check out the details on these common questions and more. Just follow the link below for articles that explain it all.Community Account Support - Power Platform Community (microsoft.com)   All About GDPR: How It Affects Closing Your Community Account (And Why You Should Think Twice Before You Do)GDPR, the General Data Protection Regulation (GDPR), took effect May 25th 2018. A European privacy law, GDPR imposes new rules on companies and other organizations offering goods and services to people in the European Union (EU), or that collect and analyze data tied to EU residents. GDPR applies no matter where you are located, and it affects what happens when you decide to close your account. Read the details here:All About GDPR - Power Platform Community (microsoft.com)   Getting to Know You: Setting Up Your Community Profile, Customizing Your Profile, and More.Your community profile helps other members of the community get to know you as you begin to engage and interact. Your profile is a mirror of your activity in the community. Find out how to set it up, change your avatar, adjust your time zone, and more. Click on the link below to find out how:Community Profile, Time Zone, Picture (Avatar) & D... - Power Platform Community (microsoft.com)   That's it for this week. Tune in for more Tuesday Tips next Tuesday and join the community as we get "Back to Basics."

Power Platform Community Newsletter: September 2023

Welcome to our September 2023 Newsletter, where we highlight the latest news, product releases, podcasts, upcoming events, and the great work of our Power Platform Community members. As usual, please make sure you follow our News & Announcements in the Community to stay up to date. Another great way to connect is to join our Power Platform Community on LinkedIn. You can join our LInkedIn community here.   MPPC's Got Power - Submissions end September 28th! Are you ready to showcase your skills at the Microsoft Power Platform Conference in Las Vegas? Don't miss out on the "MPPC's Got Power" talent show, a grand celebration of connection, inspiration, and shared journeys. Whether you're a technical innovator, a talented storyteller, or have a hidden creative side, we want to see what you've got! With three categories to choose from, you have the chance to shine on stage and make your mark in the Microsoft Power Platform community.  Click the GIF to sign up by Thursday 28th September to be part of an unforgettable MPPC23 experience. Now is your time to shine!     Check Out the Low Code Approach Podcast Give the Low Code Approach Podcast a listen! Hosted by Sean Fiene, Wendy Haddad, and Kenric Auguillard, this innovative show shines a light on how Microsoft MVPs, product team members, and Community users are building exciting solutions using Microsoft Power Platform. Plus, with guests like Kartik Kanakasabesan, April Dunnam, Ricardo Duncan Jr., Sonja Gu, Phil Topness, Shane Young and more, this weekly show is a must for all you Business Applications enthusiasts out there. Click the image below to check it out!           COMMUNITY HIGHLIGHTS Check out the most active Community users for August 2023. These hardworking members are posting regularly, answering questions, writing blogs, giving kudos, and providing top solutions in their communities across Power Platform. Huge thanks to these amazing community members for their great contributions last month! trice602poweractivateLaurensMWarrenBelzAmikBCBuizerSamLedcreativeopinion timlExpiscornovusManishSolankiMattJimisonfernandosilvaMisterMarkPstork1saudali_25hafizsultan242Lucas001ragavanrajanp_doc   UPCOMING EVENT: 365 EDUCON CHICAGO Whether you're new to Microsoft 365, Power Platform and SharePoint, or an experienced power user, admin or developer, 365 EduCon has content designed to fit your experience level and area of interest. Their workshops and sessions are taught by Microsoft Certified Trainers, MVPs, Regional Directors, and Engineers. Find out more and register here: Home - Microsoft 365 EduCon Chicago - A Microsoft 365 Conference.  

Announcing the MPPC's Got Power Talent Show at #MPPC23

Are you attending the Microsoft Power Platform Conference 2023 in Las Vegas? If so, we invite you to join us for the MPPC's Got Power Talent Show!      Our talent show is more than a show—it's a grand celebration of connection, inspiration, and shared journeys. Through stories, skills, and collective experiences, we come together to uplift, inspire, and revel in the magic of our community's diverse talents. This year, our talent event promises to be an unforgettable experience, echoing louder and brighter than anything you've seen before.    We're casting a wider net with three captivating categories:  Demo Technical Solutions: Show us your Power Platform innovations, be it apps, flows, chatbots, websites or dashboards... Storytelling: Share tales of your journey with Power Platform. Hidden Talents: Unveil your creative side—be it dancing, singing, rapping, poetry, or comedy. Let your talent shine!    Got That Special Spark? A Story That Demands to Be Heard? Your moment is now!  🚀 Sign up to Showcase Your Brilliance: https://aka.ms/MPPCGotPowerSignUp  🔥 Deadline for submissions: Thursday, Sept 28th    How It Works:  Submit this form to sign up: https://aka.ms/MPPCGotPowerSignUp  We'll contact you if you're selected. Get ready to be onstage!  The Spotlight is Yours: Each participant has 3-5 minutes to shine, with insightful commentary from our panel of judges. We’re not just giving you a stage; we’re handing you the platform to make your mark.     Be the Story We Tell: Your talents and narratives will not just entertain but inspire, serving as the bedrock for our community’s future stories and successes.    Celebration, Surprises, and Connections: As the curtain falls, the excitement continues! Await surprise awards and seize the chance to mingle with industry experts, Microsoft Power Platform leaders, and community luminaries. It's not just a show; it's an opportunity to forge connections and celebrate shared successes.    Event Details:  📆 Date and Time: Wed Oct 4th, 6:30-9:00PM   📍 Location: MPPC23 at the MGM Grand, Las Vegas, NV, USA  

Top Solution Authors
Top Kudoed Authors
Users online (3,705)