cancel
Showing results for 
Search instead for 
Did you mean: 
Reply
marclotorto1
Frequent Visitor

Issue updating a SharePoint list within a gallery using OnChange property

Hello,

 

I am currently building an app for a client that utilizes a gallery and SharePoint Online list to replicate the repeating table functionality of InfoPath/SharePoint 2010. For each item in the table, I am collecting a link (single line text), the name of the link (single line text, also the Title field), the name of a reviewer (people picker), date reviewed (date picker), and a reviewed checkbox (Yes/No).

 

I utilize the OnChange property to update the change to each field on each edit with the Patch function. Example code:

 

OnChange: 

 

 

Patch('Links-Spare Parts', ThisItem,
   {Title: txtSPDocName.Text,
   Link: txtSPDocLink.Text,
   'Person Who Verified': drpSparePartsDocReviewer.Selected,
   'Date Verified': dteSparePartsReviewedDate.SelectedDate,
   ReviewCompleted: chkSparePartsReviewCompleted.Value,
   Section: "Spare Parts"});

 

 

 

The behavior works as expected when updated just the text input fields DocName and Link. But when I update the Reviewer people picker, date selector, or review complete check box, it clears the values in the Reviewer people picker and the date selector. The OnChange property isn't clearing or resetting those fields, just patching to the list. What's weirder is when I just set a label to the Reviewer.Selected.DisplayName, it shows the DisplayName as expected. So the data is there in the people picker, but the name doesn't show from the outside and get's cleared. Any ideas for a fix for this?

 

Some screenshots: 

When searching for name, and then selecting

marclotorto1_1-1638990802267.png

 

After selecting the name - notice it pulls it into the label as selected, but clears the people picker box above

marclotorto1_2-1638990819450.png

 

Same for the date picker

marclotorto1_3-1638990840010.png

 

After selecting the date, the value in the picker clears but it shows that the date is still selected with the label

marclotorto1_2-1638990819450.png

 

Thanks in advance

 

 

1 ACCEPTED SOLUTION

Accepted Solutions
RandyHayes
Super User
Super User

@marclotorto1 

Yes, this is because the Combobox OnChange action that you are using will happen because you are technically changing the selection in the combobox...so it runs your formula...which changes the selection (even though it is the same) and then runs the formula again...and again...and again!

Be cautious with Comboboxes and using the OnChange action as this is one of the few controls that will do what you are seeing.

I would suggest trying to avoid using any of the OnSomething actions in PowerApps except for very basic actions (and there are exceptions to this rule).  But, using those actions is very "program-like" and PowerApps is not a programming platform.  

However, working around this is going to be a combination of design choices and function.  

Typically the design choice is to say that you would have a specific "save" button/icon on each row and it is visible when a value is changed.  The user would then click on that save button/icon to THEN perform the formula you have.

Another option is to perform the saves by a button outside of the gallery to save them all, or have an automatic save running by - when the screen is changed or at specific times.

All design choices.

 

Functionality choices are to determine if the function of automatically saving (and thus producing data actions on every control) is needed.  If not, then consider the design choices above.  If so, then you need to work around the OnChange situation of a combobox.  That can be done with "flag" variables to exclude actions when they are not needed...it's a hassle to deal with though.

 

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

View solution in original post

8 REPLIES 8
RandyHayes
Super User
Super User

@marclotorto1 

I would first change the formula you had to:

UpdateIf('Links-Spare Parts', ID=ThisItem.ID,
   {Title: txtSPDocName.Text,
   Link: txtSPDocLink.Text,
   'Person Who Verified': drpSparePartsDocReviewer.Selected,
   'Date Verified': dteSparePartsReviewedDate.SelectedDate,
   ReviewCompleted: chkSparePartsReviewCompleted.Value,
   Section: "Spare Parts"}
);

This will be more precice in that action.

 

As for the controls and their values after the update...this is going to depend on:

- the Default properties of the checkbox and datepicker

- the DefaultSelectedItems property of the combobox

- the Items property of the combobox

- the Items property of your Gallery.

 

So, if you can fill in those details, perhaps the answer will come from that.

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Thanks for the response Randy. I've updated all patch functions to UpdateIf.

 

My values for the other properties are as follows:

- the Default properties of the checkbox and datepicker - these were blank, I've updated themn to ThisItem.Reviewer and ThisItem.DateReviewed. This eliminated the clearing of the date picker, but the Reviewer picker is still clearing...

 

- the DefaultSelectedItems property of the combobox - this is blank

- the Items property of the combobox - it is Choices([@'Links-Spare Parts'].'Person Who Verified')

- the Items property of your Gallery - this is my SharePoint list filtered where the Parent ID 'Master ID' = the ID of these items, which are set on creation. It's a one to many relationship: Filter('Links-Spare Parts', varRecord.ID = MasterID).

 

I am now getting this error which has been popping up and I can't seem to find much after googling: 

marclotorto1_0-1638992504268.png

 

Any ideas?

 

RandyHayes
Super User
Super User

@marclotorto1 

So the error you are seeing is that there is a conflict in the record.  This means that for some reason the record in the list has changed and you are trying to update with older record information. \

For the combobox, you will need to set the DefaultSelectedItems property.  Based on what I see, it should be ThisItem.'Person Who Verified'

 

 

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Hey Randy,

 

So I updated the DefaultSelectedItems to ThisItem.'Person Who Verified' and it accepted it. However now I am getting a super weird error where I am getting a ton of runtime errors on the OnChange property for the reviewer box - 

marclotorto1_0-1638996815006.png

 

Seems similar to the issue before: 

marclotorto1_1-1638996847479.png

 

These error will flicker and duplicate it anyway from 6-8 times in the OnCheck list. Any ideas? Thanks for your help.

 

marclotorto1
Frequent Visitor

Walked away for about 15 mins and came back and now there's 483 runtime errors... would love some clarity if anyone else has run into this.

marclotorto1_0-1638999809604.png

 

RandyHayes
Super User
Super User

@marclotorto1 

Yes, this is because the Combobox OnChange action that you are using will happen because you are technically changing the selection in the combobox...so it runs your formula...which changes the selection (even though it is the same) and then runs the formula again...and again...and again!

Be cautious with Comboboxes and using the OnChange action as this is one of the few controls that will do what you are seeing.

I would suggest trying to avoid using any of the OnSomething actions in PowerApps except for very basic actions (and there are exceptions to this rule).  But, using those actions is very "program-like" and PowerApps is not a programming platform.  

However, working around this is going to be a combination of design choices and function.  

Typically the design choice is to say that you would have a specific "save" button/icon on each row and it is visible when a value is changed.  The user would then click on that save button/icon to THEN perform the formula you have.

Another option is to perform the saves by a button outside of the gallery to save them all, or have an automatic save running by - when the screen is changed or at specific times.

All design choices.

 

Functionality choices are to determine if the function of automatically saving (and thus producing data actions on every control) is needed.  If not, then consider the design choices above.  If so, then you need to work around the OnChange situation of a combobox.  That can be done with "flag" variables to exclude actions when they are not needed...it's a hassle to deal with though.

 

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Thanks for the indepth response Randy. Will work on this and get back to you. Thanks again.

RandyHayes
Super User
Super User

@marclotorto1 

Happy to help!

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Helpful resources

Announcements

Power Platform Connections Ep 14 | J. Panchal | Thursday, 18 May 2023

Episode Fourteen of Power Platform Connections sees David Warner and Hugo Bernier talk to Microsoft PM Jocelyn Panchal, alongside the latest news, videos, product reviews, and community blogs.   Use the hashtag #PowerPlatformConnects on social media for a chance to have your work featured on the show.      Show schedule in this episode:  00:00 Cold Open 00:32 Show Intro 01:10 Jocelyn Panchal Interview 24:10 Blogs & Articles 29:50 Outro & Bloopers  Check out the blogs and articles featured in this week’s episode:   https://www.nathalieleenders.com/Blog/index.php/;focus=STRATP_com_cm4all_wdn_Flatpress_42136159&path=?x=entry:entry230511-101930#C_STRATP_com_cm4all_wdn_Flatpress_42136159__-anchor  @NathLeenders https://www.keithatherton.com/posts/2023-05-12-msbuild2023-cloud-skills-challenge/  @MrKeithAtherton https://elliskarim.com/2023/05/13/how-to-find-files-in-onedrive-that-match-a-naming-pattern/  @MrCaptainKarim https://www.linkedin.com/pulse/my-fond-memories-scottish-summit-2022-pranav-khurana/ @pranavkhuranauk https://www.linkedin.com/feed/update/urn:li:activity:7061777660745560064/?updateEntityUrn=urn%3Ali%3Afs_feedUpdate%3A%28V2%2Curn%3Ali%3Aactivity%3A7061777660745560064%29  @thevictordantas  Action requested: Feel free to provide feedback on how we can make our community more inclusive and diverse.  This episode premiered live on our YouTube at 12pm PST on Thursday 18th May 2023.  Video series available at Power Platform Community YouTube channel.  Upcoming events:  Power Apps Developers Summit – May 19-20th - London European Power Platform conference – Jun. 20-22nd - Dublin Microsoft Power Platform Conference – Oct. 3-5th - Las Vegas  Join our Communities:  Power Apps Community Power Automate Community Power Virtual Agents Community Power Pages Community  If you’d like to hear from a specific community member in an upcoming recording and/or have specific questions for the Power Platform Connections team, please let us know. We will do our best to address all your requests or questions.   

May 2023 Community Newsletter and Upcoming Events

Welcome to our May 2023 Community Newsletter, where we'll be highlighting the latest news, releases, upcoming events, and the great work of our members inside the Biz Apps communities. If you're new to this LinkedIn group, be sure to subscribe here in the News & Announcements to stay up to date with the latest news from our ever-growing membership network who "changed the way they thought about code".       LATEST NEWS "Mondays at Microsoft" LIVE on LinkedIn - 8am PST - Monday 15th May  - Grab your Monday morning coffee and come join Principal Program Managers Heather Cook and Karuana Gatimu for the premiere episode of "Mondays at Microsoft"! This show will kick off the launch of the new Microsoft Community LinkedIn channel and cover a whole host of hot topics from across the #PowerPlatform, #ModernWork, #Dynamics365, #AI, and everything in-between. Just click the image below to register and come join the team LIVE on Monday 15th May 2023 at 8am PST. Hope to see you there!     Executive Keynote | Microsoft Customer Success Day CVP for Business Applications & Platform, Charles Lamanna, shares the latest #BusinessApplications product enhancements and updates to help customers achieve their business outcomes.     S01E13 Power Platform Connections - 12pm PST - Thursday 11th May Episode Thirteen of Power Platform Connections sees Hugo Bernier take a deep dive into the mind of co-host David Warner II, alongside the reviewing the great work of Dennis Goedegebuure, Keith Atherton, Michael Megel, Cat Schneider, and more. Click below to subscribe and get notified, with David and Hugo LIVE in the YouTube chat from 12pm PST. And use the hashtag #PowerPlatformConnects on social media for a chance to have your work featured on the show.     UPCOMING EVENTS   European Power Platform Conference - early bird ticket sale ends! The European Power Platform Conference early bird ticket sale ends on Friday 12th May 2023! #EPPC23 brings together the Microsoft Power Platform Communities for three days of unrivaled days in-person learning, connections and inspiration, featuring three inspirational keynotes, six expert full-day tutorials, and over eighty-five specialist sessions, with guest speakers including April Dunnam, Dona Sarkar, Ilya Fainberg, Janet Robb, Daniel Laskewitz, Rui Santos, Jens Christian Schrøder, Marco Rocca, and many more. Deep dive into the latest product advancements as you hear from some of the brightest minds in the #PowerApps space. Click here to book your ticket today and save!      DynamicMinds Conference - Slovenia - 22-24th May 2023 It's not long now until the DynamicsMinds Conference, which takes place in Slovenia on 22nd - 24th May, 2023 - where brilliant minds meet, mingle & share! This great Power Platform and Dynamics 365 Conference features a whole host of amazing speakers, including the likes of Georg Glantschnig, Dona Sarkar, Tommy Skaue, Monique Hayward, Aleksandar Totovic, Rachel Profitt, Aurélien CLERE, Ana Inés Urrutia de Souza, Luca Pellegrini, Bostjan Golob, Shannon Mullins, Elena Baeva, Ivan Ficko, Guro Faller, Vivian Voss, Andrew Bibby, Tricia Sinclair, Roger Gilchrist, Sara Lagerquist, Steve Mordue, and many more. Click here: DynamicsMinds Conference for more info on what is sure an amazing community conference covering all aspects of Power Platform and beyond.    Days of Knowledge Conference in Denmark - 1-2nd June 2023 Check out 'Days of Knowledge', a Directions 4 Partners conference on 1st-2nd June in Odense, Denmark, which focuses on educating employees, sharing knowledge and upgrading Business Central professionals. This fantastic two-day conference offers a combination of training sessions and workshops - all with Business Central and related products as the main topic. There's a great list of industry experts sharing their knowledge, including Iona V., Bert Verbeek, Liza Juhlin, Douglas Romão, Carolina Edvinsson, Kim Dalsgaard Christensen, Inga Sartauskaite, Peik Bech-Andersen, Shannon Mullins, James Crowter, Mona Borksted Nielsen, Renato Fajdiga, Vivian Voss, Sven Noomen, Paulien Buskens, Andri Már Helgason, Kayleen Hannigan, Freddy Kristiansen, Signe Agerbo, Luc van Vugt, and many more. If you want to meet industry experts, gain an advantage in the SMB-market, and acquire new knowledge about Microsoft Dynamics Business Central, click here Days of Knowledge Conference in Denmark to buy your ticket today!   COMMUNITY HIGHLIGHTS Check out our top Super and Community Users reaching new levels! These hardworking members are posting, answering questions, kudos, and providing top solutions in their communities.   Power Apps:  Super Users: @WarrenBelz, @LaurensM  @BCBuizer  Community Users:  @Amik@ @mmollet, @Cr1t    Power Automate:  Super Users: @Expiscornovus , @grantjenkins, @abm  Community Users: @Nived_Nambiar, @ManishSolanki    Power Virtual Agents:  Super Users: @Pstork1, @Expiscornovus  Community Users: @JoseA, @fernandosilva, @angerfire1213    Power Pages: Super Users: @ragavanrajan  Community Users: @Fubar, @Madhankumar_L,@gospa  LATEST COMMUNITY BLOG ARTICLES  Power Apps Community Blog  Power Automate Community Blog  Power Virtual Agents Community Blog  Power Pages Community Blog  Check out 'Using the Community' for more helpful tips and information:  Power Apps , Power Automate, Power Virtual Agents, Power Pages 

Microsoft Power Platform Conference | Registration Open | Oct. 3-5 2023

We are so excited to see you for the Microsoft Power Platform Conference in Las Vegas October 3-5 2023! But first, let's take a look back at some fun moments and the best community in tech from MPPC 2022 in Orlando, Florida.   Featuring guest speakers such as Charles Lamanna, Heather Cook, Julie Strauss, Nirav Shah, Ryan Cunningham, Sangya Singh, Stephen Siciliano, Hugo Bernier and many more.   Register today: https://www.powerplatformconf.com/   

Check out the new Power Platform Communities Front Door Experience!

We are excited to share the ‘Power Platform Communities Front Door’ experience with you!   Front Door brings together content from all the Power Platform communities into a single place for our community members, customers and low-code, no-code enthusiasts to learn, share and engage with peers, advocates, community program managers and our product team members. There are a host of features and new capabilities now available on Power Platform Communities Front Door to make content more discoverable for all power product community users which includes ForumsUser GroupsEventsCommunity highlightsCommunity by numbersLinks to all communities Users can see top discussions from across all the Power Platform communities and easily navigate to the latest or trending posts for further interaction. Additionally, they can filter to individual products as well.       Users can filter and browse the user group events from all power platform products with feature parity to existing community user group experience and added filtering capabilities.     Users can now explore user groups on the Power Platform Front Door landing page with capability to view all products in Power Platform.    Explore Power Platform Communities Front Door today. Visit Power Platform Community Front door to easily navigate to the different product communities, view a roll up of user groups, events and forums.

Welcome to the Power Apps Community

Welcome! Congratulations on joining the Microsoft Power Apps community! You are now a part of a vibrant group of peers and industry experts who are here to network, share knowledge, and even have a little fun! Now that you are a member, you can enjoy the following resources:   The Microsoft Power Apps Community Forums If you are looking for support with any part of Microsoft Power Apps, our forums are the place to go. They are titled "Get Help with Microsoft Power Apps " and there you will find thousands of technical professionals with years of experience who are ready and eager to answer your questions. You now have the ability to post, reply and give "kudos" on the Power Apps community forums! Make sure you conduct a quick search before creating a new post because your question may have already been asked and answered!   Microsoft Power Apps IdeasDo you have an idea to improve the Microsoft Power Apps experience, or a feature request for future product updates? Then the "Power Apps Ideas" section is where you can contribute your suggestions and vote for ideas posted by other community members. We constantly look to the most voted Ideas when planning updates, so your suggestions and votes will always make a difference.   Community Blog & NewsOver the years, more than 600 Power Apps Community Blog Articles have been written and published by our thriving community. Our community members have learned some excellent tips and have keen insights on building Power Apps. On the Power Apps Community Blog, read the latest Power Apps related posts from our community blog authors around the world. Let us know if you would like to become an author and contribute your own writing — everything Power Apps related is welcome!   Power Apps Samples, Learning and Videos GalleriesOur galleries have a little bit of everything to do with Power Apps. Our galleries are great for finding inspiration for your next app or component. You can view, comment and kudo the apps and component gallery to see what others have created! Or share Power Apps that you have created with other Power Apps enthusiasts. Along with all of that awesome content, there is the Power Apps Community Video & MBAS gallery where you can watch tutorials and demos by Microsoft staff, partners, and community gurus in our community video gallery.   Again, we are excited to welcome you to the Microsoft Power Apps community family! Whether you are brand new to the world of process automation or you are a seasoned Power Apps veteran. Our goal is to shape the community to be your ‘go to’ for support, networking, education, inspiration and encouragement as we enjoy this adventure together!   Let us know in the Community Feedback if you have any questions or comments about your community experience.To learn more about the community and your account be sure to visit our Community Support Area boards to learn more! We look forward to seeing you in the Power Apps Community!The Power Apps Team

Top Solution Authors
Top Kudoed Authors
Users online (3,071)