cancel
Showing results for 
Search instead for 
Did you mean: 
Reply
marclotorto1
Frequent Visitor

Issue updating a SharePoint list within a gallery using OnChange property

Hello,

 

I am currently building an app for a client that utilizes a gallery and SharePoint Online list to replicate the repeating table functionality of InfoPath/SharePoint 2010. For each item in the table, I am collecting a link (single line text), the name of the link (single line text, also the Title field), the name of a reviewer (people picker), date reviewed (date picker), and a reviewed checkbox (Yes/No).

 

I utilize the OnChange property to update the change to each field on each edit with the Patch function. Example code:

 

OnChange: 

 

 

Patch('Links-Spare Parts', ThisItem,
   {Title: txtSPDocName.Text,
   Link: txtSPDocLink.Text,
   'Person Who Verified': drpSparePartsDocReviewer.Selected,
   'Date Verified': dteSparePartsReviewedDate.SelectedDate,
   ReviewCompleted: chkSparePartsReviewCompleted.Value,
   Section: "Spare Parts"});

 

 

 

The behavior works as expected when updated just the text input fields DocName and Link. But when I update the Reviewer people picker, date selector, or review complete check box, it clears the values in the Reviewer people picker and the date selector. The OnChange property isn't clearing or resetting those fields, just patching to the list. What's weirder is when I just set a label to the Reviewer.Selected.DisplayName, it shows the DisplayName as expected. So the data is there in the people picker, but the name doesn't show from the outside and get's cleared. Any ideas for a fix for this?

 

Some screenshots: 

When searching for name, and then selecting

marclotorto1_1-1638990802267.png

 

After selecting the name - notice it pulls it into the label as selected, but clears the people picker box above

marclotorto1_2-1638990819450.png

 

Same for the date picker

marclotorto1_3-1638990840010.png

 

After selecting the date, the value in the picker clears but it shows that the date is still selected with the label

marclotorto1_2-1638990819450.png

 

Thanks in advance

 

 

1 ACCEPTED SOLUTION

Accepted Solutions
RandyHayes
Super User
Super User

@marclotorto1 

Yes, this is because the Combobox OnChange action that you are using will happen because you are technically changing the selection in the combobox...so it runs your formula...which changes the selection (even though it is the same) and then runs the formula again...and again...and again!

Be cautious with Comboboxes and using the OnChange action as this is one of the few controls that will do what you are seeing.

I would suggest trying to avoid using any of the OnSomething actions in PowerApps except for very basic actions (and there are exceptions to this rule).  But, using those actions is very "program-like" and PowerApps is not a programming platform.  

However, working around this is going to be a combination of design choices and function.  

Typically the design choice is to say that you would have a specific "save" button/icon on each row and it is visible when a value is changed.  The user would then click on that save button/icon to THEN perform the formula you have.

Another option is to perform the saves by a button outside of the gallery to save them all, or have an automatic save running by - when the screen is changed or at specific times.

All design choices.

 

Functionality choices are to determine if the function of automatically saving (and thus producing data actions on every control) is needed.  If not, then consider the design choices above.  If so, then you need to work around the OnChange situation of a combobox.  That can be done with "flag" variables to exclude actions when they are not needed...it's a hassle to deal with though.

 

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

View solution in original post

8 REPLIES 8
RandyHayes
Super User
Super User

@marclotorto1 

I would first change the formula you had to:

UpdateIf('Links-Spare Parts', ID=ThisItem.ID,
   {Title: txtSPDocName.Text,
   Link: txtSPDocLink.Text,
   'Person Who Verified': drpSparePartsDocReviewer.Selected,
   'Date Verified': dteSparePartsReviewedDate.SelectedDate,
   ReviewCompleted: chkSparePartsReviewCompleted.Value,
   Section: "Spare Parts"}
);

This will be more precice in that action.

 

As for the controls and their values after the update...this is going to depend on:

- the Default properties of the checkbox and datepicker

- the DefaultSelectedItems property of the combobox

- the Items property of the combobox

- the Items property of your Gallery.

 

So, if you can fill in those details, perhaps the answer will come from that.

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Thanks for the response Randy. I've updated all patch functions to UpdateIf.

 

My values for the other properties are as follows:

- the Default properties of the checkbox and datepicker - these were blank, I've updated themn to ThisItem.Reviewer and ThisItem.DateReviewed. This eliminated the clearing of the date picker, but the Reviewer picker is still clearing...

 

- the DefaultSelectedItems property of the combobox - this is blank

- the Items property of the combobox - it is Choices([@'Links-Spare Parts'].'Person Who Verified')

- the Items property of your Gallery - this is my SharePoint list filtered where the Parent ID 'Master ID' = the ID of these items, which are set on creation. It's a one to many relationship: Filter('Links-Spare Parts', varRecord.ID = MasterID).

 

I am now getting this error which has been popping up and I can't seem to find much after googling: 

marclotorto1_0-1638992504268.png

 

Any ideas?

 

RandyHayes
Super User
Super User

@marclotorto1 

So the error you are seeing is that there is a conflict in the record.  This means that for some reason the record in the list has changed and you are trying to update with older record information. \

For the combobox, you will need to set the DefaultSelectedItems property.  Based on what I see, it should be ThisItem.'Person Who Verified'

 

 

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Hey Randy,

 

So I updated the DefaultSelectedItems to ThisItem.'Person Who Verified' and it accepted it. However now I am getting a super weird error where I am getting a ton of runtime errors on the OnChange property for the reviewer box - 

marclotorto1_0-1638996815006.png

 

Seems similar to the issue before: 

marclotorto1_1-1638996847479.png

 

These error will flicker and duplicate it anyway from 6-8 times in the OnCheck list. Any ideas? Thanks for your help.

 

marclotorto1
Frequent Visitor

Walked away for about 15 mins and came back and now there's 483 runtime errors... would love some clarity if anyone else has run into this.

marclotorto1_0-1638999809604.png

 

RandyHayes
Super User
Super User

@marclotorto1 

Yes, this is because the Combobox OnChange action that you are using will happen because you are technically changing the selection in the combobox...so it runs your formula...which changes the selection (even though it is the same) and then runs the formula again...and again...and again!

Be cautious with Comboboxes and using the OnChange action as this is one of the few controls that will do what you are seeing.

I would suggest trying to avoid using any of the OnSomething actions in PowerApps except for very basic actions (and there are exceptions to this rule).  But, using those actions is very "program-like" and PowerApps is not a programming platform.  

However, working around this is going to be a combination of design choices and function.  

Typically the design choice is to say that you would have a specific "save" button/icon on each row and it is visible when a value is changed.  The user would then click on that save button/icon to THEN perform the formula you have.

Another option is to perform the saves by a button outside of the gallery to save them all, or have an automatic save running by - when the screen is changed or at specific times.

All design choices.

 

Functionality choices are to determine if the function of automatically saving (and thus producing data actions on every control) is needed.  If not, then consider the design choices above.  If so, then you need to work around the OnChange situation of a combobox.  That can be done with "flag" variables to exclude actions when they are not needed...it's a hassle to deal with though.

 

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Thanks for the indepth response Randy. Will work on this and get back to you. Thanks again.

RandyHayes
Super User
Super User

@marclotorto1 

Happy to help!

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Helpful resources

Announcements

Celebrating the May Super User of the Month: Laurens Martens

  @LaurensM  is an exceptional contributor to the Power Platform Community. Super Users like Laurens inspire others through their example, encouragement, and active participation. We are excited to celebrated Laurens as our Super User of the Month for May 2024.   Consistent Engagement:  He consistently engages with the community by answering forum questions, sharing insights, and providing solutions. Laurens dedication helps other users find answers and overcome challenges.   Community Expertise: As a Super User, Laurens plays a crucial role in maintaining a knowledge sharing environment. Always ensuring a positive experience for everyone.   Leadership: He shares valuable insights on community growth, engagement, and future trends. Their contributions help shape the Power Platform Community.   Congratulations, Laurens Martens, for your outstanding work! Keep inspiring others and making a difference in the community!   Keep up the fantastic work!        

Check out the Copilot Studio Cookbook today!

We are excited to announce our new Copilot Cookbook Gallery in the Copilot Studio Community. We can't wait for you to share your expertise and your experience!    Join us for an amazing opportunity where you'll be one of the first to contribute to the Copilot Cookbook—your ultimate guide to mastering Microsoft Copilot. Whether you're seeking inspiration or grappling with a challenge while crafting apps, you probably already know that Copilot Cookbook is your reliable assistant, offering a wealth of tips and tricks at your fingertips--and we want you to add your expertise. What can you "cook" up?   Click this link to get started: https://aka.ms/CS_Copilot_Cookbook_Gallery   Don't miss out on this exclusive opportunity to be one of the first in the Community to share your app creation journey with Copilot. We'll be announcing a Cookbook Challenge very soon and want to make sure you one of the first "cooks" in the kitchen.   Don't miss your moment--start submitting in the Copilot Cookbook Gallery today!     Thank you,  Engagement Team

Announcing Power Apps Copilot Cookbook Gallery

We are excited to share that the all-new Copilot Cookbook Gallery for Power Apps is now available in the Power Apps Community, full of tips and tricks on how to best use Microsoft Copilot as you develop and create in Power Apps. The new Copilot Cookbook is your go-to resource when you need inspiration--or when you're stuck--and aren't sure how to best partner with Copilot while creating apps.   Whether you're looking for the best prompts or just want to know about responsible AI use, visit Copilot Cookbook for regular updates you can rely on--while also serving up some of your greatest tips and tricks for the Community. Check Out the new Copilot Cookbook for Power Apps today: Copilot Cookbook - Power Platform Community.  We can't wait to see what you "cook" up!      

Tuesday Tip | How to Report Spam in Our Community

It's time for another TUESDAY TIPS, your weekly connection with the most insightful tips and tricks that empower both newcomers and veterans in the Power Platform Community! Every Tuesday, we bring you a curated selection of the finest advice, distilled from the resources and tools in the Community. Whether you’re a seasoned member or just getting started, Tuesday Tips are the perfect compass guiding you across the dynamic landscape of the Power Platform Community.   As our community family expands each week, we revisit our essential tools, tips, and tricks to ensure you’re well-versed in the community’s pulse. Keep an eye on the News & Announcements for your weekly Tuesday Tips—you never know what you may learn!   Today's Tip: How to Report Spam in Our Community We strive to maintain a professional and helpful community, and part of that effort involves keeping our platform free of spam. If you encounter a post that you believe is spam, please follow these steps to report it: Locate the Post: Find the post in question within the community.Kebab Menu: Click on the "Kebab" menu | 3 Dots, on the top right of the post.Report Inappropriate Content: Select "Report Inappropriate Content" from the menu.Submit Report: Fill out any necessary details on the form and submit your report.   Our community team will review the report and take appropriate action to ensure our community remains a valuable resource for everyone.   Thank you for helping us keep the community clean and useful!

Community Roundup: A Look Back at Our Last 10 Tuesday Tips

As we continue to grow and learn together, it's important to reflect on the valuable insights we've shared. For today's #TuesdayTip, we're excited to take a moment to look back at the last 10 tips we've shared in case you missed any or want to revisit them. Thanks for your incredible support for this series--we're so glad it was able to help so many of you navigate your community experience!   Getting Started in the Community An overview of everything you need to know about navigating the community on one page!  Community Links: ○ Power Apps ○ Power Automate  ○ Power Pages  ○ Copilot Studio    Community Ranks and YOU Have you ever wondered how your fellow community members ascend the ranks within our community? We explain everything about ranks and how to achieve points so you can climb up in the rankings! Community Links: ○ Power Apps ○ Power Automate  ○ Power Pages  ○ Copilot Studio    Powering Up Your Community Profile Your Community User Profile is how the Community knows you--so it's essential that it works the way you need it to! From changing your username to updating contact information, this Knowledge Base Article is your best resource for powering up your profile. Community Links: ○ Power Apps ○ Power Automate  ○ Power Pages  ○ Copilot Studio    Community Blogs--A Great Place to Start There's so much you'll discover in the Community Blogs, and we hope you'll check them out today!  Community Links: ○ Power Apps ○ Power Automate  ○ Power Pages  ○ Copilot Studio    Unlocking Community Achievements and Earning Badges Across the Communities, you'll see badges on users profile that recognize and reward their engagement and contributions. Check out some details on Community badges--and find out more in the detailed link at the end of the article! Community Links: ○ Power Apps  ○ Power Automate  ○ Power Pages  ○ Copilot Studio    Blogging in the Community Interested in blogging? Everything you need to know on writing blogs in our four communities! Get started blogging across the Power Platform communities today! Community Links: ○ Power Apps  ○ Power Automate  ○ Power Pages  ○ Copilot Studio   Subscriptions & Notifications We don't want you to miss a thing in the community! Read all about how to subscribe to sections of our forums and how to setup your notifications! Community Links: ○ Power Apps  ○ Power Automate  ○ Power Pages  ○ Copilot Studio   Getting Started with Private Messages & Macros Do you want to enhance your communication in the Community and streamline your interactions? One of the best ways to do this is to ensure you are using Private Messaging--and the ever-handy macros that are available to you as a Community member! Community Links: ○ Power Apps  ○ Power Automate  ○ Power Pages  ○ Copilot Studio   Community User Groups Learn everything about being part of, starting, or leading a User Group in the Power Platform Community. Community Links: ○ Power Apps  ○ Power Automate  ○ Power Pages  ○ Copilot Studio   Update Your Community Profile Today! Keep your community profile up to date which is essential for staying connected and engaged with the community. Community Links: ○ Power Apps  ○ Power Automate  ○ Power Pages  ○ Copilot Studio   Thank you for being an integral part of our journey.   Here's to many more Tuesday Tips as we pave the way for a brighter, more connected future! As always, watch the News & Announcements for the next set of tips, coming soon!

Hear what's next for the Power Up Program

Hear from Principal Program Manager, Dimpi Gandhi, to discover the latest enhancements to the Microsoft #PowerUpProgram, including a new accelerated video-based curriculum crafted with the expertise of Microsoft MVPs, Rory Neary and Charlie Phipps-Bennett. If you’d like to hear what’s coming next, click the link below to sign up today! https://aka.ms/PowerUp  

Top Solution Authors
Top Kudoed Authors
Users online (5,376)