cancel
Showing results for 
Search instead for 
Did you mean: 
Reply
MH3
Post Prodigy
Post Prodigy

Nested If Condition Problem

Hi,

I have this code which is used in the OnScan property of Bar Code Control,  I am actually scanning only those codes which have selected "S" as a Prefix  for Serial Codes.  and "1S" as Prefix selected for Product and Serial Together bar code.

I am using a dropdown called as Prefix Selector

The Condition is working for "1S"  and it's showing popup if the code is scanned again, it will show Duplicate Scanned, and if the different code is scanned it will show a popup >>> Not a 1S Bar Code Type

Issue:  But the code for "S" creating some issues, if the user scans the serial code, it stores and works good, but if the user scans it again it shows both Popups >> Not a Serial Code and Duplicate Scanned at the same time and if the user scans a different code while "S" is selected, it shows popup >>> Not a 1S Bar Code Type (This is not working as expected, what's wrong is in my statements ??)

 

If(ToggleIssue.Value=false && PrefixSelected.Selected.Title = Left(BarcodeScanner2_3.Value,2),


 
// Left(BarCodeScanner2_3.Value,2) is used because if the user has selected ("1S") Prefix, than it will match with it while scanning and store Serial code and Product information.
 
 

If(IsEmpty(Filter('Barcodes - Test',  BarcodeScanner2_3.Value = Title)), 

 
\\ The Above if condition will checks in the Database if there is an entry or not , at first it will return false and then it will patch the data into the databse, and if the scanned code is scannned again it will show a popup to the user as Already Scanned.
 

   Patch('Barcodes - Test',    // Patch Command
   
   Defaults('Barcodes - Test'),

 

   {
   SerialCode:Right(BarcodeScanner2_3.Value,8),
   'Product Code': Mid(BarcodeScanner2_3.Value,3,10),
   Title:BarcodeScanner2_3.Value,
   'Batch No': BatchSelection.Selected.Title,
   ReceiveCheck: ToggleIssue.Value,
   UserName:MyUser,
   ReceivedSatus: "Yet To Receive",
   When:Today() + Time(Hour(Now()), Minute(Now()),Second(Now()))    
   }
),Set(_DuplicateScan,true)),  // Duplicate Popup

 

If(ToggleIssue.Value=false && PrefixSelected.Selected.Title = Left(BarcodeScanner2_3.Value,1),
 
// Left(BarCodeScanner2_3.Value,1) is used because if the user has selected ("S") Prefix, than it will match with it and store only Serial code information.

 

If(IsEmpty(Filter('Barcodes - Test',  BarcodeScanner2_3.Value = Title)), 

 

   Patch('Barcodes - Test',
   
   Defaults('Barcodes - Test'),

 

   {
   SerialCode: Right(BarcodeScanner2_3.Value,8),
   Title:BarcodeScanner2_3.Value,
   'Batch No': BatchSelection.Selected.Title,
   ReceiveCheck: ToggleIssue.Value,
   UserName:MyUser,
   ReceivedSatus: "Yet To Receive",
   When:Today() + Time(Hour(Now()), Minute(Now()),Second(Now()))    
   }

 

),Set(_DuplicateScan,true),
 

Set(_NotSerialCode,true))   // if the user has selected (1S) and if he tries to scan a serial code, or any other code which does not match, it will show a popup, Not a S  Code
 
,Set(_NotISCode,true)))  // if the user has selected (S) and if he tries to scan a serial code, or any other code which does not match, it will show a popup, Not a 1S  Code

 

  I Need Help @WarrenBelz  @v-siky-msft 

39 REPLIES 39

@MH3 

One comma missing!  Please scrub through the formulas I provide as I type them by hand without the aide of a design editor.

If(!ToggleIssue.Value,

    Switch(PrefixSelected.Selected.Title,
        // if the user has selected (1S) and if he tries to scan a serial code, or any other code which does not match, it will show a popup, Not a 1S  Code
        "1S", Set(_NotISCode, !(PrefixSelected.Selected.Title = Left(BarcodeScanner2_3.Value,2))),
        
        // if the user has selected (S) and if he tries to scan a serial code, or any other code which does not match, it will show a popup, Not a S  Code
        "S", Set(_NotSerialCode, !(PrefixSelected.Selected.Title = Left(BarcodeScanner2_3.Value,1))),

        // Is it a duplicate?
        If(!IsEmpty(Filter('Barcodes - Test',  BarcodeScanner2_3.Value = Title)),
            Set(_DuplicateScan, true), // Duplicate Popup
            
            // ELSE - Patch Command
            Patch('Barcodes - Test',    
                Defaults('Barcodes - Test'),
                {
	            SerialCode:Right(BarcodeScanner2_3.Value,8),
	            Title:BarcodeScanner2_3.Value,
	            'Batch No': BatchSelection.Selected.Title,
	            ReceiveCheck: ToggleIssue.Value,
	            UserName:MyUser, 
	            ReceivedSatus: "Yet To Receive",
	            When:Today() + Time(Hour(Now()), Minute(Now()),Second(Now()))    
	        },
	        If(PrefixSelected.Selected.Title="1S",
	            {'Product Code': Mid(BarcodeScanner2_3.Value,3,10)},
	            {}
	        )
            )
        )
    )
)

 

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Dear Sir @RandyHayes ,

 

I have tried to see that but unfortunately, couldn't find that Comma missing issue, but there is still an error, called Record Type required, why you are patching only Product code if it's "1S" Selected?

I actually want to patch all the details as it set for Serial Code "S" and for "1S",  The Difference between them is that, the Product code is in for "1S" and the serial code is trimmed for "1S". differently, I will show you the patch commands:

Patch Columns for "1S"

 Patch('Barcodes - Test',
   
   Defaults('Barcodes - Test'),

   {
   SerialCode:Right(BarcodeScanner2_3.Value,8),
   'Product Code': Mid(BarcodeScanner2_3.Value,3,10),
   Title:BarcodeScanner2_3.Value,
   'Batch No': BatchSelection.Selected.Title,
   ReceiveCheck: ToggleIssue.Value,
   UserName:MyUser,
   ReceivedSatus: "Yet To Receive",
   When:Today() + Time(Hour(Now()), Minute(Now()),Second(Now()))    
   }


Patch Columns for "S"

Patch('Barcodes - Test',
   
   Defaults('Barcodes - Test'),

   {
   SerialCode: Right(BarcodeScanner2_3.Value,8),
   Title:BarcodeScanner2_3.Value,
   'Batch No': BatchSelection.Selected.Title,
   ReceiveCheck: ToggleIssue.Value,
   UserName:MyUser,
   ReceivedSatus: "Yet To Receive",
   When:Today() + Time(Hour(Now()), Minute(Now()),Second(Now()))    
   }



and in your code you have set only product code as the else for "1S".  Need help in this if condition solution. Sorry for disturbing you on one same topic. but I am kinda confused. 


Thanks

@MH3 

The formula I provided patches for both conditions.

The formula should be (this is just a recopy of the last posting - no changes made):

If(!ToggleIssue.Value,

    Switch(PrefixSelected.Selected.Title,
        // if the user has selected (1S) and if he tries to scan a serial code, or any other code which does not match, it will show a popup, Not a 1S  Code
        "1S", Set(_NotISCode, !(PrefixSelected.Selected.Title = Left(BarcodeScanner2_3.Value,2))),
        
        // if the user has selected (S) and if he tries to scan a serial code, or any other code which does not match, it will show a popup, Not a S  Code
        "S", Set(_NotSerialCode, !(PrefixSelected.Selected.Title = Left(BarcodeScanner2_3.Value,1))),

        // Is it a duplicate?
        If(!IsEmpty(Filter('Barcodes - Test',  BarcodeScanner2_3.Value = Title)),
            Set(_DuplicateScan, true), // Duplicate Popup
            
            // ELSE - Patch Command
            Patch('Barcodes - Test',    
                Defaults('Barcodes - Test'),
                {
	            SerialCode:Right(BarcodeScanner2_3.Value,8),
	            Title:BarcodeScanner2_3.Value,
	            'Batch No': BatchSelection.Selected.Title,
	            ReceiveCheck: ToggleIssue.Value,
	            UserName:MyUser, 
	            ReceivedSatus: "Yet To Receive",
	            When:Today() + Time(Hour(Now()), Minute(Now()),Second(Now()))    
	        },
	        If(PrefixSelected.Selected.Title="1S",
	            {'Product Code': Mid(BarcodeScanner2_3.Value,3,10)},
	            {}
	        )
            )
        )
    )
)

 

Where specifically in the formula are you seeing the error?

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Hi @RandyHayes 

The issue is here:
Switch.jpg

But Mr. Randy as I said, there must be two patch statements for "S" and "1S" because the trimming functions are different for both of them, I want to in corporate those two patch commands I sent you earlier in this logic..

 

Hope you understand, that two patch commands will be used one for "S" and another one for "1S"..

@MH3 

Let me review the formula a little closer.  In theory it should be working fine, but I might have overlooked something while hand typing.

As for the two patches...there IS a patch for each type "S" and "1S".  You are not seeing that there is one patch statement, but it has the logic in it to incorporate both into one primary patch. 

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Oh Yes @RandyHayes ,
I am sorry, I haven't looked that the serial code, has the same trimming function for both "S" and "1S", My BAD!!

 

but the code isn't working what's wrong in it?

 

@MH3 

I'm looking into that right now...stay tuned!

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

@MH3 

I see the issue - it's because the if statement is getting mismatched returns.

Change formula to the following:

If(!ToggleIssue.Value,

    Switch(PrefixSelected.Selected.Title,
        // if the user has selected (1S) and if he tries to scan a serial code, or any other code which does not match, it will show a popup, Not a 1S  Code
        "1S", Set(_NotISCode, !(PrefixSelected.Selected.Title = Left(BarcodeScanner2_3.Value,2))),
        
        // if the user has selected (S) and if he tries to scan a serial code, or any other code which does not match, it will show a popup, Not a S  Code
        "S", Set(_NotSerialCode, !(PrefixSelected.Selected.Title = Left(BarcodeScanner2_3.Value,1))),

        // Is it a duplicate?
        If(!IsEmpty(Filter('Barcodes - Test',  BarcodeScanner2_3.Value = Title)),
            Set(_DuplicateScan, true), // Duplicate Popup
            
            // ELSE - Patch Command
            UpdateContext({patchedRecord:
                Patch('Barcodes - Test',    
                    Defaults('Barcodes - Test'),
                    {
                        SerialCode:Right(BarcodeScanner2_3.Value,8),
                        Title:BarcodeScanner2_3.Value,
                        'Batch No': BatchSelection.Selected.Title,
                        ReceiveCheck: ToggleIssue.Value,
                        UserName:MyUser, 
                        ReceivedSatus: "Yet To Receive",
                        When:Today() + Time(Hour(Now()), Minute(Now()),Second(Now()))    
                    },
                    If(PrefixSelected.Selected.Title="1S",
                        {'Product Code': Mid(BarcodeScanner2_3.Value,3,10)},
                        {}
                    )
                })
            )
        )
    )
)
_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Sorry @RandyHayes ,

 

Thanks for your time and effort, the formula shows no error, but I can only check it on Monday!

because right now I don't have any bar codes at home to test out the formula.

 

I will notify you on Monday is that okay? 

Many Thanks, if this formula works as per my expectations, Fingers crossed!!! 

@MH3 

Sounds good.  Let me know.  Have a good weekend.

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Helpful resources

Announcements

Power Platform Connections Ep 15 | L. Baybutt | Thursday, 1 June 2023

Episode Fifteen of Power Platform Connections sees David Warner and Hugo Bernier talk to Microsoft MVP Lewis Baybutt aka Low Code Lewis, alongside the latest news and community blogs.   Use the hashtag #PowerPlatformConnects on social media for a chance to have your work featured on the show.      Action requested: Feel free to provide feedback on how we can make our community more inclusive and diverse.  This episode premiers live on our YouTube at 12pm PST on Thursday 1st June 2023.  Video series available at Power Platform Community YouTube channel.    Upcoming events:  European Power Platform conference – Jun. 20-22nd - Dublin Microsoft Power Platform Conference – Oct. 3-5th - Las Vegas  Join our Communities:  Power Apps Community Power Automate Community Power Virtual Agents Community Power Pages Community  If you’d like to hear from a specific community member in an upcoming recording and/or have specific questions for the Power Platform Connections team, please let us know. We will do our best to address all your requests or questions.   

May 2023 Community Newsletter and Upcoming Events

Welcome to our May 2023 Community Newsletter, where we'll be highlighting the latest news, releases, upcoming events, and the great work of our members inside the Biz Apps communities. If you're new to this LinkedIn group, be sure to subscribe here in the News & Announcements to stay up to date with the latest news from our ever-growing membership network who "changed the way they thought about code".       LATEST NEWS "Mondays at Microsoft" LIVE on LinkedIn - 8am PST - Monday 15th May  - Grab your Monday morning coffee and come join Principal Program Managers Heather Cook and Karuana Gatimu for the premiere episode of "Mondays at Microsoft"! This show will kick off the launch of the new Microsoft Community LinkedIn channel and cover a whole host of hot topics from across the #PowerPlatform, #ModernWork, #Dynamics365, #AI, and everything in-between. Just click the image below to register and come join the team LIVE on Monday 15th May 2023 at 8am PST. Hope to see you there!     Executive Keynote | Microsoft Customer Success Day CVP for Business Applications & Platform, Charles Lamanna, shares the latest #BusinessApplications product enhancements and updates to help customers achieve their business outcomes.     S01E13 Power Platform Connections - 12pm PST - Thursday 11th May Episode Thirteen of Power Platform Connections sees Hugo Bernier take a deep dive into the mind of co-host David Warner II, alongside the reviewing the great work of Dennis Goedegebuure, Keith Atherton, Michael Megel, Cat Schneider, and more. Click below to subscribe and get notified, with David and Hugo LIVE in the YouTube chat from 12pm PST. And use the hashtag #PowerPlatformConnects on social media for a chance to have your work featured on the show.     UPCOMING EVENTS   European Power Platform Conference - early bird ticket sale ends! The European Power Platform Conference early bird ticket sale ends on Friday 12th May 2023! #EPPC23 brings together the Microsoft Power Platform Communities for three days of unrivaled days in-person learning, connections and inspiration, featuring three inspirational keynotes, six expert full-day tutorials, and over eighty-five specialist sessions, with guest speakers including April Dunnam, Dona Sarkar, Ilya Fainberg, Janet Robb, Daniel Laskewitz, Rui Santos, Jens Christian Schrøder, Marco Rocca, and many more. Deep dive into the latest product advancements as you hear from some of the brightest minds in the #PowerApps space. Click here to book your ticket today and save!      DynamicMinds Conference - Slovenia - 22-24th May 2023 It's not long now until the DynamicsMinds Conference, which takes place in Slovenia on 22nd - 24th May, 2023 - where brilliant minds meet, mingle & share! This great Power Platform and Dynamics 365 Conference features a whole host of amazing speakers, including the likes of Georg Glantschnig, Dona Sarkar, Tommy Skaue, Monique Hayward, Aleksandar Totovic, Rachel Profitt, Aurélien CLERE, Ana Inés Urrutia de Souza, Luca Pellegrini, Bostjan Golob, Shannon Mullins, Elena Baeva, Ivan Ficko, Guro Faller, Vivian Voss, Andrew Bibby, Tricia Sinclair, Roger Gilchrist, Sara Lagerquist, Steve Mordue, and many more. Click here: DynamicsMinds Conference for more info on what is sure an amazing community conference covering all aspects of Power Platform and beyond.    Days of Knowledge Conference in Denmark - 1-2nd June 2023 Check out 'Days of Knowledge', a Directions 4 Partners conference on 1st-2nd June in Odense, Denmark, which focuses on educating employees, sharing knowledge and upgrading Business Central professionals. This fantastic two-day conference offers a combination of training sessions and workshops - all with Business Central and related products as the main topic. There's a great list of industry experts sharing their knowledge, including Iona V., Bert Verbeek, Liza Juhlin, Douglas Romão, Carolina Edvinsson, Kim Dalsgaard Christensen, Inga Sartauskaite, Peik Bech-Andersen, Shannon Mullins, James Crowter, Mona Borksted Nielsen, Renato Fajdiga, Vivian Voss, Sven Noomen, Paulien Buskens, Andri Már Helgason, Kayleen Hannigan, Freddy Kristiansen, Signe Agerbo, Luc van Vugt, and many more. If you want to meet industry experts, gain an advantage in the SMB-market, and acquire new knowledge about Microsoft Dynamics Business Central, click here Days of Knowledge Conference in Denmark to buy your ticket today!   COMMUNITY HIGHLIGHTS Check out our top Super and Community Users reaching new levels! These hardworking members are posting, answering questions, kudos, and providing top solutions in their communities.   Power Apps:  Super Users: @WarrenBelz, @LaurensM  @BCBuizer  Community Users:  @Amik@ @mmollet, @Cr1t    Power Automate:  Super Users: @Expiscornovus , @grantjenkins, @abm  Community Users: @Nived_Nambiar, @ManishSolanki    Power Virtual Agents:  Super Users: @Pstork1, @Expiscornovus  Community Users: @JoseA, @fernandosilva, @angerfire1213    Power Pages: Super Users: @ragavanrajan  Community Users: @Fubar, @Madhankumar_L,@gospa  LATEST COMMUNITY BLOG ARTICLES  Power Apps Community Blog  Power Automate Community Blog  Power Virtual Agents Community Blog  Power Pages Community Blog  Check out 'Using the Community' for more helpful tips and information:  Power Apps , Power Automate, Power Virtual Agents, Power Pages 

Microsoft Power Platform Conference | Registration Open | Oct. 3-5 2023

We are so excited to see you for the Microsoft Power Platform Conference in Las Vegas October 3-5 2023! But first, let's take a look back at some fun moments and the best community in tech from MPPC 2022 in Orlando, Florida.   Featuring guest speakers such as Charles Lamanna, Heather Cook, Julie Strauss, Nirav Shah, Ryan Cunningham, Sangya Singh, Stephen Siciliano, Hugo Bernier and many more.   Register today: https://www.powerplatformconf.com/   

Check out the new Power Platform Communities Front Door Experience!

We are excited to share the ‘Power Platform Communities Front Door’ experience with you!   Front Door brings together content from all the Power Platform communities into a single place for our community members, customers and low-code, no-code enthusiasts to learn, share and engage with peers, advocates, community program managers and our product team members. There are a host of features and new capabilities now available on Power Platform Communities Front Door to make content more discoverable for all power product community users which includes ForumsUser GroupsEventsCommunity highlightsCommunity by numbersLinks to all communities Users can see top discussions from across all the Power Platform communities and easily navigate to the latest or trending posts for further interaction. Additionally, they can filter to individual products as well.       Users can filter and browse the user group events from all power platform products with feature parity to existing community user group experience and added filtering capabilities.     Users can now explore user groups on the Power Platform Front Door landing page with capability to view all products in Power Platform.    Explore Power Platform Communities Front Door today. Visit Power Platform Community Front door to easily navigate to the different product communities, view a roll up of user groups, events and forums.

Welcome to the Power Apps Community

Welcome! Congratulations on joining the Microsoft Power Apps community! You are now a part of a vibrant group of peers and industry experts who are here to network, share knowledge, and even have a little fun! Now that you are a member, you can enjoy the following resources:   The Microsoft Power Apps Community Forums If you are looking for support with any part of Microsoft Power Apps, our forums are the place to go. They are titled "Get Help with Microsoft Power Apps " and there you will find thousands of technical professionals with years of experience who are ready and eager to answer your questions. You now have the ability to post, reply and give "kudos" on the Power Apps community forums! Make sure you conduct a quick search before creating a new post because your question may have already been asked and answered!   Microsoft Power Apps IdeasDo you have an idea to improve the Microsoft Power Apps experience, or a feature request for future product updates? Then the "Power Apps Ideas" section is where you can contribute your suggestions and vote for ideas posted by other community members. We constantly look to the most voted Ideas when planning updates, so your suggestions and votes will always make a difference.   Community Blog & NewsOver the years, more than 600 Power Apps Community Blog Articles have been written and published by our thriving community. Our community members have learned some excellent tips and have keen insights on building Power Apps. On the Power Apps Community Blog, read the latest Power Apps related posts from our community blog authors around the world. Let us know if you would like to become an author and contribute your own writing — everything Power Apps related is welcome!   Power Apps Samples, Learning and Videos GalleriesOur galleries have a little bit of everything to do with Power Apps. Our galleries are great for finding inspiration for your next app or component. You can view, comment and kudo the apps and component gallery to see what others have created! Or share Power Apps that you have created with other Power Apps enthusiasts. Along with all of that awesome content, there is the Power Apps Community Video & MBAS gallery where you can watch tutorials and demos by Microsoft staff, partners, and community gurus in our community video gallery.   Again, we are excited to welcome you to the Microsoft Power Apps community family! Whether you are brand new to the world of process automation or you are a seasoned Power Apps veteran. Our goal is to shape the community to be your ‘go to’ for support, networking, education, inspiration and encouragement as we enjoy this adventure together!   Let us know in the Community Feedback if you have any questions or comments about your community experience.To learn more about the community and your account be sure to visit our Community Support Area boards to learn more! We look forward to seeing you in the Power Apps Community!The Power Apps Team

Top Solution Authors
Top Kudoed Authors
Users online (3,999)