cancel
Showing results for 
Search instead for 
Did you mean: 
Reply
Madhatter72
Helper I
Helper I

Not Patching One Value

Hi All,

 

I am not getting any errors, but my Patch function is not patching just one value - "RPL", all other values are patching just fine. I am using a data source where there are multiple RREWs, user selects one, and their project list filters. The selected project only has one RPL. This should work in reverse, if a project is selected from the Radio, then they can select the RREW; however, there is still only one RPL. Any ideas would be a great help! Here is the patch code:

 

If(Radio1.Selected.Value="RREW" Or Radio1.Selected.Value="Project",
ClearCollect(RFMs, LookUp('Project Data','Related RREW' = RREWInput.Selected.Result)),
ClearCollect(RPLs, LookUp('Project Data','Related RREW' = ProjectInput.SelectedText.Value)));
Patch('Poor Load Quality',
Defaults('Poor Load Quality'),
{
Title: ProjectInput.SelectedText.Value,
Date: Now(),
RREW: RREWInput.Selected.Result,
Director: If(Radio1.Selected.Value="RREW" Or Radio1.Selected.Value="Project",First(RFMs).'Director Name'),
RFM: If(Radio1.Selected.Value="RREW" Or Radio1.Selected.Value="Project",First(RFMs).'RREW Manager'),
RPL: If(Radio1.Selected.Value="Project" Or Radio1.Selected.Value="RREW",First(RPLs).'RPL Name'),
ReportingUser: AutoUserName.Text,
Description: ActualSelection.Text,
Rating: ConditionSelection.Selected.Result
}
)

1 ACCEPTED SOLUTION

Accepted Solutions
WarrenBelz
Most Valuable Professional
Most Valuable Professional

@Madhatter72 ,

That is because you keep putting in the extra bracket, removing the email from the With() Variables (please use the code I provided). You have

         ReportingUser: AutoUserName.Text,
         Description: ActualSelection.Text,
         Rating: ConditionSelection.Selected.Result
      }
   )
);
Office365Outlook.SendEmailV2(
   If(

instead of 

         ReportingUser: AutoUserName.Text,
         Description: ActualSelection.Text,
         Rating: ConditionSelection.Selected.Result
      }
   );
   Office365Outlook.SendEmailV2(
      If(

You will then need to remove a bracket at the bottom (before the reset)

SelectedText will soon not be valid - you need to use Selected. I am assuming ProjectInput is a drop-down or a Combo Box. Please provide a screenshot of where you are getting the error.

I have run the code using values of the same types on my Test list and it is valid providing your values also are. 

 

Please click Accept as solution if my post helped you solve your issue. This will help others find it more readily. It also closes the item. If the content was useful in other ways, please consider giving it Thumbs Up.

Visit my blog Practical Power Apps

View solution in original post

18 REPLIES 18
WarrenBelz
Most Valuable Professional
Most Valuable Professional

Hi @Madhatter72 ,

I might have this wrong, but if 'Director Name', 'RREW Manager' and 'RFL Name' are all Single Lines of Text on 'Project Data', you do not need First() - also see if the below works (saves Collections "hanging around")

With(
   {
      wSel:
      Radio1.Selected.Value="RREW" || Radio1.Selected.Value="Project",
      wRFMs: 
      LookUp(
         'Project Data',
         'Related RREW' = RREWInput.Selected.Result
      ),
      wRPLs:
      LookUp(
         'Project Data',
         'Related RREW' = ProjectInput.Selected.Value
      )
   },
   Patch(
      'Poor Load Quality',
      Defaults('Poor Load Quality'),
      {
         Title: ProjectInput.SelectedText.Value,
         Date: Now(),
         RREW: RREWInput.Selected.Result,
         Director: 
         If(
            wSel,
            wRFMs.'Director Name'
         ),
         RFM: 
         If(
            wSel,
            wRFMs.'RREW Manager'
         ),
         RPL: 
         If(
            wSel,
            wRPLs.'RPL Name'
         ),
         ReportingUser: AutoUserName.Text,
         Description: ActualSelection.Text,
         Rating: ConditionSelection.Selected.Result
      }
   )
)

 

Please click Accept as solution if my post helped you solve your issue. This will help others find it more readily. It also closes the item. If the content was useful in other ways, please consider giving it Thumbs Up.

Visit my blog Practical Power Apps

Madhatter72
Helper I
Helper I

@WarrenBelz I am receiving an error "Name isn't valid. 'Related RREW' isn't recognized". This error is in the wRPLs Lookup. I tried changing to 'Related RREW' = ProjectInput.SelectedText.Value, but it didn't work.

WarrenBelz
Most Valuable Professional
Most Valuable Professional

@Madhatter72 ,

Typo (now fixed - I thought you might have picked that one up)

@WarrenBelz, I am very much a noob, but learning! I appreciate your help, that worked. It did throw off the remainder of my code, I'm assuming because I'm still using First:

 

Office365Outlook.SendEmailV2(
If(
Radio1.Selected.Value="RREW",
Concatenate(
First(RFMs).'RREW Manager Email', ";" , First(RFMs).'RREW Dom Email', ";", UserEmailVar, ";"
),
Concatenate(
UserEmailVar, ";", First(RPLs).'RPL Email', ";"
)
),
"Load Quality Audit for " & ProjectInput.SelectedText.Value & " on " & Now(),
"Hi Team,<br><br>" & " on " & Now() & " your load was audited for " & ProjectInput.SelectedText.Value & ". Your load was rated as " & ConditionSelection.Selected.Result & ". The following reasons were listed to explain the rating: <br><br>" & ActualSelection.Text & "<br><br>" &
"Please see photos attached.",
{Importance:"High", Attachments:LoadImages}
);
Reset(ProjectInput);
Clear(LoadImages);
Reset(CommentInput);
Reset(ConditionSelection);
Reset(DescriptionSelection);
Clear(LoadDescription);
Reset(Radio1);
Navigate(WelcomScreen)

WarrenBelz
Most Valuable Professional
Most Valuable Professional

Hi @Madhatter72

You can go back to the collections or simply do this

With(
   {
      wRFMs: 
      LookUp(
         'Project Data',
         'Related RREW' = RREWInput.Selected.Result
      ),
      wRPLs:
      LookUp(
         'Project Data',
         'Related RREW' = ProjectInput.Selected.Value
      ),
      wNow: Text(Now(),"dddd, d mmmm yyyy")
   },
   Office365Outlook.SendEmailV2(
      If(
         Radio1.Selected.Value = "RREW",
         wRFMs.'RREW Manager Email' & ";" & wRFMs.'RREW Dom Email' & ";" & UserEmailVar,
         UserEmailVar & ";" & wRPLs.'RPL Email'
      ),
      "Load Quality Audit for " & ProjectInput.Selected.Value & " on " & wNow,
      "Hi Team,<br><br>" & " on " & wNow & " your load was audited for " & ProjectInput.Selected.Value & 
      ". Your load was rated as " & ConditionSelection.Selected.Result & 
      ". The following reasons were listed to explain the rating: <br><br>" & ActualSelection.Text & "<br><br>" &
      "Please see photos attached.",
      {
         Importance: "High", 
         Attachments: LoadImages
      }
   )
);
Reset(ProjectInput);
Clear(LoadImages);
Reset(CommentInput);
Reset(ConditionSelection);
Reset(DescriptionSelection);
Clear(LoadDescription);
Reset(Radio1);
Navigate(WelcomScreen)

Note that SelectedText is deprecated - you need to use Selected.

 

Please click Accept as solution if my post helped you solve your issue. This will help others find it more readily. It also closes the item. If the content was useful in other ways, please consider giving it Thumbs Up.

Visit my blog Practical Power Apps

I think we are getting very close, but looks like there are some still some errors - Unexpected characters, the formula contains 'Error' where 'ParenClose is expected... where 'CurlyClose' is expected and Characters are used in the formula in an unexpected way.

WarrenBelz
Most Valuable Professional
Most Valuable Professional

@Madhatter72 ,

Dangers of free-typing text - just missing quotes (now fixed)

@WarrenBelz, when I put it all together, the patch gives an error, "the function 'If' has some invalid arguments, Name isn't valid. 'wSel' isn't recognized.

 

With(
{
wRFMs:
LookUp(
'Project Data',
'Related RREW' = RREWInput.Selected.Result
),
wRPLs:
LookUp(
'Project Data',
'Related RREW' = ProjectInput.SelectedText.Value
),
wNow: Text(Now(),"dddd, d mmmm yyyy")
},
Patch(
'Poor Load Quality',
Defaults('Poor Load Quality'),
{
Title: ProjectInput.SelectedText.Value,
Date: Now(),
RREW: RREWInput.Selected.Result,
Director:
If(
wSel,
wRFMs.'Director Name'
),
RFM:
If(
wSel,
wRFMs.'RREW Manager'
),
RPL:
If(
wSel,
wRPLs.'RPL Name'
),
ReportingUser: AutoUserName.Text,
Description: ActualSelection.Text,
Rating: ConditionSelection.Selected.Result
}
)
),
Office365Outlook.SendEmailV2(
If(
Radio1.Selected.Value = "RREW",
wRFMs.'RREW Manager Email' & ";" & wRFMs.'RREW Dom Email' & ";" & UserEmailVar,
UserEmailVar & ";" & wRPLs.'RPL Email'
),
"Load Quality Audit for " & ProjectInput.SelectedText.Value & " on " & wNow,
"Hi Team,<br><br>" & " on " & wNow & " your load was audited for " & ProjectInput.SelectedText.Value &
". Your load was rated as " & ConditionSelection.Selected.Result &
". The following reasons were listed to explain the rating: <br><br>" & ActualSelection.Text & "<br><br>" &
"Please see photos attached.",
{
Importance: "High",
Attachments: LoadImages
}
)
);
Reset(ProjectInput);
Clear(LoadImages);
Reset(CommentInput);
Reset(ConditionSelection);
Reset(DescriptionSelection);
Clear(LoadDescription);
Reset(Radio1);
Navigate(WelcomScreen)

WarrenBelz
Most Valuable Professional
Most Valuable Professional

@Madhatter72 ,

Why are you using First() when it is a Text value from a Record (or is it not)? Also you left out the Boolean wSel and then referred to it at the bottom (that is the error you are seeing). As well there are some brackets at the bottom wrong. Please note SelectedText is deprecated and Selected should be use.

With(
   {
      wSel: Radio1.Selected.Value="RREW" || Radio1.Selected.Value="Project",
      wRFMs:
      LookUp(
         'Project Data',
         'Related RREW' = RREWInput.Selected.Result
      ),
      wRPLs:
      LookUp(
         'Project Data',
         'Related RREW' = ProjectInput.Selected.Value
      ),
      wNow: Text(Now(),"dddd, d mmmm yyyy"),
      wProject: ProjectInput.Selected.Value
   },
   Patch(
      'Poor Load Quality',
      Defaults('Poor Load Quality'),
      {
         Title: wProject,
         Date: Now(),
         RREW: RREWInput.Selected.Result,
         Director:
         If(
            wSel,
            wRFMs.'Director Name'
         ),
         RFM:
         If(
            wSel,
            wRFMs.'RREW Manager'
         ),
         RPL:
         If(
            wSel,   
            wRPLs.'RPL Name'
         ),
         ReportingUser: AutoUserName.Text,
         Description: ActualSelection.Text,
         Rating: ConditionSelection.Selected.Result
      }
   );
   Office365Outlook.SendEmailV2(
      If(
         Radio1.Selected.Value = "RREW",
         wRFMs.'RREW Manager Email' & ";" & wRFMs.'RREW Dom Email' & ";" & UserEmailVar,
         UserEmailVar & ";" & wRPLs.'RPL Email'
      ),
      "Load Quality Audit for " & wProject & " on " & wNow,
      "Hi Team,<br><br>" & " on " & wNow & " your load was audited for " & wProject &
      ". Your load was rated as " & ConditionSelection.Selected.Result &
      ". The following reasons were listed to explain the rating: <br><br>" & ActualSelection.Text & "<br><br>" &
      "Please see photos attached.",
      {
         Importance: "High",
         Attachments: LoadImages
      }
   )
);
Reset(ProjectInput);
Clear(LoadImages);
Reset(CommentInput);
Reset(ConditionSelection);
Reset(DescriptionSelection);
Clear(LoadDescription);
Reset(Radio1);
Navigate(WelcomScreen)

Please take a moment to understand what this code is doing and you will find it a lot easier to relate the components to their function.

 

Please click Accept as solution if my post helped you solve your issue. This will help others find it more readily. It also closes the item. If the content was useful in other ways, please consider giving it Thumbs Up.

Visit my blog Practical Power Apps

Helpful resources

Announcements

Celebrating the May Super User of the Month: Laurens Martens

  @LaurensM  is an exceptional contributor to the Power Platform Community. Super Users like Laurens inspire others through their example, encouragement, and active participation. We are excited to celebrated Laurens as our Super User of the Month for May 2024.   Consistent Engagement:  He consistently engages with the community by answering forum questions, sharing insights, and providing solutions. Laurens dedication helps other users find answers and overcome challenges.   Community Expertise: As a Super User, Laurens plays a crucial role in maintaining a knowledge sharing environment. Always ensuring a positive experience for everyone.   Leadership: He shares valuable insights on community growth, engagement, and future trends. Their contributions help shape the Power Platform Community.   Congratulations, Laurens Martens, for your outstanding work! Keep inspiring others and making a difference in the community!   Keep up the fantastic work!        

Check out the Copilot Studio Cookbook today!

We are excited to announce our new Copilot Cookbook Gallery in the Copilot Studio Community. We can't wait for you to share your expertise and your experience!    Join us for an amazing opportunity where you'll be one of the first to contribute to the Copilot Cookbook—your ultimate guide to mastering Microsoft Copilot. Whether you're seeking inspiration or grappling with a challenge while crafting apps, you probably already know that Copilot Cookbook is your reliable assistant, offering a wealth of tips and tricks at your fingertips--and we want you to add your expertise. What can you "cook" up?   Click this link to get started: https://aka.ms/CS_Copilot_Cookbook_Gallery   Don't miss out on this exclusive opportunity to be one of the first in the Community to share your app creation journey with Copilot. We'll be announcing a Cookbook Challenge very soon and want to make sure you one of the first "cooks" in the kitchen.   Don't miss your moment--start submitting in the Copilot Cookbook Gallery today!     Thank you,  Engagement Team

Announcing Power Apps Copilot Cookbook Gallery

We are excited to share that the all-new Copilot Cookbook Gallery for Power Apps is now available in the Power Apps Community, full of tips and tricks on how to best use Microsoft Copilot as you develop and create in Power Apps. The new Copilot Cookbook is your go-to resource when you need inspiration--or when you're stuck--and aren't sure how to best partner with Copilot while creating apps.   Whether you're looking for the best prompts or just want to know about responsible AI use, visit Copilot Cookbook for regular updates you can rely on--while also serving up some of your greatest tips and tricks for the Community. Check Out the new Copilot Cookbook for Power Apps today: Copilot Cookbook - Power Platform Community.  We can't wait to see what you "cook" up!      

Tuesday Tip | How to Report Spam in Our Community

It's time for another TUESDAY TIPS, your weekly connection with the most insightful tips and tricks that empower both newcomers and veterans in the Power Platform Community! Every Tuesday, we bring you a curated selection of the finest advice, distilled from the resources and tools in the Community. Whether you’re a seasoned member or just getting started, Tuesday Tips are the perfect compass guiding you across the dynamic landscape of the Power Platform Community.   As our community family expands each week, we revisit our essential tools, tips, and tricks to ensure you’re well-versed in the community’s pulse. Keep an eye on the News & Announcements for your weekly Tuesday Tips—you never know what you may learn!   Today's Tip: How to Report Spam in Our Community We strive to maintain a professional and helpful community, and part of that effort involves keeping our platform free of spam. If you encounter a post that you believe is spam, please follow these steps to report it: Locate the Post: Find the post in question within the community.Kebab Menu: Click on the "Kebab" menu | 3 Dots, on the top right of the post.Report Inappropriate Content: Select "Report Inappropriate Content" from the menu.Submit Report: Fill out any necessary details on the form and submit your report.   Our community team will review the report and take appropriate action to ensure our community remains a valuable resource for everyone.   Thank you for helping us keep the community clean and useful!

Community Roundup: A Look Back at Our Last 10 Tuesday Tips

As we continue to grow and learn together, it's important to reflect on the valuable insights we've shared. For today's #TuesdayTip, we're excited to take a moment to look back at the last 10 tips we've shared in case you missed any or want to revisit them. Thanks for your incredible support for this series--we're so glad it was able to help so many of you navigate your community experience!   Getting Started in the Community An overview of everything you need to know about navigating the community on one page!  Community Links: ○ Power Apps ○ Power Automate  ○ Power Pages  ○ Copilot Studio    Community Ranks and YOU Have you ever wondered how your fellow community members ascend the ranks within our community? We explain everything about ranks and how to achieve points so you can climb up in the rankings! Community Links: ○ Power Apps ○ Power Automate  ○ Power Pages  ○ Copilot Studio    Powering Up Your Community Profile Your Community User Profile is how the Community knows you--so it's essential that it works the way you need it to! From changing your username to updating contact information, this Knowledge Base Article is your best resource for powering up your profile. Community Links: ○ Power Apps ○ Power Automate  ○ Power Pages  ○ Copilot Studio    Community Blogs--A Great Place to Start There's so much you'll discover in the Community Blogs, and we hope you'll check them out today!  Community Links: ○ Power Apps ○ Power Automate  ○ Power Pages  ○ Copilot Studio    Unlocking Community Achievements and Earning Badges Across the Communities, you'll see badges on users profile that recognize and reward their engagement and contributions. Check out some details on Community badges--and find out more in the detailed link at the end of the article! Community Links: ○ Power Apps  ○ Power Automate  ○ Power Pages  ○ Copilot Studio    Blogging in the Community Interested in blogging? Everything you need to know on writing blogs in our four communities! Get started blogging across the Power Platform communities today! Community Links: ○ Power Apps  ○ Power Automate  ○ Power Pages  ○ Copilot Studio   Subscriptions & Notifications We don't want you to miss a thing in the community! Read all about how to subscribe to sections of our forums and how to setup your notifications! Community Links: ○ Power Apps  ○ Power Automate  ○ Power Pages  ○ Copilot Studio   Getting Started with Private Messages & Macros Do you want to enhance your communication in the Community and streamline your interactions? One of the best ways to do this is to ensure you are using Private Messaging--and the ever-handy macros that are available to you as a Community member! Community Links: ○ Power Apps  ○ Power Automate  ○ Power Pages  ○ Copilot Studio   Community User Groups Learn everything about being part of, starting, or leading a User Group in the Power Platform Community. Community Links: ○ Power Apps  ○ Power Automate  ○ Power Pages  ○ Copilot Studio   Update Your Community Profile Today! Keep your community profile up to date which is essential for staying connected and engaged with the community. Community Links: ○ Power Apps  ○ Power Automate  ○ Power Pages  ○ Copilot Studio   Thank you for being an integral part of our journey.   Here's to many more Tuesday Tips as we pave the way for a brighter, more connected future! As always, watch the News & Announcements for the next set of tips, coming soon!

Hear what's next for the Power Up Program

Hear from Principal Program Manager, Dimpi Gandhi, to discover the latest enhancements to the Microsoft #PowerUpProgram, including a new accelerated video-based curriculum crafted with the expertise of Microsoft MVPs, Rory Neary and Charlie Phipps-Bennett. If you’d like to hear what’s coming next, click the link below to sign up today! https://aka.ms/PowerUp  

Top Solution Authors
Top Kudoed Authors
Users online (5,066)