cancel
Showing results for 
Search instead for 
Did you mean: 
Reply
subsguts
Continued Contributor
Continued Contributor

Patch doesn't work on same data source in a row

Hello, need some help:

 

See the code below:

Facts:

1.  They both do a change to two different records on the same data source.

2.  Both statements work independently 

 

Question: The first Patch works and the second one doesn't.  If I reverse the order of the patch statements then the first one works and the second one doesn't.  I can't get both Patch statements to work.  

 

Note:  This code operates when the user pushes a button

IMPORTANT:  This code does not cause an error.  It runs if the patches are in either order, but it is only updating the data source 1 time, with the update that is in the first path.

 

Thank you!!!

 

//Update date of last status change
Patch(
FeeRequestTracking,
Last(
Filter(
FeeRequestTracking,
RequestID = RequestGallery.Selected.ID && 'End Status' = StartStatus
)
),
{EndStatusChanged: Now()}
);

//Update tracking information
Patch(
FeeRequestTracking,
Defaults(FeeRequestTracking),
{RequestID: RequestGallery.Selected.ID},
{'Begin Status': StartStatus},
{'End Status': EndStatus},
{ReviewerComments: txtReviewerComments.HtmlText}//Store comment in original Fee Request and in Tracking. Future updates should be recorded in FeeRequestTracking.
);

2 ACCEPTED SOLUTIONS

Accepted Solutions

Hi @subsguts ,

Hidden button or icon would both work, although it makes no sense to me why it does not work in the first place. Place a Notify at the end of your original code as below (this is only a debugging exercise) and see if you get a message with the ID of the new record (or any message).

With(
   {
      wID:
      LookUp(
         Sort(
            FeeRequestTracking,
            ID,
            Descending
         ),
         RequestID = RequestGallery.Selected.ID && 
         'End Status' = StartStatus
      ).ID
   },
   Patch(
      FeeRequestTracking,
      {ID: wID},
      {EndStatusChanged: Now()}
   )
);
Set(
   gblTestID,
   Patch(
      FeeRequestTracking,
      Defaults(FeeRequestTracking),
      {
         RequestID: RequestGallery.Selected.ID,
         'Begin Status': StartStatus,
         'End Status': EndStatus,
         ReviewerComments: txtReviewerComments.HtmlText
      }
   ).ID
);
Notify(
   "Your Patched ID is " & gblTestID,
   Success
)

 

View solution in original post

@subsguts ,

OK - if it gave an ID, there should be a record there. Have you refreshed SharePoint (directly in SharePoint), created a view sorted by ID descending and see if the record is there ?

View solution in original post

10 REPLIES 10
WarrenBelz
Super User
Super User

Hi @subsguts ,

Other than being more specific on the update, it should work

With(
   {
      wID:
      LookUp(
         Sort(
            FeeRequestTracking,
            ID,
            Descending
         ),
         RequestID = RequestGallery.Selected.ID && 
         'End Status' = StartStatus
      ).ID
   },
   Patch(
      FeeRequestTracking,
      {ID: wID},
      {EndStatusChanged: Now()}
   )
);
Patch(
   FeeRequestTracking,
   Defaults(FeeRequestTracking),
   {
      RequestID: RequestGallery.Selected.ID,
      'Begin Status': StartStatus,
      'End Status': EndStatus,
      ReviewerComments: txtReviewerComments.HtmlText
   }
);

You also should do the update first to ensure the new record just written does not become the update.

 

Please click Accept as solution if my post helped you solve your issue. This will help others find it more readily. It also closes the item. If the content was useful in other ways, please consider giving it Thumbs Up.

Visit my blog Practical Power Apps

 

subsguts
Continued Contributor
Continued Contributor

Thanks for your reply.

 

Unfortunately, this code change, like the original only executes the first Patch.  The new record is never created and only the update is performed.

If you have any other suggestions that would be great!

The only way I've been able to get this to work (albeit a kludge in my opinion), is to take the Patch that does the update and move it to a button.  Then I do a Select(button).  I do grab the ID needed.  Here is the kludgy code in case it helps you suggest another way to make it work in the same place, which I would greatly appreciated as this below is definitely not "good programming".

Change to Code in original button pressed by the user:

Set(varTrackID,Last(Filter(FeeRequestTracking,RequestID=RequestGallery.Selected.ID && 'End Status'=StartStatus)).ID);

Select(btnUpdatesFeeTrackingDate);


//Update tracking information
Patch(
FeeRequestTracking,
Defaults(FeeRequestTracking),
{RequestID: RequestGallery.Selected.ID},
{'Begin Status': StartStatus},
{'End Status': EndStatus},
{ReviewerComments: txtReviewerComments.HtmlText}//Store comment in original Fee Request and in Tracking. Future updates should be recorded in FeeRequestTracking.
);

 

Button OnSelect Code:

//Update tracking information by adding the EndStatusChagne timestamp on the last change of status before the current one
Patch(
FeeRequestTracking,
{ID:varTrackID},
{EndStatusChanged: Now()}
);

 

Hi @subsguts ,

Hidden button or icon would both work, although it makes no sense to me why it does not work in the first place. Place a Notify at the end of your original code as below (this is only a debugging exercise) and see if you get a message with the ID of the new record (or any message).

With(
   {
      wID:
      LookUp(
         Sort(
            FeeRequestTracking,
            ID,
            Descending
         ),
         RequestID = RequestGallery.Selected.ID && 
         'End Status' = StartStatus
      ).ID
   },
   Patch(
      FeeRequestTracking,
      {ID: wID},
      {EndStatusChanged: Now()}
   )
);
Set(
   gblTestID,
   Patch(
      FeeRequestTracking,
      Defaults(FeeRequestTracking),
      {
         RequestID: RequestGallery.Selected.ID,
         'Begin Status': StartStatus,
         'End Status': EndStatus,
         ReviewerComments: txtReviewerComments.HtmlText
      }
   ).ID
);
Notify(
   "Your Patched ID is " & gblTestID,
   Success
)

 

subsguts
Continued Contributor
Continued Contributor

Thanks, I will try this and let you know.

 

BTW, the btn worked for a while and now has stopped.  I am totally 100% CONFUSED as it makes no sense why this functionality doesn't work.  It's almost like it needs time to process the one patch before it does the second and that it gets confused hitting the same SP list at the same time and doesn't like that.

 

Anyway, I'll try to debug with what you've sent and see if that leads to any solutions and report back my finding.

 

subsguts
Continued Contributor
Continued Contributor

I tried it.  It did give me a message with an ID in it.  However, it did not created the new record. 

I think this has to be a timing issue.  

 

The reason I think this is because if I take one of the Patch statements out and put it on a button and manually push it after this code runs it works.  It's like I need some time in between the two patch statements.

 

Any thoughts with this additional info? 

 

Thanks for sticking with me on this... I think this is a tough one and maybe a PowerApps Bug.

subsguts
Continued Contributor
Continued Contributor

Just to retest, I commented out the first patch as follows and it DOES create the new record.  So something in the first one is keeping the second from successfully creating the record... as strange as this is and makes no sense to me.

 

Any ideas?

 

/*
With(
{
wID:
LookUp(
Sort(
FeeRequestTracking,
ID,
Descending
),
RequestID = RequestGallery.Selected.ID &&
'End Status' = StartStatus
).ID
},
Patch(
FeeRequestTracking,
{ID: wID},
{EndStatusChanged: Now()}
)
);*/
Set(
gblTestID,
Patch(
FeeRequestTracking,
Defaults(FeeRequestTracking),
{
RequestID: RequestGallery.Selected.ID,
'Begin Status': StartStatus,
'End Status': EndStatus,
ReviewerComments: txtReviewerComments.HtmlText
}
).ID
);
Notify(
"Your Patched ID is " & gblTestID,
Success
);

@subsguts ,

OK - if it gave an ID, there should be a record there. Have you refreshed SharePoint (directly in SharePoint), created a view sorted by ID descending and see if the record is there ?

subsguts
Continued Contributor
Continued Contributor

Thanks for the pointer.  Using your logic, I put in a Lookup after the store of the record and got a the record id in the table.  When I went to that record the RequestID field was blank.  I expected that to be populated, so somehow that field is getting cleared.  I'm working through this, but brain is fried.  So will attempt again in the morning.   You've been a BIG Help.  While I don't have the solution, I'm marking this as solved as not it appears to not be PATCH issue, but more with the data being passed issue, which is something only I can solve.

 

I will post an update on this though to either confirm or deny that the two patch statements can work side by side.

 

The best part of this solution for folks reading is the Debugging part.  I didn't know about this and it is really very very valuable.  

 

Thanks!!!

subsguts
Continued Contributor
Continued Contributor

Just to close this out.  The issue was that a the RequestGallerySelected.ID was become blank due to some refreshes of the gallery that were happening as other variable were also change that affected it's display.  Therefore the solution was to store this in a variable and use it instead of referencing the Gallery directly.  I know it's a best practice by some to store this in the OnSelect of the Gallery.  So this is one place where that would have eliminated this issue.  Thanks again for the help.

Helpful resources

Announcements
Power Apps News & Annoucements carousel

Power Apps News & Announcements

Keep up to date with current events and community announcements in the Power Apps community.

Community Call Conversations

Introducing the Community Calls Conversations

A great place where you can stay up to date with community calls and interact with the speakers.

Power Apps Community Blog Carousel

Power Apps Community Blog

Check out the latest Community Blog from the community!

Top Solution Authors
Top Kudoed Authors
Users online (3,975)