Solved: Re: Update or create new item from Collection to S...

TWolsten · ‎04-06-2020

Hi all,

I am trying to use a Collection (Proposed) that I submit into a Gallery (Gallery1) as a 'basket'.

Then I want to submit all items into a SharePoint List (bp_proposed) and where items are brand new (Gallery1.Selected.New_x0020_Item_x003f_ = "Yes") it creates a new line, otherwise, it just makes amendments to an existing item.

The formula I have right now is on a button:

ForAll(Gallery1.AllItems, Patch(bp_proposed, If(Gallery1.Selected.New_x0020_Item_x003f_ = "Yes", Proposed, ID = ID, Proposed)))

It adds new items just fine but keeps saying the following on existing items:

"The list item could not be added or updated because duplicate values were found in the following field(s) in the list [BPID]"

I am confused as surely it should be picking up a duplicate value exists as that is what I am trying to overwrite with the new data???

Any help would be much appreciated.

WarrenBelz · ‎04-07-2020

Hi @TWolsten ,

I use something similar with new record selecting crew from a gallery based on a collection and then writing back to a SharePoint List. There will be other views on this, but I tend to keep code simple rather than trying to wrap multiple functions inside each other (also MUCH easier to debug), so firstly the new records. The reference to the collection Proposed is actually not needed as the data required is contained in the gallery and the ForAll on a gallery may be ambiguous if referring to something else. So for the new records, try this (works for me when all columns in the gallery line up [name, type] with a field in the List).

ClearCollect(
   colNew,
   DropColumns(
      Filter(
         ChooseGallery.AllItems,
         New_x0020_Item_x003f_ = "Yes",
      ),
      "ID"
   )
);
Collect(
   bp_proposed,
   colNew
);
Clear(colNew)

Now the existing items

ForAll(
   RenameColumns(
      Filter(
         ChooseGallery.AllItems,
         New_x0020_Item_x003f_ = "No"
      ),
      "ID",
      "IDRef"
   ),
   UpdateIf(
      bp_proposed,
      ID = IDRef,
      {
         Field1Name:Field1Name,
         Field2Name:Field2Name,
         Field3Name:Field3Name   //and so on for the rest
      }
   )
)

Please give all this a go and see how it works for you.

Please click Accept as solution if my post helped you solve your issue. This will help others find it more readily. It also closes the item. If the content was useful in other ways, please consider giving it Thumbs Up.

View solution in original post

WarrenBelz · ‎04-06-2020

Hi @TWolsten ,

I am thinking that is because you have the ID in the collection and you are trying to patch it back as a new record, into a field that insists on unique values.

I have tried DropColumns, but could not get it not quite right - the below should work if your current configuration does (I do it a bit differently) with an additional column IDRef in the data source.

ForAll(
   RenameColumns(
      Gallery1.AllItems,
      "ID",
      "IDRef"
   ), 
   Patch(
      bp_proposed, 
      If(
         Gallery1.Selected.New_x0020_Item_x003f_ = "Yes", 
         Proposed, 
         ID = IDRef, 
         Proposed
      )
   )
)

Please click Accept as solution if my post helped you solve your issue. This will help others find it more readily. It also closes the item. If the content was useful in other ways, please consider giving it Thumbs Up.

TWolsten · ‎04-07-2020

Thank you for the response @WarrenBelz

So even more confusing ID is not valid and states:

"Name not valid. This identifier is not recognised"

Any ideas why this would be?

ForAll(
RenameColumns(
Gallery1.AllItems,
"ID",
"IDRef"
),
Patch(
bp_proposed,
If(
Gallery1.Selected.New_x0020_Item_x003f_ = "Yes",
Proposed,
ID = IDRef,
Proposed
)
)
)

WarrenBelz · ‎04-07-2020

Hi @TWolsten ,

Firstly, did you add the column IDRef as a number format in bp_proposed as suggested?

WarrenBelz · ‎04-07-2020

Hi @TWolsten,

UPDATE

I cannot test this, but firstly give this a try and if no go, I will head a slightly different direction.

ForAll(
     RenameColumns(
     Gallery1.AllItems,
      "ID",
      "IDRef"
   ),
   Patch(
      AddColumns(
         bp_proposed,
	     "IDRef",
	     0
      ),
      If(
         Gallery1.Selected.New_x0020_Item_x003f_ = "Yes",
         Proposed,
         ID = IDRef,
         Proposed
      )
   )
)

TWolsten · ‎04-07-2020

@WarrenBelz - annoyingly it still isn't recognising ID????

WarrenBelz · ‎04-07-2020

OK @TWolsten ,

bp_proposed is a collection - can you please do a View > Collections and see what is in the ID.

Also - what is Proposed?

TWolsten · ‎04-07-2020

@WarrenBelz - so you have hit the nail on the head. The ID doesn't exist in my Collection?

However, I have tried it with my backup Unique ID (Title) which is in the Collection and it still doesn't recognise it? (photo attached)

bp_proposed = SharePoint List

Proposed = Collection

Basically I have a Form (DataSource is Proposed i.e. a Collection) so when I submit the Form it goes into a Gallery (Gallery1) as a basket.

If the item from the Form is brand new then I want it to be submitted into the SharePoint List as a new line.

If the item from the Form already exists in the SharePoint List (via the unique columns of ID or Title) then it overwrites the changes

Thank you for all the help so far @WarrenBelz

WarrenBelz · ‎04-07-2020

Ok @TWolsten ,

To date, I have been "flying blind" trying to fix bits on the basis that the rest of the code worked for you.

So back to basics - this should not be hard to get a result.

You have a collection bp_proposed that you need to update
You have a Gallery Gallery1 that has a field New_x0020_Item_x003f_ which can be marked as Yes or (assume) No.
If Yes, then a new record has to be written from a collection Proposed to the collection bp_proposed based on the content of Gallery1 that is marked Yes. (I think there is a fundamental flaw here).
If NOT Yes, bp_proposed has to be updated with the content of Proposed where the ID of Proposed matches the ID of bp_proposed , again based on the records in Gallery1.

So a few questions

What is the Collect code for both Proposed and bp_proposed
Do Proposed, bp_proposed and Gallery1 all have the same fields?
Anything else you can tell me that may be useful.

Due to time zone, I will be offline shortly (10:00pm here), but will get this sorted for you.

TWolsten · ‎04-07-2020

You are an absolute star! Thank you for all your help.

You have a ~~collection~~ SharePoint List bp_proposed that you need to update
You have a Gallery Gallery1 that has a field New_x0020_Item_x003f_ which can be marked as Yes or (assume) No. -Correct
If Yes, then a new record has to be written from a collection Proposed to the ~~collection~~ SharePoint List bp_proposed based on the content of Gallery1 that is marked Yes. (I think there is a fundamental flaw here).
If NOT Yes, bp_proposed has to be updated with the content of Proposed where the ID of Proposed matches the ID of bp_proposed , again based on the records in Gallery1. - Correct

So a few questions

What is the Collect code for both Proposed and bp_proposed
1. There is a DataTable which holds the bp_proposed results based on a search bar.
2. By selecting one item in the DataTable the Form is populated.
3. The user then fills out the Form and clicks the button which Collects Proposed using SubmitForm(Form)
Do Proposed, bp_proposed and Gallery1 all have the same fields?
- Yes as bp_proposed is the master, Proposed is created from bp_proposed and Gallery1 just displays Proposed
Anything else you can tell me that may be useful.
- I think that covers off all the variables?