cancel
Showing results for 
Search instead for 
Did you mean: 
Reply
MNik
Helper I
Helper I

Using both form and gallery to create new rows in sharepoint

I am trying to create a form that a user can select multiple values on the same form, then when rows are created in Sharepoint, a new row is created for value, with the form data captured on each row.  

 

I have everything working as intended, however, I am having issues getting the data loaded in Sharepoint.  The error is telling me that a "Title" is required.  I suspect that I have my ForAll and Patch function incorrectly written and that it might not be capturing the form data.  

 

Here is what I have.  Any suggestions on how I can fix it?

 

MNik_0-1665168348629.png

 

Many thanks in advance!

1 ACCEPTED SOLUTION

Accepted Solutions
RandyHayes
Super User
Super User

@MNik 

Yes, it is HIGHLY unfortunate that almost all people doing videos and blogs completely misunderstand how the ForAll function works!  This is because someone long ago figured it was like a For Loop and found they could "kind of" make it work that way...and thus the misunderstanding proliferated!

Even the Docs have put some of this bad advice in them.  It is really a shame because the ForAll function is one of the most powerful Data Shaping functions in PowerApps...and with PowerApps, it is all about data shaping!

 

 

So, for your submit button...it should ONLY be:

SubmitForm('Contact Info');

Never put anything after that as you have only issued a "submit".  This happens in the background.  The app does not wait for it to finish.  Plus, you have no idea right after it if it submitted without any error.

This is what the OnSuccess and the OnFailure actions on the form are designed for.

 

So, your OnSuccess action of the 'Contact Info' form should be where you put the Patch and ForAll table.

And it should be:

Patch('Internal Aftersales Part Request',
    ForAll(Requested,
        {
            'Part Number Requested': Col_PartNumberRequested_Column4,
            'Quantity Needed': Col_Qty_Column2
        }
    )
)

It is the Requested that you want to iterate over on the ForAll and it is the 'Internal Aftersales Part Request' that you want to patch...not the other way around that you had in your response.

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

View solution in original post

9 REPLIES 9
RandyHayes
Super User
Super User

@MNik 

To start, your formula has the ForAll backward. You are trying to use it like a ForLoop in some development language - which PowerApps is not.  ForAll is a function that returns a table of records based on your iteration table and record schema.

It is more efficient to use the function as intended and will provide better performance.

 

Next, if you have a form, then you should be using the SubmitForm function to submit your actual form.  If you need additional records created, this should be done in the OnSuccess action of the form.

 

Next, you are referencing Controls in your formula and not properties of those controls.  So, for example, if NameInput is a text input, then you should be referencing NameInput.Text for the proper values.

 

Finally, and in regard to the second point above...when in your OnSuccess action formula, you can reference Self.LastSumbit.<columnName> to get the values you want that were part of the form.

You should never reference the controls in the form after any submitting as they are not guaranteed to be the same at that point.  But, Self.LastSumbit will always contain the last record submitted in full.

 

So just to provide an example.  Your formula would look more like this:

Patch('Internal Aftersales Part Request',
    ForAll(Requested,
        {Title: Self.LastSubmit.Title, 
         Timestamp: Self.LastSubmit.Timestamp,
         ...etc...
        }
    )
)

 

Not sure what "Requested" is in your formula, but I am assuming that is a table of records.

 

I hope this is helpful for you.

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Hi Randy, 

 

First off, thank you for your help.  My apologies as I am new to PowerApps, but I think I am a little bit lost now.  I had watched a few YouTube videos and they showed writing the ForALL/Patch function as I had it above. 

 

The 'Requested' is a collection that I created to capture the requested part numbers and qtys in the gallery.  The form name is 'Contact Info'

 

So for my submit button, I should be using the SubmitForm('Contact Info') command, correct?

 

Then when it comes to submitting the gallery with the form, I tried re-writing using your provided Patch/ForAll command but I wasn't able to get it to work.  Here is a a picture of my app, and hopefully a clearer description of what I am trying to do.  

 

MNik_0-1665412865879.png

 

The red box is the form created from my SP list, the blue box is the gallery attached to the 'Requested" collection that I made to allow for multiple selections if necessary, and the green are fields from the SP list that are not attached to the form but are placed to allow for the selection entry in the gallery.  

 

What I am trying to do is have the the app write a new entry to the sharepoint list for each selection in the gallery like this

contact info + first part/qty selected

contact info + second part/qty selected

contact info + third part/qty selected

 

Here is how my submit button OnSelect function is currently written.  I am currently getting an error stating the data source supplied to the function is invalid.

 

 

SubmitForm('Contact Info');
Patch(
    Requested,
    ForAll(
        'Internal Aftersales Part Request',
        {
            'Part Number Requested': Col_PartNumberRequested_Column4,
            'Quantity Needed': Col_Qty_Column2
        }
    )
)

 

 

 

RandyHayes
Super User
Super User

@MNik 

Yes, it is HIGHLY unfortunate that almost all people doing videos and blogs completely misunderstand how the ForAll function works!  This is because someone long ago figured it was like a For Loop and found they could "kind of" make it work that way...and thus the misunderstanding proliferated!

Even the Docs have put some of this bad advice in them.  It is really a shame because the ForAll function is one of the most powerful Data Shaping functions in PowerApps...and with PowerApps, it is all about data shaping!

 

 

So, for your submit button...it should ONLY be:

SubmitForm('Contact Info');

Never put anything after that as you have only issued a "submit".  This happens in the background.  The app does not wait for it to finish.  Plus, you have no idea right after it if it submitted without any error.

This is what the OnSuccess and the OnFailure actions on the form are designed for.

 

So, your OnSuccess action of the 'Contact Info' form should be where you put the Patch and ForAll table.

And it should be:

Patch('Internal Aftersales Part Request',
    ForAll(Requested,
        {
            'Part Number Requested': Col_PartNumberRequested_Column4,
            'Quantity Needed': Col_Qty_Column2
        }
    )
)

It is the Requested that you want to iterate over on the ForAll and it is the 'Internal Aftersales Part Request' that you want to patch...not the other way around that you had in your response.

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Thank you for that explanation.  

 

Upon pressing the submit button I am getting the first row to write in SP, but it is not writing in the Part Number Requested or Quantity Requested fields.  

 

I am also receiving a runtime error that Title field is required.  I believe that the error is happening for the subsequent rows after the first row. 

I was able to get the part number and qty's to write to the sharepoint list.  It is creating new lines for each part/qty, however, it is creating the part/qty below the line where the form data is written.  Is it possible to have all of the data written on each line?

 

MNik_0-1665519261708.png

 

RandyHayes
Super User
Super User

@MNik 

So what is your formula at this point?

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Nevermind the last request, the project lead likes the way it is currently formatted in SP. 

 

Randy, thank you for your help.  It is always much appreciated! 

RandyHayes
Super User
Super User

@MNik 

No problem!  Happy to help!

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Hi Randy, 

 

Circling back around on this one.  The project lead would like to have the form data written to each line with each collection item.  Currently OnSuccess action for the form is written like this:

 

Patch(
    'Internal Parts Request Tracker',
    ForAll(
        Requested,
        {
            'Part Number Requested': col_PartNumberRequested.Number,
            'Quantity Needed': col_Qty.Text
        }
    )
);
Navigate('Success Screen')


Here is the OnSelect button that I am using to add pn's and qty's to my collection:

 

Collect(
    Requested,
    {
        col_PartNumberRequested: cmb_PartNumber.Selected,
        col_Qty: txt_Qty
    }
)

 

Would I need to adjust my collect function to include the items from the form and have it all write to the SharePoint list?

Helpful resources

Announcements

Super User of the Month | Drew Poggemann

As part of a new monthly feature in the Community, we are excited to share that Drew Poggemann is our featured Super User for the month of February 2024. If you've been in the Community for a while, we're sure Drew's name is familiar to you, as he is one of our most active contributors--he's been a Super User for five consecutive seasons!   Since authoring his first reply 5 years ago to his 514th solution authored, Drew has helped countless Community members with his insights and expertise. In addition to being a Super User, Drew is also a User Group leader and a Microsoft MVP. His contributions to our Super User sessions and to the new SUIT program are always welcome--as well as his sense of humor and fun-loving way of sharing what he knows with others.   When Drew is not solving problems and authoring solutions, he's busy overseeing the Solution Architecture team at HBS, specializing in application architecture and business solution strategy--something he's been doing for over 30 years. We are grateful for Drew and the amazing way he has used his talent and skills to help so many others in the Community. If you are part of the SUIT program, you got to hear some great tips from Drew at the first SUIT session--and we know he still has much more to share!You can find him in the Community and on LinkedIn. Thank you for all you do, Drew!

Announcing Power Apps Copilot Cookbook Gallery

We are excited to share that the all-new Copilot Cookbook Gallery for Power Apps is now available in the Power Apps Community, full of tips and tricks on how to best use Microsoft Copilot as you develop and create in Power Apps. The new Copilot Cookbook is your go-to resource when you need inspiration--or when you're stuck--and aren't sure how to best partner with Copilot while creating apps.   Whether you're looking for the best prompts or just want to know about responsible AI use, visit Copilot Cookbook for regular updates you can rely on--while also serving up some of your greatest tips and tricks for the Community. Our team will be reviewing posts using the new "Copilot Studio" label to ensure we highlight and amplify the most relevant and recent content, so you're assured of high-quality content every time you visit. If you share a post that gets featured in the curated gallery, you'll get a PM in the Community to let you know!The curated gallery is ready for you to experience now, so visit the new Copilot Cookbook for Power Apps today: Copilot Cookbook - Power Platform Community. We can't wait to see what you "cook" up!      

Celebrating a New Season of Super Users with Charles Lamanna, CVP Microsoft Business Applications

February 8 was the kickoff to the 2024 Season One Super User program for Power Platform Communities, and we are thrilled to welcome back so many returning Super Users--as well as so many brand new Super Users who started their journey last fall. Our Community Super Users are the true heroes, answering questions, providing solutions, filtering spam, and so much more. The impact they make on the Communities each day is significant, and we wanted to do something special to welcome them at our first kickoff meeting of the year.   Charles Lamanna, Microsoft CVP of Business Applications, has stressed frequently how valuable our Community is to the growth and potential of Power Platform, and we are honored to share this message from him to our 2024 Season One Super Users--as well as anyone who might be interested in joining this elite group of Community members.     If you want to know more about Super Users, check out these posts for more information today:    Power Apps: What is A Super User? - Power Platform CommunityPower Automate: What is A Super User? - Power Platform Community Copilot Studio: What is A Super User? - Power Platform Community Power Pages: What is A Super User? - Power Platform Community

February 2024 User Group Update: Welcoming New Groups and Highlighting Upcoming Events

It's a new month and a brand-new year, which means another opportunity to celebrate our amazing User Groups!Each month, we highlight the new User Groups that have joined the community. It's been a busy season for new groups, because we are thrilled to welcome 15 New User Groups! Take a look at the list below, shared by the different community categories. If your group is listed here, give this post a kudo so we can celebrate with you!   We love our User Groups and the difference they make in the lives of our Community! Thank you to all the new User Groups, new User Group leaders--we look forward to hearing about your successes and the impact you will leave!   In addition to our monthly New User Group spotlight, it's a great time to share some of the latest events happening in our User Group community! Take a look at the list below to find one that fits your schedule and need! There's a great combination of in-person and virtual events to choose from. It's a great time of year to connect and engage with User Groups both locally and online. Please Welcome Our NEW User Groups   Power Platform: Heathcare Power Platform User Group Power Platform Connect Hub Power Platform Usergroup Denmark Mexico Norte- Power Platform User Group Pune Power User Group Sudbury Power Platform User GroupMicrosoft User Group GhanaMPPBLR - Microsoft Power Platform Bengaluru User Group Power Apps:   Myrtle Beach Power Platform User GroupAnanseTechWB PowerApps Copilot Studio: Pathfinders Power Platform Community Dynamics365: Cairo, Egypt MSD 365 Business Central/NAV/F&O User GruopMS Dynamics 365 Business Central LatamCincinnati OH D365 F&O User Group February User Group Events February 2024 Cleveland Power Platform User GroupPortallunsj - Februar 2024Indiana D365/AX February User Group MeetingQ1 2024 KC Power Platform and Dynamics 365 CRM Users Group 

Super Users 2024 Season One is Here!

   We are excited to announce the first season of our 2024 Super Users is here! Our kickoff to the new year welcomes many returning Super Users and several new faces, and it's always exciting to see the impact these incredible individuals will have on the Community in 2024! We are so grateful for the daily difference they make in the Community already and know they will keep staying engaged and excited for all that will happen this year.   How to Spot a Super User in the Community:Have you ever written a post or asked for help in the Community and had it answered by a user with the Super User icon next to their name? It means you have found the actual, real-life superheroes of the Power Platform Community! Super Users are our heroes because of the way they consistently make a difference in the Community. Our amazing Super Users help keep the Community a safe place by flagging spam and letting the Community Managers know about issues. They also make the Community a great place to find answers, because they are often the first to offer solutions and get clarity on questions. Finally, Super Users share valuable insights on ways to keep the Community growing, engaging, and looking ahead!We are honored to reveal the new badges for this season of Super Users! Congratulations to all the new and returning Super Users!     To better answer the question "What is a Super User?" please check out this article: Power Apps: What is A Super User? - Power Platform CommunityPower Automate: What is A Super User? - Power Platform Community Copilot Studio: What is A Super User? - Power Platform Community Power Pages: What is A Super User? - Power Platform Community

Did You Attend the Microsoft Power Platform Conference in 2022 or 2023? Claim Your Badge Today!

If you were one of the thousands of people who joined us at the first #MPPC Microsoft Power Platform Conference in 2022 in Orlando--or attended the second-annual conference in Las Vegas in 2023--we are excited to honor you with a special community badge! Show your support for #MPPC Microsoft Power Platform Conference this year by claiming your badge!         Just follow this link to claim your badge for attending #MPPC in 2022 and/or 2023: MPPCBadgeRequest    Want to earn your badge for 2024? Just keep watching our News & Announcements for the latest updates on #MPPC24.

Top Solution Authors
Top Kudoed Authors
Users online (3,288)