cancel
Showing results for 
Search instead for 
Did you mean: 
Reply
Wapfunz
Level: Powered On

Patch : Multiple screens to one record SharePoint - update brings error in fx.

Hi,

 

I am getting this error message:

Patch(source,record,update,....)

update:The update that needs to be patched to the given record

 

emphasis on the update.

 

 

I have:

Patch(GeneralHSEAudit_Mobile,MyRecord,{Title:EditScreen1.Title.text,ConductedOn:EditScreen1.ConductedOn.Value,PreparedBy:EditScreen1.PreparedBy.Text,PreferredName:EditScreen1.PreferredName.Text:Location:EditScreen1.Text,Personnel:EditScreen1.Text,’1.1_Reviewed’:EditScreen1.’1.1_Reviewed’.Value,’1.2_Outstanding’:EditScreen1.’1.2_Oustanding’.value,‘1.3_AllSite’:EditScreen1.’1.3_AllSite’.value,‘1.4_Comments’:EditScreen1.’1.4_Comments’.text,’2.1_Plan’:EditScreen1.’2.1_Plan’.value,’2.2_Trial’:EditScreen1.’2.2_Trial’.value,..................’16.7_OtherSeats’:EditScreen6.’16.7_OtherSeats’.value,’16.8_WindScreen’:EditScreen6.’16.8_WindScreen’.value,’16.9_Vehicles’:EditScreen6.’16.9_Vehicles’.value,’16.10_Storage’:EditScreen6.’16.10_Storage’.value,’16.11_Comments’:EditScreen6.’16.11_Comments’.text})

 

Is not the update between the { } ?

 

Dang this is a TAD not clear.

 

 

1 ACCEPTED SOLUTION

Accepted Solutions
RandyHayes
Level 10

Re: Patch : Multiple screens to one record SharePoint - update brings error in fx.

Okay, so it looks like my assumption of the problem statement is correct. Let's start with that!

 

My advice is to jump back when you run into a head scratcher. You might find a better way.

 

So, I will offer a quick - here's a better way:  

1) I don't know what your starting point is.  Typically these things come from some Gallery or other "selected" item.  So, I'm going to assume a Gallery (Gallery1).  I know you mention you have a MyRecord you set, but you might not even need that if you are coming off of a Gallery.  If this is not the case, then substitute the "selected" items below with your MyRecord.

 

2) Since you are working with EditForm Controls, what you can simply do is this - 

For each of the 6 forms, set the dataSource to the proper dataSource (you most likely have this already - GeneralHSEAudit_Mobile)

Set the Item property to Gallery1.Selected

 

3) On the Check mark Icon you have on the final screen, add this to the OnSelect action:

   SubmitForm(EditForm1); SubmitForm(EditForm2); SubmitForm(EditForm3); SubmitForm(EditForm4); SubmitForm(EditForm5); SubmitForm(EditForm6)

 

Done!

 

If you still want to take the Patch path, then Patch(GeneralHSEAudit_Mobile, MyRecord, EditForm1.Updates, EditForm2.Updates, EditForm3.Updates, EditForm4.Updates, EditForm5.Updates, EditForm6.Updates)

 

 

See if any of this makes sense and works for you.

12 REPLIES 12
Wapfunz
Level: Powered On

Re: Patch : Multiple screens to one record SharePoint - update brings error in fx.

Update - I removed the { } and still get the same result.

What I have are 6 screens in edit mode for one record to update / Patch.

Why six screens? - 160  radio buttons need  that many screens to resolve/render - otherwise the download for one screen that shows them all is a no go.

 

It is the last screen - EditScreen6 that contains the update button.

 

What am I doing wrong????

Community Support Team
Community Support Team

Re: Patch : Multiple screens to one record SharePoint - update brings error in fx.

Hi @Wapfunz,

Could you please share more details about the error message with your formula?

Do you add each Edit form control within your 6 Edit screens?

Are these ConductedOnPreparedBy, ... all controls within your EditScreen1?

If the ConductedOnPreparedBy, ... all controls within your EditScreen1, and the EditScreen1, EditScreen2, ...EditScreen6 are all Edit Screens in your app, based on the formula that you mentioned, I think there is something wrong with it.

Please take a try to modify your formula as below:

Patch(
GeneralHSEAudit_Mobile,
MyRecord,
{
Title: Title.Text, /* <-- Please replace EditScreen1.Title.Text with Title.Text, in other words, remove all 'EditScreen1', 'EditScreen2', ..., 'EditScreen6' prefix */
ConductedOn: ConductedOn.Value,
PreparedBy: PreparedBy.Text,
PreferredName: PreferredName.Text,
...
'2.2_Trial': '2.2_Trial'.value,
...
'16.7_OtherSeats': '16.7_OtherSeats'.value,
'16.8_WindScreen': '16.8_WindScreen'.value,
'16.9_Vehicles': '16.9_Vehicles'.value,
...
}
)

In addition, please also make sure the TitleConductedOnPreparedBy, PreferredName, ... etc properties you specified within the '{ }' are all existed within the Record (MyRecord) you want to update. Also please check if you have provided valid values for the corresponding properties within the '{ }' body.

The standard Patch formula to update one record within a data source as below:

Patch(
         'YourDataSource',
          RecordYouWantToUpdate,  /* <-- Find the record you want to update using LookUp function or Filter and First function*/
          {
            Column1: "xxxx",
            Column2: "xxxx",
            Column3: "xxxx",
            ....
          }
)

More details about the Patch function, please check the following article:

Patch function

 

Best regards,

Community Support Team _ Kris Dai
If this post helps, then please consider Accept it as the solution to help the other members find it more quickly.
Wapfunz
Level: Powered On

Re: Patch : Multiple screens to one record SharePoint - update brings error in fx.

Thanks,

 

Do you add each Edit form control within your 6 Edit screens? - Yes I do

Are these ConductedOnPreparedBy, ... all controls within your EditScreen1? - yes these are on EditScreen1.

EditScreen1 contains conducted on thru to 5.6

EditScreen2 from 6.1 thru to 8.5

EditScreen3 from 9.1 thru to 10.13

EditScreen4 from 11.1 thru 12.22

EditScreen5 from 13.1 thru 14.13

EditScreen6 from 15.1 thru to 16.11 

 

I wish to patch all these screens in one update in case someone changes a question / radiobutton or adds a comment to the audit after some time.

 

Thanks

 

Community Support Team
Community Support Team

Re: Patch : Multiple screens to one record SharePoint - update brings error in fx.

Hi @Wapfunz,

Do these Edit form controls within your 6 Edit screen connect to same data source?

If these Edit form controls within your 6 Edit screen connect to same data source, I think you could consider take a try to modify your formula as below:

Patch(
         'YourDataSource',
          RecordYouWantToUpdate,  /* <-- Find the record you want to update using LookUp function or Filter and First function*/
          EditForm1.Updates,
EditForm2.Updates,
...
EditForm6.Updates )

Please take a try to check if you have provided valid/proper value for corresponding column within the '{ }' part in your Patch formula.

In addition, please also check if the column name you specified within the '{ }' part in your Patch formula is already existed within the Record (MyReocrd you mentioned) you want to update.

Please check and see if my response within the following thread would help in your scenario:

https://powerusers.microsoft.com/t5/Creating-Apps/Save-2-forms-from-2-pages/m-p/206525

 

Best regards,

Community Support Team _ Kris Dai
If this post helps, then please consider Accept it as the solution to help the other members find it more quickly.
Wapfunz
Level: Powered On

Re: Patch : Multiple screens to one record SharePoint - update brings error in fx.

Thank you.

All six  edit screens are attached to the same data source - a SharePoint list.

From the Browse screen a record is selected - unique ID - from the Detail screen of that record - the user selects edit and the first editscreen opens, and progressive screens as the user steps forward. On the last EditScreen6 is the update/upload changes button.

Hense all the edit screens are tied to that record which is on a SharePoint list.

Using Myrecord to stipulate the current record which is being editted, and figure that now (thank you to your help) all the editscreens are tied to that current unique record.

I am unsure, how to be honest, the lookup will work?

 

I have checked and rechecked all column names and spellings (but murphy will dicatate that syntax somewhere is a wee bit wrong) between the { }.

 

Wapfunz
Level: Powered On

Re: Patch : Multiple screens to one record SharePoint - update brings error in fx.

Hello, I have modified my "fx" (in onselect) to remove all mention of EditScreen1 thru EditScreen6 and still get same error per attached - still no joy.

Dang what am I doing wrong?

RandyHayes
Level 10

Re: Patch : Multiple screens to one record SharePoint - update brings error in fx.

@WapfunzI believe that @v-xida-msft was taking you in a good direction.

Why are you listing each and every field in your patch statement??

 

If I read your problem properly...

You have 6 screens. 

Each screen contains an Edit form. 

Each Edit form is connected to the same data source.

Each Item of the form is connected to a single record. (myRecord)

You want to actually perform the Patch/Update after the final entry screen is completed.

 

If this is the case, then consider using the Updates property of the Edit Form.  It will have any and all changes that were made on the form.

If you do the patch that was give by @v-xida-msft.  You will get a complete update from all of the edit forms into one record.

Patch(
         'YourDataSource',
          MyRecord,  RecordYouWantToUpdate,  /* <-- Find the record you want to update using LookUp function or Filter and First function*/
          EditForm1.Updates,
          EditForm2.Updates,
          ...
          EditForm6.Updates
)

You don't need to go through the pain of trying to patch and name each and every element/field of your edit forms to the patch statement.  The Updates property will hold all of that information for you.  You just do a patch and include it all and they will all be put together in your record.

 

See if that is helpful.

Wapfunz
Level: Powered On

Re: Patch : Multiple screens to one record SharePoint - update brings error in fx.

Hi, Thank you for your valued response.

 

Why are you listing each and every field in your patch statement?? - because I do not know what I dont know, and am pretty ignorant of Patch as no real life examples to follow. Just trying to adapt all valued suggestions together.

 

 I read your problem properly...

You have 6 screens. - yes to be able to edit any changes to any or all radio buttons 

Each screen contains an Edit form.  - Yes to be able to change requires one record of 160 columns spread over 6 screens

Each Edit form is connected to the same data source. - Yes correct

Each Item of the form is connected to a single record. (myRecord) - yes that unique record of 160 columns chosen to be editted - the current record with its 160 columns and unique ID.

You want to actually perform the Patch/Update after the final entry screen is completed. - yes as cannot get the whole record to show on one screen - when first saved, the complete record of 160 radio buttons is able to be shown on one screen - just scrowls allot to the end.

 

If this is the case, then consider using the Updates property of the Edit Form.  It will have any and all changes that were made on the form. - ????????????????????????????????????????

If you do the patch that was give by @v-xida-msft.  You will get a complete update from all of the edit forms into one record - mmmmmmmmmmmmm yes - that is the hope to capture any or all possible changes which have been made to any or all radio buttons or say comments added after the fact.

 

Yup I dont know what I dont know or what to ask. Basically trying to recreate a working InfoPath form in PowerApps.

Where I can open a record make heaps of changes on the one form and then re upload with corections - only I have to use 6 screens .

RandyHayes
Level 10

Re: Patch : Multiple screens to one record SharePoint - update brings error in fx.

Okay, so it looks like my assumption of the problem statement is correct. Let's start with that!

 

My advice is to jump back when you run into a head scratcher. You might find a better way.

 

So, I will offer a quick - here's a better way:  

1) I don't know what your starting point is.  Typically these things come from some Gallery or other "selected" item.  So, I'm going to assume a Gallery (Gallery1).  I know you mention you have a MyRecord you set, but you might not even need that if you are coming off of a Gallery.  If this is not the case, then substitute the "selected" items below with your MyRecord.

 

2) Since you are working with EditForm Controls, what you can simply do is this - 

For each of the 6 forms, set the dataSource to the proper dataSource (you most likely have this already - GeneralHSEAudit_Mobile)

Set the Item property to Gallery1.Selected

 

3) On the Check mark Icon you have on the final screen, add this to the OnSelect action:

   SubmitForm(EditForm1); SubmitForm(EditForm2); SubmitForm(EditForm3); SubmitForm(EditForm4); SubmitForm(EditForm5); SubmitForm(EditForm6)

 

Done!

 

If you still want to take the Patch path, then Patch(GeneralHSEAudit_Mobile, MyRecord, EditForm1.Updates, EditForm2.Updates, EditForm3.Updates, EditForm4.Updates, EditForm5.Updates, EditForm6.Updates)

 

 

See if any of this makes sense and works for you.