I've been trying to solve an issue involving the out-of-the-box Request Sign-off Flow that can be enabled on SharePoint lists and libraries. In my travels, I noticed that one logical clause on both the Approved and Rejected branch "Do until" actions has its logic inverted.
That is, the "Do until" condition in both branches state, as seen in the screenshot:
On the first loop check, Retries (1) is always less than 20, so even if the update item action fails, the "Do until" loop immediately ends and the Approve/Reject failure email notification is sent, instead of trying again after 1,4,9,16,25,[...] minutes as intended. The first clause should be either "less(20,variables('retries'))" or "more(variables('retries'),20)".
P.S. For anyone wondering, I gained access to this Flow by following John Liu's quasi-related article here:
Hi @joshnystrom ,
How do you set up the “updatesucceeded” variable?
Could you share more details on the results?
You are using or function, so when one of the conditions meets, it will return True. Please take a try with and function to see if it will work as expected.
Just to clarify - this Flow is not my design. It is the "Request sign-off" Flow that is auto-created on a SP List or Library when selected within the Configure Flows flyout, as seen here:
So, I am seeking only to bring this to the Flow development team's attention. The flaw is plain and apparent, and if you'd like to see for yourself, you can follow some of the steps in the John Liu article I linked to gain access to this same Flow from any List or Library configured as shown.
Hi @joshnystrom ,
Thanks for feedback.
I will help report this issue on my side.
Many congratulations to the Season 1 2021 Flownaut Crew!
Check out our new profile badges recognizing authored solutions!
Check out the community blog page where you can find valuable learning material from community and product team members!