Recently a control I have had published for quiet some time started to break (in July). This code base has not changed and has been working fine for some time. Trying to determine what update is causing this change in behavior. The issue is on initial load the field mapped to the control shows null data. But if you do a post back again (F5) it will work on the second load and if you exit the record and re-open it will work fine. Trying to understand why all of a sudden it's displaying null on initial load. As I have said - the code hasn't changed since Mar 18, 2020. This is a modified version of the PeoplePicker control -
import { IInputs, IOutputs } from "./generated/ManifestTypes";
import * as React from 'react';
import * as ReactDOM from 'react-dom';
import { PeoplePickerTypes, IPeopleProps, IPeoplePersona } from './Peoplepicker';
export class OfficeUIFabricReactPeoplePicker implements ComponentFramework.StandardControl<IInputs, IOutputs> {
private theContainer: HTMLDivElement;
private notifyOutputChanged: () => void;
private _context: ComponentFramework.Context<IInputs>;
private props: IPeopleProps = {
//tableValue: this.numberFacesChanged.bind(this),
peopleList: this.peopleList.bind(this),
}
/**
* Empty constructor.
*/
constructor() {
}
/**
* Used to initialize the control instance. Controls can kick off remote server calls and other initialization actions here.
* Data-set values are not initialized here, use updateView.
* @Param context The entire property bag available to control via Context Object; It contains values as set up by the customizer mapped to property names defined in the manifest, as well as utility functions.
* @Param notifyOutputChanged A callback method to alert the framework that the control has new outputs ready to be retrieved asynchronously.
* @Param state A piece of data that persists in one session for a single user. Can be set at any point in a controls life cycle by calling 'setControlState' in the Mode interface.
* @Param container If a control is marked control-type='standard', it will receive an empty div element within which it can render its content.
*/
public init(context: ComponentFramework.Context<IInputs>, notifyOutputChanged: () => void, state: ComponentFramework.Dictionary, container: HTMLDivElement) {
// Add control initialization code
this.notifyOutputChanged = notifyOutputChanged;
this._context = context;
this.theContainer = container;
}
/**
* Called when any value in the property bag has changed. This includes field values, data-sets, global values such as container height and width, offline status, control metadata values such as label, visible, etc.
* @Param context The entire property bag available to control via Context Object; It contains values as set up by the customizer mapped to names defined in the manifest, as well as utility functions
*/
public async updateView(context: ComponentFramework.Context<IInputs>) {
// Add code to update control view
this.props.context = context;
if (context.parameters.peoplePicker.raw !== null) {
if (context.parameters.peoplePicker.raw!.indexOf("text") > 1) {
this.props.preselectedpeople = JSON.parse(context.parameters.peoplePicker.raw!);
}
}
ReactDOM.render(
React.createElement(
PeoplePickerTypes,
this.props
),
this.theContainer
);
}
/**
* It is called by the framework prior to a control receiving new data.
* @returns an object based on nomenclature defined in manifest, expecting object[s] for property marked as “bound” or “output”
*/
public getOutputs(): IOutputs {
return {
peoplePicker: JSON.stringify(this.props.people)
};
}
private peopleList(newValue: IPeoplePersona[]) {
if (this.props.people !== newValue) {
if (newValue.length === 0) {
this.props.people = undefined;
}
else {
this.props.people = newValue;
}
this.notifyOutputChanged();
}
}
/**
* Called when the control is to be removed from the DOM tree. Controls should use this call for cleanup.
* i.e. cancelling any pending remote calls, removing listeners, etc.
*/
public destroy(): void {
// Add code to cleanup control if necessary
ReactDOM.unmountComponentAtNode(this.theContainer);
}
}
Solved! Go to Solution.
No, the "null first, value second" thing is something I've seen before, that's why I knew to guess it. I am not sure how to reliably reproduce (or avoid) it, which is why I just take approaches that circumvent it. So again, make sure your nullcheck is safe (you already have a !== null, so that should safely avoid any exceptions) then add in a line right before your reactdom.render, basically the same thing you are doing in Dispose:
ReactDOM.unmountComponentAtNode(this.theContainer);
This will let your component run once, with a null string, which will render nothing in the picker. But then when updateView gets called again and has a value, it will unload that empty version of the control and reload with an actual value.
Nothing is jumping out at me as problematic in this code. What do you see when you debug the control using browser developer tools?
Hi @shadowfox
I don't know if that has something to do with it, but what's the reason of searching the "text" inside the peoplePicker parameter?
context.parameters.peoplePicker.raw!.indexOf("text")
If after the reload it works, maybe the first render triggers the "peopleList" witch changes the value.
Otherweise, I agree with @cchannon , it depends on which values are passed to updateView when it's triggered.
Kind regards,
Diana
@cchannon When using the debug tool - on the initial load when it first hits the updateview this is what I see (image below which shows the field being null) -
But then on the second call of the updateview is shows the data but at this point it's not rendering.
If I close the page and re-open the initial load this time has a value -
This is the part that makes no sense to me. The fact on a cold load - the initial is null but then after closing and re-opening it's fine. As I said - this has been working wonderfully for over a year with no issues but this behavior just started. I did also try to update my npm packages and see if that fixed it but no luck.
Thanks.
@DianaBirkelbach thanks for the reply! The indexOf("text") is verifying the JSON has the label text in it to get the label for the control. Otherwise if text is missing, then the JSON main part is malformed and won't work. Hope that helps better explain that. Sadly - with the issue I'm having - I'm not hitting this part since the field is passing null on the initial cold load.
Thanks!
Hi @shadowfox ,
Now I'm making some wild guessing.
Maybe the "this.props" makes some trouble because the props is reserved in react, and the PCFs are based on react. Thinking of it, you actually don't need the private "props" in your class, which you also pass as a reference to the component PeoplePickerTypes as props. I also suppose that the changing of the content inside the props won't be reflected, since you render the PeoplePickerTypes with the same reference of the props, but you change the content (props should be immutable).
In your class, you only need the value (in your case the people).
So I suggest, not to define a private "props" in your class. The props you pass to your PeoplePickerTypes can be defined just where you call the render function. All you need to keep in the class is the value for people, and the function itself (peopleList).
I've also saw that the updateView is declared "async". Not so sure if it's supposed to work that way, but I also don't see where you have the await. I suggest to delete the async.
It the explanation is not clear enough, please let me know.
Hope it helps.
Kind regards,
Diana
@shadowfox When you say, "the field is passing null" do you mean
context.parameters.peoplePicker.raw
is coming through as null even though the attrib does contain a JSON value?
@cchannon Yes - that was on the debugger image I grabbed. The context.parameters.peoplePicker.raw is null on initial cold load. Very crazy - this is something new I'm experiencing.
@DianaBirkelbach thanks for the reply. You did catch something I was trying just to see if it made a difference but it didn't. Here is the original code for that part. I was initially just using context.parameters.peoplePicker.raw but wanted to see if the this.props.context made any difference (mostly because I'm stuck and nothing else I tried worked so figured I'd try it just to rule it out). As for the async - this was initially developed as part of the PCF Gallery control - People Picker | PCF Gallery. I have modified the React code quiet a bit to handle any entity and fixed an issue with the async promise. But the index.ts page has been left untouched since I pulled it down. What's blogging my head its been working for over a year now just fine. This makes me think something with how controls are being rendered on cold load and binding has been changed. Thanks for the help!
public async updateView(context: ComponentFramework.Context<IInputs>) {
// Add code to update control view
this.props.context = context;
if (context.parameters.peoplePicker.raw !== null) {
if (context.parameters.peoplePicker.raw!.indexOf("text") > 1) {
this.props.preselectedpeople = JSON.parse(context.parameters.peoplePicker.raw!);
}
}
ReactDOM.render(
React.createElement(
PeoplePickerTypes,
this.props
),
this.theContainer
);
}
Well, updateView gets called multiple times onLoad (at least two, could be more depending on what's happening on your form) and you can even force it to fire with Client Script by using the fireOnChange() function.
So try debugging again and just put your breakpoint at the top of updateView. Is contex.parameters.peoplePicker null every time updateView gets called, or maybe just the first time?
This weekly series is our way of helping the amazing members of our community--both new members and seasoned veterans--learn and grow in how to best engage in the community! Each Tuesday, we will feature new areas of content that will help you best understand the community--from ranking and badges to profile avatars, from Super Users to blogging in the community. Our hope is that this information will help each of our community members grow in their experience with Power Platform, with the community, and with each other! Have you ever wondered how your fellow community members earn the different ranks available? What is the difference between an Advocate and a Helper, a Solution Sage and a Community Champion? In today's #TuesdayTip, we share the secrets and tips to help YOU keep your ranking growing--and why it's so important to our communities. What are community ranks? - Power Platform Community (microsoft.com) Get the details in this Knowledge Base article that shows you what ranks are, how they are achieved, and what they mean to you as you engage with other community members on a regular basis. Once you start your journey in the community, ranking up, you'll find the benefits. So get busy with those kudos, solutions, and more! We can't wait to see how you rank!That's it for this week. Tune in for more Tuesday Tips next Tuesday and join the community as we continue to get "Back to Basics."
After all the planning and preparing, the annual Microsoft Power Platform Conference is finally here! We are excited to see so many of our community in Las Vegas this week. To help make sure you don't miss any of the workshops, sessions, and events we have planned, make sure to check out this handy Community One-Sheet, and download the pdf today! Make sure to stop by the Community Lounge to meet @hugobernier, @EricArcher, @heaher_italent, and @AshleyFelts from our team! See you in Vegas!
Join us for the first-ever the Biz Apps Community User Group meeting live from the Power Platform Conference! This one hour user group meeting is all about discovering the value and benefits of User Groups! Discover how you can find a group in your local area or about specific topics where you can learn new skills and meet like-minded people as a user group member. Hear from User Group leaders about why they do what they do and what resources they receive to help them succeed as community ambassadors. If you have never attended a User Group meeting before, this will be a great introduction! We hope you are inspired to find a group that meets your unique interests! October 5th at 2:15 pm Pacific time If you're attending #MPPC23 in Las Vegas, join us in person! Find out more here: https://powerplatformconf.com/#!/session/Biz%20Apps%20Community%20User%20Group%20Meeting%20-%20Live%20from%20MPPC/6172 Not at MPPC23? Attend vvirtually by registering here: https://aka.ms/MPPCusergroupmeeting2023 If you can't attend this meeting live, don't worry! We will record this meeting and share it with the Community at powerusers.microsoft.com
We are excited to kick off our new #TuesdayTIps series, "Back to Basics." This weekly series is our way of helping the amazing members of our community--both new members and seasoned veterans--learn and grow in how to best engage in the community! Each Tuesday, we will feature new areas of content that will help you best understand the community--from ranking and badges to profile avatars, from Super Users to blogging in the community. Our hope is that this information will help each of our community members grow in their experience with Power Platform, with the community, and with each other! This Week's Tips: Account Support: Changing Passwords, Changing Email Addresses or Usernames, "Need Admin Approval," Etc.Wondering how to get support for your community account? Check out the details on these common questions and more. Just follow the link below for articles that explain it all.Community Account Support - Power Platform Community (microsoft.com) All About GDPR: How It Affects Closing Your Community Account (And Why You Should Think Twice Before You Do)GDPR, the General Data Protection Regulation (GDPR), took effect May 25th 2018. A European privacy law, GDPR imposes new rules on companies and other organizations offering goods and services to people in the European Union (EU), or that collect and analyze data tied to EU residents. GDPR applies no matter where you are located, and it affects what happens when you decide to close your account. Read the details here:All About GDPR - Power Platform Community (microsoft.com) Getting to Know You: Setting Up Your Community Profile, Customizing Your Profile, and More.Your community profile helps other members of the community get to know you as you begin to engage and interact. Your profile is a mirror of your activity in the community. Find out how to set it up, change your avatar, adjust your time zone, and more. Click on the link below to find out how:Community Profile, Time Zone, Picture (Avatar) & D... - Power Platform Community (microsoft.com) That's it for this week. Tune in for more Tuesday Tips next Tuesday and join the community as we get "Back to Basics."
Welcome to our September 2023 Newsletter, where we highlight the latest news, product releases, podcasts, upcoming events, and the great work of our Power Platform Community members. As usual, please make sure you follow our News & Announcements in the Community to stay up to date. Another great way to connect is to join our Power Platform Community on LinkedIn. You can join our LInkedIn community here. MPPC's Got Power - Submissions end September 28th! Are you ready to showcase your skills at the Microsoft Power Platform Conference in Las Vegas? Don't miss out on the "MPPC's Got Power" talent show, a grand celebration of connection, inspiration, and shared journeys. Whether you're a technical innovator, a talented storyteller, or have a hidden creative side, we want to see what you've got! With three categories to choose from, you have the chance to shine on stage and make your mark in the Microsoft Power Platform community. Click the GIF to sign up by Thursday 28th September to be part of an unforgettable MPPC23 experience. Now is your time to shine! Check Out the Low Code Approach Podcast Give the Low Code Approach Podcast a listen! Hosted by Sean Fiene, Wendy Haddad, and Kenric Auguillard, this innovative show shines a light on how Microsoft MVPs, product team members, and Community users are building exciting solutions using Microsoft Power Platform. Plus, with guests like Kartik Kanakasabesan, April Dunnam, Ricardo Duncan Jr., Sonja Gu, Phil Topness, Shane Young and more, this weekly show is a must for all you Business Applications enthusiasts out there. Click the image below to check it out! COMMUNITY HIGHLIGHTS Check out the most active Community users for August 2023. These hardworking members are posting regularly, answering questions, writing blogs, giving kudos, and providing top solutions in their communities across Power Platform. Huge thanks to these amazing community members for their great contributions last month! trice602poweractivateLaurensMWarrenBelzAmikBCBuizerSamLedcreativeopinion timlExpiscornovusManishSolankiMattJimisonfernandosilvaMisterMarkPstork1saudali_25hafizsultan242Lucas001ragavanrajanp_doc UPCOMING EVENT: 365 EDUCON CHICAGO Whether you're new to Microsoft 365, Power Platform and SharePoint, or an experienced power user, admin or developer, 365 EduCon has content designed to fit your experience level and area of interest. Their workshops and sessions are taught by Microsoft Certified Trainers, MVPs, Regional Directors, and Engineers. Find out more and register here: Home - Microsoft 365 EduCon Chicago - A Microsoft 365 Conference.
Are you attending the Microsoft Power Platform Conference 2023 in Las Vegas? If so, we invite you to join us for the MPPC's Got Power Talent Show! Our talent show is more than a show—it's a grand celebration of connection, inspiration, and shared journeys. Through stories, skills, and collective experiences, we come together to uplift, inspire, and revel in the magic of our community's diverse talents. This year, our talent event promises to be an unforgettable experience, echoing louder and brighter than anything you've seen before. We're casting a wider net with three captivating categories: Demo Technical Solutions: Show us your Power Platform innovations, be it apps, flows, chatbots, websites or dashboards... Storytelling: Share tales of your journey with Power Platform. Hidden Talents: Unveil your creative side—be it dancing, singing, rapping, poetry, or comedy. Let your talent shine! Got That Special Spark? A Story That Demands to Be Heard? Your moment is now! 🚀 Sign up to Showcase Your Brilliance: https://aka.ms/MPPCGotPowerSignUp 🔥 Deadline for submissions: Thursday, Sept 28th How It Works: Submit this form to sign up: https://aka.ms/MPPCGotPowerSignUp We'll contact you if you're selected. Get ready to be onstage! The Spotlight is Yours: Each participant has 3-5 minutes to shine, with insightful commentary from our panel of judges. We’re not just giving you a stage; we’re handing you the platform to make your mark. Be the Story We Tell: Your talents and narratives will not just entertain but inspire, serving as the bedrock for our community’s future stories and successes. Celebration, Surprises, and Connections: As the curtain falls, the excitement continues! Await surprise awards and seize the chance to mingle with industry experts, Microsoft Power Platform leaders, and community luminaries. It's not just a show; it's an opportunity to forge connections and celebrate shared successes. Event Details: 📆 Date and Time: Wed Oct 4th, 6:30-9:00PM 📍 Location: MPPC23 at the MGM Grand, Las Vegas, NV, USA
User | Count |
---|---|
11 | |
4 | |
3 | |
3 | |
2 |