Help with Patch and ForAll

[kky1]

Hello - I've read a number of posts on this topic (and think my code is close), but I still am getting errors while attempting to patch a collection to a Sharepoint list. I am not patching to all the Sharepoint columns - just those specified using the ShowColumns function. 

Sp list name: 'InventoryOrders'

collection name: colMyCart

Code:

UpdateContext({showLoading: true});
// insert a new row for each product ordered into the SharePoint list
Patch(
    'InventoryOrders',
    ForAll(
        colMyCart,
        Defaults('InventoryOrders')
    ),
    ShowColumns(
        colMyCart,
        "ProductId",
        "ProductName",
        "Model",
        "Color",
        "Quantity",
        "PricePer",
        "UserName",
        "UserID",
        "UserEmail"
    )
);
UpdateContext({showLoading: false});
Navigate(PlaceOrderScreen);

The error:

And the Sharepoint list columns ( I should note the actual names of the columns are field_1, field_2, etc, but with the setting to use display names in columns, the app seems to be recognizing their actual names):

It appears it is expecting a record rather than a table eventhough I have the ForAll function included.

Thank you to anyone who can assist.

Kendra

@kky1 

[poweractivate]

@kky1 Temporarily try the inefficient way (I hate it, but it may help debug for now), with ForAll outside Patch like I gave it. Try removing the Color, etc as well. See if you can get a version working at all. Then I might try give you the optimized version Patch outside ForAll.

[kky1]

Sounds good @poweractivate. I've pasted in the updated code with the ForAll and then the Patch. It's throwing a different error in that field_3 is the wrong data type (text) when it expects a record. And I think @SebS is onto something bc field_3 is the Color field in my SP list. 

[SebS]

@kky1 

Try to add the change I mentioned in the code, and @poweractivate  code should work

UpdateContext({varShowLoading: true});

// Go through each item in colMyCart and patch it to InventoryOrders
ForAll(
    colMyCart,
    Patch(
        'InventoryOrders',
        Defaults('InventoryOrders'),
        {
            ProductId: ProductId,
            ProductName: ProductName,
            Model: Model,
            Color: {Value: Color},
            Quantity: Quantity,
            PricePer: PricePer,
            UserName: UserName,
            UserID: UserID,
            UserEmail: UserEmail
        }
    )
);

UpdateContext({varShowLoading: false});
Navigate(PlaceOrderScreen, ScreenTransition.None);

[kky1]

Okay I removed and it didn't like field_7 (PricePer) bc apparently the collection thought it was text and not number, so I added Value to it. The formula is now not throwing errors: 

UpdateContext({varShowLoading: true});
// Go through each item in colMyCart and patch it to InventoryOrders 
ForAll(
    colMyCart,
    Patch(
        'InventoryOrders',
        Defaults('InventoryOrders'),
        {
            ProductId: ProductId,
            ProductName: ProductName,
            Model: Model,
            Quantity: Quantity,
            PricePer: Value(PricePer),
            UserName: UserName,
            UserID: UserID,
            UserEmail: UserEmail
        }
    )
);
UpdateContext({varShowLoading: false});
Navigate(
    PlaceOrderScreen,
    ScreenTransition.None
);

[poweractivate · Accepted solution]

@kky1 

Did it work with the ForAll suboptimal version and did you take Color out?
And yes you have to use Value for choice, like below:

ForAll(
    colFormattedCart,
    Patch(
        'InventoryOrders',
        Defaults('InventoryOrders'),
        {
            ProductId: ProductId,
            ProductName: ProductName,
            Model: Model,
            Color: { Value: Color },  // Notice the use of Value for the Choice column
            Quantity: Quantity,
            PricePer: PricePer,
            UserName: UserName,
            UserID: UserID,
            UserEmail: UserEmail
        }
    )
);

Try it without the Color at all first. Does it work?
Then try introducing the color, using the Value syntax like above, does it also work?

Finally I may check the optimal version for you with the Patch outside ForAll instead of ForAll outside Patch.

[poweractivate]

@kky1 
So this version doesn't throw error?

UpdateContext({varShowLoading: true});
// Go through each item in colMyCart and patch it to InventoryOrders 
ForAll(
    colMyCart,
    Patch(
        'InventoryOrders',
        Defaults('InventoryOrders'),
        {
            ProductId: ProductId,
            ProductName: ProductName,
            Model: Model,
            Quantity: Quantity,
            PricePer: Value(PricePer),
            UserName: UserName,
            UserID: UserID,
            UserEmail: UserEmail
        }
    )
);
UpdateContext({varShowLoading: false});
Navigate(
    PlaceOrderScreen,
    ScreenTransition.None
);

Try reintroduce Color if you need it using example from my recent post, then I may try give optimal version Patch outside ForAll if the above works with the Color as Value syntax

[kky1]

Update: the latest formula is working! 🙂 It patched correctly the values to the SP list from the collection ShowColumns!

[poweractivate]

@kky1 If it works you can use it but when you used Patch outside ForAll initially you were doing it the better way. If in a hurry and have no time you can keep the ForAll outside Patch like now, but the way you were trying first was the better one. Now that you have a working version ForAll outside Patch now it may be worth trying to get it so it works with Patch outside ForAll. In a moment I may try give you one to attempt.

[kky1]

Yes, it's working now with Color added back into it. Thank you so much @SebS and @poweractivate!! 

[poweractivate]

@kky1 

Try this optimized version below which keeps the Patch outside ForAll,

but it's possible Patch doesn't work with Defaults 2nd arg and new records table as 3rd arg.

If not, then you have to revert / keep the original suboptimal version that is already working.

However if you can please give a try on the below to see if it works:

UpdateContext({varShowLoading: true});
ClearCollect(
    colFormattedCart,
    ForAll(
        colMyCart,
        {
            ProductId: ProductId,
            ProductName: ProductName,
            Model: Model,
            Quantity: Quantity,
            PricePer: Value(PricePer),
            UserName: UserName,
            UserID: UserID,
            UserEmail: UserEmail
        }
    )
);

Patch(
    'InventoryOrders',
    Defaults('InventoryOrders'),
    colFormattedCart
);

UpdateContext({varShowLoading: false});
Navigate(PlaceOrderScreen, ScreenTransition.None);

If not working, then revert your ForAll outside Patch version you had before.

It's possible the optimal way with Patch outside ForAll can only be done if we have a table of base records to use to change, otherwise we may have to use the way I don't like with ForAll outside Patch and the ForAll output table left unused.

However give a try on the above, the above is the better way to do it if it works.

If it gives an error provide the screnshot of the error in the formula in next reply if you can, so I can keep it in mind, then use the working version even if suboptimal.

See if it helps @kky1