For All patch is not patching correct information, repeating 1 value for all enteries

[Anonymous]

I have a new beverage placement application that allows sales people to submit new product placements and the corresponding forecast for their customers.  

This all gets patched to two share point lists, Placement Master, Placement Details.

Placement Master has fields such as Created By, Island(i'm in hawaii and use this to filter the customer list by island), Customer, and Comments

Placement Details holds all the fields for the item related things.  They can place multiple items and multiple suppliers to one customer.  

Right now everything patches fine except for one column, Planner.  The planner is the person who buys for that supplier.  They need to know about new placements so they can adjust ordering levels.  However the same email is getting patched, even though these two suppliers have different buyers.  I've tried this with multiple suppliers and whichever planner email is first in the gallery gets copied down.

Here is a picture of the gallery and you can see the two different emails:

Item Number (ItemCode in the collection), Forecast (ItemForecast in the collection), and comments (ItemComments in the collection) are part of a collection.  There are two labels under the comments text box, visible for the picture, not part of the collection (thus this could be the issue.  However the label on the left of the picture is the supplier.  It is a lookup and using the ItemCode part of the placementCollection, which is probably why that patches correctly.  However email address lookups the value in the supplier label and then references another list (one that links my supplier to the buyer). I believe this is where my issue is happening with patch.  Since it is not referencing the current collection item it is just grabbing and copying the very first value in the entire collection and patching that.  

Here is the patch code

Set(
    LastSubmittedSample,
    Patch(
        'Placement Master',
        Defaults('Placement Master'),
        {
            Branch: PlacementBranch,
            Customer: CreatePlacementComboBox.Selected.Result,
            PlacementStatus: PlacementStatus
        }
    ).ID
);
ForAll(
    PlacementCollection,
    If(
        !IsBlank(ItemCode),
        Patch(
            'Placement Details',
            Defaults('Placement Details'),
            {
                PlacementStatus: "New",
                Title: LookUp(
                    'Item List',
                    Item_Code = ItemCode,
                    Nomenclature
                ),
                PlacementMasterID: LastSubmittedSample,
                Forecast: ItemForecast,
                EstatesFlag: LookUp(
                    'Item List',
                    Item_Code = ItemCode,
                    Estates
                ),
                Supplier: LookUp(
                    'Item List',
                    Item_Code = ItemCode,
                    Supplier
                ),
                Comments: ItemComments,
                Planner: CreatePlacementPlannerLabel.Text
            }
        )
    )
);
Navigate(
    Home,
    Cover
);
Refresh('Placement Master');
Refresh('Placement Details')

I could fix this my simply putting the planners email address in the Item list, but with over 8000 items if planners change that would be a nightmare.  It is one planner per supplier which is why I want to link them this way.  Much easier for control and updating.

Any ideas are greatly appreciated.

Thank you

[yashag2255 · Accepted solution]

Hi @Anonymous 

This is a Power Apps related question and you can get better responses if you post it on the Power Apps forum. But here is my take on it. 

The issue here is that you are applying forall on the collection, it is not going to get individual items from each of the rows in the gallery. To get the value from text label inside a gallery, the forall must be applied to GalleryName.AllItems. If you apply the forall on the collection, it is just going to recognize the first item in the gallery if referenced via CreatePlacementPlannerLabel.Text

I assume that you have the same collection present as part of the Gallery Items. Can you try to update the expression to:

Set( LastSubmittedSample,
    Patch(
        'Placement Master',
        Defaults('Placement Master'),
        {
            Branch: PlacementBranch,
            Customer: CreatePlacementComboBox.Selected.Result,
            PlacementStatus: PlacementStatus
        }
    ).ID
);
ForAll(
    GalleryName.AllItems,
    If(
        !IsBlank(ItemCode),
        Patch(
            'Placement Details',
            Defaults('Placement Details'),
            {
                PlacementStatus: "New",
                Title: LookUp(
                    'Item List',
                    Item_Code = ItemCode,
                    Nomenclature
                ),
                PlacementMasterID: LastSubmittedSample,
                Forecast: ItemForecast,
                EstatesFlag: LookUp(
                    'Item List',
                    Item_Code = ItemCode,
                    Estates
                ),
                Supplier: LookUp(
                    'Item List',
                    Item_Code = ItemCode,
                    Supplier
                ),
                Comments: ItemComments,
                Planner: CreatePlacementPlannerLabel.Text
            }
        )
    )
);
Navigate(
    Home,
    Cover
);
Refresh('Placement Master');
Refresh('Placement Details')

Hope this Helps!

If this reply has answered your question or solved your issue, please mark this question as answered. Answered questions helps users in the future who may have the same issue or question quickly find a resolution via search. If you liked my response, please consider giving it a thumbs up. THANKS!

[Anonymous]

Works like a charm.  

Thanks