cancel
Showing results for 
Search instead for 
Did you mean: 
Reply
tundaka
New Member

Lookup not working properly in ForAll?

Hello everyone, I am fairly new in PowerApps so now, I don't know it's limitation or I just haven't found the solution.

I have a simple app that I want to do, basically it's a bulk upload tool of salary. My idea was to put it in a delimited text, and then delimit it in a gallery.

 

tundaka_0-1648042828137.png

 

Here's my code in the upload button :

 

 

 

ForAll(
Gallery2.AllItems,
Patch(
'Salary Series',
Defaults('Salary Series'),
{'Employee ID':
LookUp(
Employees,
'Employee ID' = txt_employeeID.Text
)
},
{Value: Value(txt_Value.Text)}
)
)

 

 

 

 

tundaka_2-1648042990979.png

 

it works, but it doesn't lookup the employee id, it only does it in the first row. (Employee ID is a Lookup column to Employees table). Hopefully someone could help me.

32 REPLIES 32

Huge face palm from my side, my apologies, just realized I never mentioned it in my post. 

Yes my biggest problem here is the Employee id which is a lookup column.

My datasource is dataverse.

I only have 2 necessary tables for this:

Employees Table:

Employee ID 

Employee Name

 

Salary Series Table
Employee ID (lookup column to Employees Table)

Value (which is the salary)

 

Number 3 is perfect, exactly what is intended for.

RandyHayes
Super User
Super User

@tundaka 

Very good, so starting from the textinput...

Your Items property on the Gallery should be:

Filter(
    ForAll(
        Split(TextInput1.Text, "||"),
        With({_record: Split(Result, ":")},
           {EmployeeID: First(_record).Result,
            Salary: Last(_record).Result
           }
        )
    ),
    !IsBlank(EmployeeID)
)

Your Default on the txt_employeeID control should be: ThisItem.EmployeeID

Your Default on the txt_Value control should be: ThisItem.Salary

 

Your Upload OnSelect action formula should be:

Patch('Salary Series',
    ForAll(Filter(Gallery2.AllItems, !IsBlank(txt_employeeID.Text))
        {'Employee ID': LookUp(Employees, 'Employee ID' = txt_employeeID.Text),
          Value: Value(txt_Value.Text)
        }
    )
)

 

Not sure what the purpose of the other buttons in your picture are for, but I am not seeing a need for them.

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Thank you for baring with me, yes the code works in a sense that it does the patch, but the issue still persists, it only does the lookup for the first entry:

tundaka_0-1648052311646.png

this is currently the entry, and it only fills the employee id for the P1603 (214000 salary).

P1603:214000||
P2111:216000||
P0001:236000

 

even if I interchange the entries, starting with P2111, P2111 (216000 salary) will only be filled.

P2111:214000||
P1603:216000||
P0001:236000

tundaka_1-1648052514298.png

RandyHayes
Super User
Super User

@tundaka 

Then it is not finding the employees in your employee table!

Verify that the 'Employee ID' column in your employee table records has matching employees.

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

It is verified that these employees exists and matches their employee id.

This is the employee table:

tundaka_0-1648054393896.png

 

Segway question, do you have anything that you can think of to achieve the same goal but different approach? Been stuck in this problem for days and really don't know if I can still solve this. Really appreciate your effort assisting me on this. 

 

TheRobRush
Super User
Super User

Just so we can see what the forall is currently returning, might have somethign wrong on your side syntax wise

 

but a button in there with onselect of

ClearCollect(TestBatch,
ForAll(Filter(Gallery2.AllItems, !IsBlank(txt_employeeID.Text))
        {'Employee ID': LookUp(Employees, 'Employee ID' = txt_employeeID.Text),
          Value: Value(txt_Value.Text)
        }
    )
)

and share a picture of the collection that returns for you with randy

_____________________________________________________________________________________
Like my answer? - Hit that Thumbs Up. Resolved the Issue? - Hit Accept as Solution.
This helps others find solutions to future issues!

@tundaka 

The formula is all good.  It is just not picking up any other employees by the ID.

We know it is at least picking up one!

 

Try to hand-write a value in that is not working and see if it produces a result.

Example:

Patch('Salary Series',
    ForAll(Filter(Gallery2.AllItems, !IsBlank(txt_employeeID.Text))
        {'Employee ID': LookUp(Employees, 'Employee ID' = "P2111"),
          Value: Value(txt_Value.Text)
        }
    )
)

It will not produce correct results obviously, but it will verify if the lookup is happening properly.

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

I think what he is saying is @RandyHayes is that he knows the IDs are right because if he takes the second id and moves it up to first spot then what used to be second one will now update, but no others. So it seems whatever id he writes as first id is patching but nothing after it.

 

Figure collecting it all will at least show us what is being looked at the way he has it written. Could also place a lookup or countrows label next to your text boxes on the right @tundaka that checks if the things in textbox next to them are in the id list. Maybe the split is slightly wrong and theres a phantom space or something that is making your number not match

_____________________________________________________________________________________
Like my answer? - Hit that Thumbs Up. Resolved the Issue? - Hit Accept as Solution.
This helps others find solutions to future issues!
RandyHayes
Super User
Super User

@TheRobRush 

Actually not how I read the response!  From what I saw, ONLY the P1603 employee was getting referenced properly.

That is why I mention putting in a hard-text value for one that does NOT seem to be working to see if the LookUp is having the issue.

 

The nice thing about using the ForAll properly is that you don't even need to do all that collection stuff (variable preferred anyway!), you can simply put your cursor at the end of the ForAll (or highlight the entire ForAll) and the formula editor will show you all the results of the table...so that will show everything you need.  

Why I say the variable is preferred is that you can view it easier.  The collection viewer will only show you 5 records.  But again, not even needed in this case as the ForAll will provide results in the formula editor.

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!
TheRobRush
Super User
Super User

Think you may be right and I misread. Just glancing at what we see in the screenshot a couple posts back, and post 2 before it we see a column called crf02_employeeid with the three example employees they have been using with values there of 

 

P2111 starting with ca751959

P1603 starting with c9751959

 

And the post two above that where they showed us what updated when p1603 is first and then second image where p2111 is listed first has the employeeid filled in on the ezample.image we got so i assumed that meant only.that record was updating. But in the one where p1603 is first the serial number for employee id in image refers to p2111 and in second image where p2111 is shown first the serial number shown in image is the one linked to p1603 so I am not sure myself what I am looking at maybe and just assumed it was only updating first result

_____________________________________________________________________________________
Like my answer? - Hit that Thumbs Up. Resolved the Issue? - Hit Accept as Solution.
This helps others find solutions to future issues!

Helpful resources

Announcements
Power Apps News & Annoucements carousel

Power Apps News & Announcements

Keep up to date with current events and community announcements in the Power Apps community.

Power Apps Community Blog Carousel

Power Apps Community Blog

Check out the latest Community Blog from the community!

Top Solution Authors
Top Kudoed Authors
Users online (3,637)